From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#22471: ert batch should print compile parsable error messages Date: Fri, 22 Oct 2021 17:15:35 -0700 Message-ID: References: <87bn878jsv.fsf@russet.org.uk> <87wo1tp8z2.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000e2ddb405cefa06ff" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23297"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 22471@debbugs.gnu.org, Phillip Lord To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 23 02:16:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1me4hn-0005sY-1E for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Oct 2021 02:16:11 +0200 Original-Received: from localhost ([::1]:38836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1me4hl-0000S9-F5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Oct 2021 20:16:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1me4he-0000Rg-GB for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 20:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1me4he-0007H7-6y for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 20:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1me4hd-0001jG-Ob for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 20:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Oct 2021 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22471 X-GNU-PR-Package: emacs Original-Received: via spool by 22471-submit@debbugs.gnu.org id=B22471.16349481456596 (code B ref 22471); Sat, 23 Oct 2021 00:16:01 +0000 Original-Received: (at 22471) by debbugs.gnu.org; 23 Oct 2021 00:15:45 +0000 Original-Received: from localhost ([127.0.0.1]:34003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me4hM-0001iK-Tj for submit@debbugs.gnu.org; Fri, 22 Oct 2021 20:15:45 -0400 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:54799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me4hK-0001i5-1o for 22471@debbugs.gnu.org; Fri, 22 Oct 2021 20:15:43 -0400 Original-Received: by mail-pj1-f52.google.com with SMTP id np13so3999672pjb.4 for <22471@debbugs.gnu.org>; Fri, 22 Oct 2021 17:15:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=2s9rFJ87CC81sat2Jur2wtwLhzx9cQtGIKm4i8kjBoo=; b=nP9WrMBI3OntRzzIuuhaiqvBv+Yh2A6pqbEUYNzEFxgDOIG5kBJC7rQpidf97VtHEr eBpLWOkq3dPbR45/i60qpuuN+XGQm3QbQV1crudl9atPeNmr/Yr2+0ALMt2CYeK2jqI3 DV3gH/13kHqjMqgqwhfsFTTuCO5xetjk6cwyB+eBgsz8PJvGGTm5KimILetqQWCGCB1g KUiYRkDgV2/FE5ZZXTSMrUBeXr0X8i6li2yVIYMQsvmqDBYc9qh5SuXob0kCS2ZnwQf6 yAqkKNHaO+7qY6pdX4hg8jPzoCcLWwJyzMbnxFY2R4/M1V1N6HGUQ6ErHwoxwy9Htb2k Dryw== X-Gm-Message-State: AOAM532bzVkZj7KLj4b+meavAtthvl6JfCg3rx1KfMyBR3lg+RTCfV5V z3w5gFH+Yog6hsfXi5cRHxanIP7yaSjXQVxp0ew= X-Google-Smtp-Source: ABdhPJxTWd49sHX4BY2m0TRQPylq3TiYStKNMjxB/mtXUK7Aweuu04SbpIz5TlQCX8o/Dgsy6ygd3fIJdfxJsGTUoQs= X-Received: by 2002:a17:90a:245:: with SMTP id t5mr3290512pje.133.1634948136222; Fri, 22 Oct 2021 17:15:36 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 22 Oct 2021 17:15:35 -0700 In-Reply-To: <87wo1tp8z2.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 20 Aug 2020 18:39:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217927 Archived-At: --000000000000e2ddb405cefa06ff Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > phillip.lord@russet.org.uk (Phillip Lord) writes: > >> Currently, when running in batch, ert prints out messages like so: >> >> Running 24 tests (2016-01-27 09:05:17+0000) >> passed 1/24 buffer-string=3D >> passed 2/24 buffer=3D >> ... >> passed 22/24 sisyphus-test-with-find-file >> passed 23/24 to-string >> passed 24/24 with-temp-buffers >> >> Ran 24 tests, 23 results as expected, 1 unexpected (2016-01-27 09:05:18+= 0000) >> >> 1 unexpected results: >> FAILED crash-out >> >> It would be nice to add some compilation-mode parsable data to this. So, >> something like >> >> passed 1/24 buffer-string=3D (in ./test.sisyphus-test.el:22:) > > I think that would look rather cluttered for the "passed" lines, but it > would indeed be helpful on the FAILED lines. This would in my opinion be very useful and a great timesaver. But yes, for FAILED results only, much like how the compiler only gives us line numbers if there is a problem. (AFAIR, that's how the test frameworks I've used do it.) So I updated the patch from the feature/parsable-ert-output against current master (patch attached), made sure that one of our tests failed, and then tested it with "make check". I got the following backtrace, but gave up after looking at it for a while: Debugger entered--Lisp error: (error "Don=E2=80=99t know where =E2=80=98fns-tests-string-bytes=E2=80=99 is defin...") signal(error ("Don=E2=80=99t know where =E2=80=98fns-tests-string-bytes= =E2=80=99 is defin...")) error("Don't know where `%s' is defined" fns-tests-string-bytes) find-function-search-for-symbol(fns-tests-string-bytes ert-deftest nil) find-definition-noselect(fns-tests-string-bytes ert-deftest) ert-test-location([...]) [...] --000000000000e2ddb405cefa06ff Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Add-source-information-to-ERT-batch-mode.patch" Content-Disposition: attachment; filename="0001-Add-source-information-to-ERT-batch-mode.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 78b2d87a32e4a3fc_0.1 RnJvbSBlNmMxODVmMjgwZTJjMzMwODI1YmVlYmFkN2QyMzkzYzIxMTk5NTY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsbGlwIExvcmQgPHBoaWxsaXAubG9yZEBydXNzZXQub3Jn LnVrPgpEYXRlOiBXZWQsIDI3IEphbiAyMDE2IDIwOjU5OjUwICswMDAwClN1YmplY3Q6IFtQQVRD SF0gQWRkIHNvdXJjZSBpbmZvcm1hdGlvbiB0byBFUlQgYmF0Y2ggbW9kZQoKKiBsaXNwL2VtYWNz LWxpc3AvZXJ0LmVsIChlcnQtdGVzdC1sb2NhdGlvbik6IE5ldyBmdW5jdGlvbi4KKGVydC1ydW4t dGVzdHMtYmF0Y2gpOiBBZGQgdGVzdCBsb2NhdGlvbiB0byBmYWlsZWQgdGVzdHMuICAoQnVnIzIy NDcxKQotLS0KIGxpc3AvZW1hY3MtbGlzcC9lcnQuZWwgfCAyNCArKysrKysrKysrKysrKysrKysr KysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9lcnQuZWwgYi9saXNwL2VtYWNzLWxpc3AvZXJ0 LmVsCmluZGV4IDU3NjU1NDAzYzIuLjM2ZjUwNjJlODMgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3Mt bGlzcC9lcnQuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2VydC5lbApAQCAtMTM1Myw2ICsxMzUz LDIzIEBAIGVydC0taW5zZXJ0LWluZm9zCiAoZGVmdmFyIGVydC1xdWlldCBuaWwKICAgIk5vbi1u aWwgbWFrZXMgRVJUIG9ubHkgcHJpbnQgaW1wb3J0YW50IGluZm9ybWF0aW9uIGluIGJhdGNoIG1v ZGUuIikKIAorKGRlZnVuIGVydC10ZXN0LWxvY2F0aW9uICh0ZXN0KQorICAiUmV0dXJuIGEgc3Ry aW5nIGRlc2NyaXB0aW9uIHRoZSBzb3VyY2UgbG9jYXRpb24gb2YgVEVTVC4iCisgIChsZXQqICgo bG9jCisgICAgICAgICAgKGZpbmQtZGVmaW5pdGlvbi1ub3NlbGVjdCAoZXJ0LXRlc3QtbmFtZSB0 ZXN0KSAnZXJ0LWRlZnRlc3QpKQorICAgICAgICAgKGJ1ZmZlcgorICAgICAgICAgIChjYXIgbG9j KSkKKyAgICAgICAgIChwb2ludCAoY2RyIGxvYykpCisgICAgICAgICAoZmlsZQorICAgICAgICAg IChmaWxlLXJlbGF0aXZlLW5hbWUKKyAgICAgICAgICAgKGJ1ZmZlci1maWxlLW5hbWUgYnVmZmVy KSkpCisgICAgICAgICAobGluZSAod2l0aC1jdXJyZW50LWJ1ZmZlciBidWZmZXIKKyAgICAgICAg ICAgICAgICAgKGxpbmUtbnVtYmVyLWF0LXBvcyBwb2ludCkpKSkKKyAgICAoZm9ybWF0ICJhdCAl cyBsaW5lICVzLiIgZmlsZSBsaW5lKSkpCisKKyhkZWZ2YXIgZXJ0LWJhdGNoLWJhY2t0cmFjZS1y aWdodC1tYXJnaW4gNzAKKyAgIlRoZSBtYXhpbXVtIGxpbmUgbGVuZ3RoIGZvciBwcmludGluZyBi YWNrdHJhY2VzIGluIGBlcnQtcnVuLXRlc3RzLWJhdGNoJy4iKQorCiA7OzsjIyNhdXRvbG9hZAog KGRlZnVuIGVydC1ydW4tdGVzdHMtYmF0Y2ggKCZvcHRpb25hbCBzZWxlY3RvcikKICAgIlJ1biB0 aGUgdGVzdHMgc3BlY2lmaWVkIGJ5IFNFTEVDVE9SLCBwcmludGluZyByZXN1bHRzIHRvIHRoZSB0 ZXJtaW5hbC4KQEAgLTE0NzEsMTQgKzE0ODgsMTcgQEAgZXJ0LXJ1bi10ZXN0cy1iYXRjaAogICAg ICAgICAgICAgKGxldCogKChtYXggKHByaW4xLXRvLXN0cmluZyAobGVuZ3RoIChlcnQtLXN0YXRz LXRlc3RzIHN0YXRzKSkpKQogICAgICAgICAgICAgICAgICAgIChmb3JtYXQtc3RyaW5nIChjb25j YXQgIiU5cyAgJSIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChw cmluMS10by1zdHJpbmcgKGxlbmd0aCBtYXgpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgInMvIiBtYXggIiAgJVMgKCVmIHNlYykiKSkpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAicy8iIG1heCAiICAlUyAoJWYgc2VjKSVzIikp KQogICAgICAgICAgICAgICAobWVzc2FnZSBmb3JtYXQtc3RyaW5nCiAgICAgICAgICAgICAgICAg ICAgICAgIChlcnQtc3RyaW5nLWZvci10ZXN0LXJlc3VsdCByZXN1bHQKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlcnQtdGVzdC1yZXN1bHQtZXhw ZWN0ZWQtcAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHRlc3QgcmVzdWx0KSkKICAgICAgICAgICAgICAgICAgICAgICAgKDErIChlcnQtLXN0YXRz LXRlc3QtcG9zIHN0YXRzIHRlc3QpKQogICAgICAgICAgICAgICAgICAgICAgICAoZXJ0LXRlc3Qt bmFtZSB0ZXN0KQotICAgICAgICAgICAgICAgICAgICAgICAoZXJ0LXRlc3QtcmVzdWx0LWR1cmF0 aW9uIHJlc3VsdCkpKSkpKSkpCisgICAgICAgICAgICAgICAgICAgICAgIChlcnQtdGVzdC1yZXN1 bHQtZHVyYXRpb24gcmVzdWx0KQorICAgICAgICAgICAgICAgICAgICAgICAoaWYgKGVydC10ZXN0 LXJlc3VsdC1leHBlY3RlZC1wIHRlc3QgcmVzdWx0KQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgIiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAoY29uY2F0ICIgIiAoZXJ0LXRlc3QtbG9j YXRpb24gdGVzdCkpKSkpKSkpKSkKICAgIG5pbCkpCiAKIDs7OyMjI2F1dG9sb2FkCi0tIAoyLjMw LjIKCg== --000000000000e2ddb405cefa06ff--