From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 43065@debbugs.gnu.org
Subject: bug#43065: Fix or remove broken flyspell-issue-welcome-flag option
Date: Thu, 27 Aug 2020 02:27:13 -0700 [thread overview]
Message-ID: <CADwFkmnBt0HemjzmPM6+Faa2nrwXiibT-0somPB3veRdZQHgBA@mail.gmail.com> (raw)
In-Reply-To: <83zh6g1mr4.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> Btw, can we make this only display the welcome message if
> flyspell-mode is invoked interactively? Your patch makes this
> unconditional, which I don't think was the original intent.
(I received your email less than a minute after pushing.)
Your observation is correct, I think.
Is this one of those places where we are forced to use
(called-interactively-p 'interactive)? Or can we add an optional
argument to `define-minor-mode' somehow?
next prev parent reply other threads:[~2020-08-27 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 5:24 bug#43065: Fix or remove broken flyspell-issue-welcome-flag option Stefan Kangas
2020-08-27 8:42 ` Eli Zaretskii
2020-08-27 9:06 ` Eli Zaretskii
2020-08-27 9:27 ` Stefan Kangas [this message]
2020-08-27 9:31 ` Eli Zaretskii
2020-08-27 9:47 ` Stefan Kangas
2020-08-27 9:27 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnBt0HemjzmPM6+Faa2nrwXiibT-0somPB3veRdZQHgBA@mail.gmail.com \
--to=stefan@marxist.se \
--cc=43065@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).