From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#20845: 25.0.50; bookmark.el, handling of fictitious `buffer' property Date: Fri, 5 Jul 2019 16:04:36 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157944"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 20845@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 05 16:10:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjOv3-000elD-5f for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 16:10:33 +0200 Original-Received: from localhost ([::1]:53502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjOq7-0006MN-DP for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 10:05:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45226) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjOpt-0006MA-QB for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 10:05:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjOpn-0001jh-6j for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 10:05:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44769) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjOpj-0001Uk-Pl for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 10:05:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hjOpi-0002PS-JY for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2019 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20845 X-GNU-PR-Package: emacs Original-Received: via spool by 20845-submit@debbugs.gnu.org id=B20845.15623354969246 (code B ref 20845); Fri, 05 Jul 2019 14:05:02 +0000 Original-Received: (at 20845) by debbugs.gnu.org; 5 Jul 2019 14:04:56 +0000 Original-Received: from localhost ([127.0.0.1]:53590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjOpc-0002P4-4r for submit@debbugs.gnu.org; Fri, 05 Jul 2019 10:04:56 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:33562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjOpa-0002Oo-Nc for 20845@debbugs.gnu.org; Fri, 05 Jul 2019 10:04:55 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id n9so10102348wru.0 for <20845@debbugs.gnu.org>; Fri, 05 Jul 2019 07:04:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=izLBqWQTxEEeRA6+nhLHmgD7PsuXOLCjX9e6bLdffxQ=; b=h0FvyDuGspmIGprUvJ0BEVlTPhYR+YjF8AQGKYsb6f15TY5VAj7lZE9a1mOGhbtzSf hqlj8dnN0CBANkB7X8uGnscRK3RLSHWYOVrA9dFZv8Pzf2wqANl4Aqz30FJ6uU48kNmu lgcP8i8Tp2lXL8hKap2Pu90YR5D8s3L64lzuQJ9evAR7AOdMjQLWY2IKgLd3HwFx2ECe 2Xz175eTcO8uy1qvTPjTH9/Vf97vx7pLUoaAKgfK5Ev3s3Krfj6H9xUFUjsXFBHzG5kP OmKQn2gnXwppYnNMzyLNt0msXmAbIxBCrprkri7w0EA4Rs61R/QJjU0pJQ7XEV6PDrmE on8w== X-Gm-Message-State: APjAAAW/6ywtv9JKrg93cmDcF7LXMi5hSkoJmpAJHBcZmhmGjdcvyGg3 axCM1ySi9f+WYC1uiSkP+n+bWnWGYALKpbGfRTY= X-Google-Smtp-Source: APXvYqybAU6rd2SXaDl2nGKfCg4fOQA0cIhdpBwp9etDmhrIt8EiErGsxIX62R4ZCQRn2lWvh5n2U9zw9AUSm+6WEYI= X-Received: by 2002:a05:6000:14b:: with SMTP id r11mr4361122wrx.196.1562335488049; Fri, 05 Jul 2019 07:04:48 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162129 Archived-At: Stefan Monnier writes: > > I'm looking into Emacs Bug#20845 which asks about the purpose of the > > "bookmark" property in bookmark.el. > > I don't see any `bookmark` property, sorry. That should be "buffer", sorry about that. > > The suggestion given by Drew above is to remove it. > > Do you have an opinion about that? > > Not really, no. But such "old-style" bookmarks might still be used by > third-party packages and might still appear in users's > ~/.emacs.d/bookmarks, so if we want to remove support for it, maybe we > should try and do it gradually. > > [...taking a second look...] > > Oh, I see how/where it's used and it's definitely still used: > Info-bookmark-jump uses it (i.e. not in the stored bookmark object, but > in a transient object passed to bookmark-default-handler). > So maybe it should be documented in the docstring of > `bookmark-default-handler` for the benefit of other handlers. I agree with this conclusion. So not only do we keep it, but we document it. Thanks for helping out Stefan, it seems we now have a way forward. Best regards, Stefan Kangas