From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Wed, 15 Feb 2023 06:19:02 -0800 Message-ID: References: <874jruy7xx.fsf@ledu-giraud.fr> <87ttztk0yw.fsf@tcd.ie> <87v8k9s6j9.fsf@ledu-giraud.fr> <83ilg8jzti.fsf@gnu.org> <87k00oo03r.fsf@ledu-giraud.fr> <838rh4jlsq.fsf@gnu.org> <87bklzol8n.fsf@ledu-giraud.fr> <877cwmo8ij.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24027"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, Eli Zaretskii , 61394@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 15 15:20:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSIe3-0005zM-0c for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Feb 2023 15:20:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSIdk-0004Wu-1B; Wed, 15 Feb 2023 09:20:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSIde-0004Tp-FE for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 09:20:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSIde-0008B6-5H for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 09:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSIde-0004aO-0Q for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 09:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Feb 2023 14:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.167647075217525 (code B ref 61394); Wed, 15 Feb 2023 14:20:01 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 15 Feb 2023 14:19:12 +0000 Original-Received: from localhost ([127.0.0.1]:58348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSIcp-0004Yb-Ti for submit@debbugs.gnu.org; Wed, 15 Feb 2023 09:19:12 -0500 Original-Received: from mail-oa1-f54.google.com ([209.85.160.54]:45700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSIcn-0004YL-GZ for 61394@debbugs.gnu.org; Wed, 15 Feb 2023 09:19:10 -0500 Original-Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-16cc1e43244so18791855fac.12 for <61394@debbugs.gnu.org>; Wed, 15 Feb 2023 06:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=PWwIQOjNP3CL3cpQycqVVIAIi9yH0kXr5SbwleScJWQ=; b=Lw7LunRUNPNoBxBhb5wPa+ije54E7EVhnbOHh8u2K1gz/hRm6bTHa/1N71MxGhp6S6 5wy45JZKONtEttfvAHtLATuWweipQGHd0y0ohPZboInGDWKqgLSJBtwZS3PyZFpRDBwZ SE2kDk2xmazF5XzJFFxjELgSg92yUig3qOSN+zkMbTv8eX0lTocOWO80+qx3aj8fPh9+ 5myPyPsTepalLBPbJfguHIwKMRY5ruAZMcm9Rs1zEr0GgIW0uIhHFz/FdOSrmcf6Ewgy obeKWJRl4907YGpJrbjuBVezZ0I0foQjmMJijqrUHTitdwis3ZodtUL2hqjqzYmUfo3n jh4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PWwIQOjNP3CL3cpQycqVVIAIi9yH0kXr5SbwleScJWQ=; b=CLHkc+kknJfrVXLerb7CbWZn66FXjgkoCDz+Xlj7XbtHiVgkvALTLExHuw7+/ye8Db N8voVEBvu6tgpbEW2/nAEvbYd6z8AMTbajDxy1k+alqjEUkmuqJjDdQT9Q2Pzkf6r3N9 42da39eKDLS/mlQ41hZz0VfbaSH736TPVLMlROEND/VRmKuZzu3ztOHon0fP9pZDLGI2 7n+Fehwmy2kwIkjw7TQmXsvYfTycZFYesrtFzPe1XeFn6nY/Tk8P/UWEWpRzEtttDDV0 SG6jwKgPJzMy+8cbd8cCwSq0Qrywyix6/ZBvnkbmmnBqURABVsqfGCB5bu/qs76WdeDr I7gg== X-Gm-Message-State: AO0yUKXhNfmmNEcSzLew03JdL22K3K3XR0gBb3W1zRF5IWWRjCuhm2gd cj/n3EH1EPwEzDS8dYAlBZGpHTBDggJYNTTjB+U= X-Google-Smtp-Source: AK7set9X0pHuM/Hk8JpnwFBC8xryW5/hrN7yX3iGeAG+Ezl1X2O79TD1hxXzomgklakKFdRgF1Y4D1Uu+gxoDEQTHG4= X-Received: by 2002:a05:6870:6112:b0:16e:6ff:760d with SMTP id s18-20020a056870611200b0016e06ff760dmr255688oae.291.1676470743765; Wed, 15 Feb 2023 06:19:03 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 15 Feb 2023 06:19:02 -0800 In-Reply-To: <877cwmo8ij.fsf@ledu-giraud.fr> X-Hashcash: 1:20:230215:61394@debbugs.gnu.org::T9cBZDR885F9G0kP:3uey X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255715 Archived-At: Manuel Giraud writes: > The performance impact is important. Here are the results from a list > of images of mine: > --8<---------------cut here---------------start------------->8--- > (length *images*) -> 3664 > > (benchmark-run-compiled 10 (dolist (im *images*) (sha1 im))) > -> (0.367976492 1 0.2809483390000196) > > (benchmark-run-compiled 10 (dolist (im *images*) (image-dired-contents-sha1 im))) > -> (72.115512605 84 26.079076938000014) > --8<---------------cut here---------------end--------------->8--- Thanks. That's a slowdown by a factor close to 100, so while I think the feature sounds useful, it should indeed be made optional. > Maybe we could have this in another option for > `image-dired-thumbnail-storage'? I think 'image-dired-thumbnail-storage' is already complicated enough, and I'd rather not complicate it further. > What do you think of 'image-dired-contents? Hmm, it sounds a bit too nondescript. How about something like 'image-dired-thumbnail-naming'?