From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#43215: [PATCH] Mark sgml-basic-offset as safe for integers Date: Sat, 5 Sep 2020 10:42:49 +0000 Message-ID: References: <20200905094445.504012-1-mail@lucaswerkmeister.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22424"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43215@debbugs.gnu.org To: Lucas Werkmeister Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 12:43:39 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEVfW-0005l2-W8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 12:43:38 +0200 Original-Received: from localhost ([::1]:56188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEVfW-0002ZQ-1x for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 06:43:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEVew-00027c-15 for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 06:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEVev-0004dM-OJ for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 06:43:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEVev-0002dO-Ld for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 06:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 10:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43215-submit@debbugs.gnu.org id=B43215.159930257910117 (code B ref 43215); Sat, 05 Sep 2020 10:43:01 +0000 Original-Received: (at 43215) by debbugs.gnu.org; 5 Sep 2020 10:42:59 +0000 Original-Received: from localhost ([127.0.0.1]:41584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEVet-0002d7-9d for submit@debbugs.gnu.org; Sat, 05 Sep 2020 06:42:59 -0400 Original-Received: from mail-ej1-f68.google.com ([209.85.218.68]:45264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEVeq-0002cu-TR for 43215@debbugs.gnu.org; Sat, 05 Sep 2020 06:42:58 -0400 Original-Received: by mail-ej1-f68.google.com with SMTP id i26so11759572ejb.12 for <43215@debbugs.gnu.org>; Sat, 05 Sep 2020 03:42:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=5zLTEoN7J/Ov93lIoHE4sXc2W3+ZofIUE4xMrUMK+EQ=; b=k5PlAV9FCbaRE9TnbQGbvi4+aUJI+PalMP9MHTuTjL30QexqW43jVnpS4y8UydI6nZ 9ktjdYfeBPaa5a3bL0bi+7YZkwhkuQJfE9F92HqTR+yXza9Vvtxogb/IaML4lZTBob2i 3lBKvksegqa+wBX/mzpbhB1cWtml7qOO97MHelaUsWrvBvRv8+nh81FPD8WZPzUaUzQG n6RoTigP+NXNtk28PRemimH2tavmBOHY/ppLK27HTu+szRfSElcwlcUZR1XYpvnTNpAM B9qvBwkGX2i8IjdVMlCaKGv4QHwV3LYlMhgUz+5XCrnLGB+dFuE/JOc7mDYSCC9sxzRb oaDw== X-Gm-Message-State: AOAM532ysn2EJ6+gd/lwNss4x51PvR++S2bSv0uZB0/h6Bf6AmKY4jGG SKS04YChGPP6EwboUG9xK+ozYhu0/2wn7D9/+cg= X-Google-Smtp-Source: ABdhPJyJqvp5g52fD25unPyICpskZJLfOC6bCepTI85RRbRdXNoYc4gwjEj8p83iysDjMsjT/P6yvdi9t5OIe3FfHKA= X-Received: by 2002:a17:906:7248:: with SMTP id n8mr1072900ejk.160.1599302571023; Sat, 05 Sep 2020 03:42:51 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 5 Sep 2020 10:42:49 +0000 In-Reply-To: <20200905094445.504012-1-mail@lucaswerkmeister.de> (Lucas Werkmeister's message of "Sat, 5 Sep 2020 11:44:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187200 Archived-At: Lucas Werkmeister writes: > * lisp/textmodes/sgml-mode.el (sgml-basic-offset): Add :safe. > --- > lisp/textmodes/sgml-mode.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el > index 1672dce4f2..04f1dddf5f 100644 > --- a/lisp/textmodes/sgml-mode.el > +++ b/lisp/textmodes/sgml-mode.el > @@ -46,7 +46,8 @@ sgml > > (defcustom sgml-basic-offset 2 > "Specifies the basic indentation level for `sgml-indent-line'." > - :type 'integer) > + :type 'integer > + :safe #'integerp) Thanks for the patch. Could you explain a bit about the rationale for this change, why it is needed and how to test it?