* bug#60761: [PATCH] Remove deprecated RLS server from list of eglot servers
@ 2023-01-12 21:43 Dimitri Belopopsky
2023-01-13 1:15 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: Dimitri Belopopsky @ 2023-01-12 21:43 UTC (permalink / raw)
To: 60761
[-- Attachment #1.1: Type: text/plain, Size: 191 bytes --]
Hello,
I'm suggesting removing RLS from the server list in eglot, as it is
currently not maintained anymore by the Rust developers.
The github was archived: https://github.com/rust-lang/rls
[-- Attachment #1.2: Type: text/html, Size: 316 bytes --]
[-- Attachment #2: 0001-Remove-deprecated-RLS-server-from-list-of-eglot-serv.patch --]
[-- Type: application/x-patch, Size: 1199 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#60761: [PATCH] Remove deprecated RLS server from list of eglot servers
2023-01-12 21:43 bug#60761: [PATCH] Remove deprecated RLS server from list of eglot servers Dimitri Belopopsky
@ 2023-01-13 1:15 ` Stefan Kangas
2023-01-13 7:18 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2023-01-13 1:15 UTC (permalink / raw)
To: Dimitri Belopopsky, 60761; +Cc: João Távora
close 60761 30.1
thanks
Dimitri Belopopsky <dimitri@belopopsky.com> writes:
> I'm suggesting removing RLS from the server list in eglot, as it is
> currently not maintained anymore by the Rust developers.
> The github was archived: https://github.com/rust-lang/rls
Thanks, pushed to master (commit f1310859a0d).
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#60761: [PATCH] Remove deprecated RLS server from list of eglot servers
2023-01-13 1:15 ` Stefan Kangas
@ 2023-01-13 7:18 ` Eli Zaretskii
2023-01-13 7:36 ` Dimitri Belopopsky
2023-01-13 17:51 ` João Távora
0 siblings, 2 replies; 5+ messages in thread
From: Eli Zaretskii @ 2023-01-13 7:18 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 60761, dimitri, joaotavora
> Cc: João Távora <joaotavora@gmail.com>
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Thu, 12 Jan 2023 17:15:42 -0800
>
> Dimitri Belopopsky <dimitri@belopopsky.com> writes:
>
> > I'm suggesting removing RLS from the server list in eglot, as it is
> > currently not maintained anymore by the Rust developers.
> > The github was archived: https://github.com/rust-lang/rls
>
> Thanks, pushed to master (commit f1310859a0d).
Does "not maintained anymore by the Rust developers" necessarily mean
it is wrong to use it? Having the server mentioned in the DB doesn't
mean we force the users to use it, just that we support it if the user
has it installed.
João, WDYT? I guess we should to have some criteria for when to
remove servers from the DB?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#60761: [PATCH] Remove deprecated RLS server from list of eglot servers
2023-01-13 7:18 ` Eli Zaretskii
@ 2023-01-13 7:36 ` Dimitri Belopopsky
2023-01-13 17:51 ` João Távora
1 sibling, 0 replies; 5+ messages in thread
From: Dimitri Belopopsky @ 2023-01-13 7:36 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 60761, Stefan Kangas, joaotavora
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
On Fri, 13 Jan 2023, 08:19 Eli Zaretskii, <eliz@gnu.org> wrote:
> > Cc: João Távora <joaotavora@gmail.com>
> > From: Stefan Kangas <stefankangas@gmail.com>
> > Date: Thu, 12 Jan 2023 17:15:42 -0800
> >
> > Dimitri Belopopsky <dimitri@belopopsky.com> writes:
> >
> > > I'm suggesting removing RLS from the server list in eglot, as it is
> > > currently not maintained anymore by the Rust developers.
> > > The github was archived: https://github.com/rust-lang/rls
> >
> > Thanks, pushed to master (commit f1310859a0d).
>
> Does "not maintained anymore by the Rust developers" necessarily mean
> it is wrong to use it? Having the server mentioned in the DB doesn't
> mean we force the users to use it, just that we support it if the user
> has it installed.
>
In the general case I think I agree.
Here, it is explicitely stated that users should move to rust-analyzer.
There is nothing wrong in using it anyway,
but I don't think it should be encouraged to use in this case.
> João, WDYT? I guess we should to have some criteria for when to
> remove servers from the DB?
>
[-- Attachment #2: Type: text/html, Size: 2118 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#60761: [PATCH] Remove deprecated RLS server from list of eglot servers
2023-01-13 7:18 ` Eli Zaretskii
2023-01-13 7:36 ` Dimitri Belopopsky
@ 2023-01-13 17:51 ` João Távora
1 sibling, 0 replies; 5+ messages in thread
From: João Távora @ 2023-01-13 17:51 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 60761, Stefan Kangas, dimitri
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
On Fri, Jan 13, 2023, 07:18 Eli Zaretskii <eliz@gnu.org> wrote:.
>
> João, WDYT? I guess we should to have some criteria for when to
> remove servers from the DB?
>
We could, yes. But I can't come up with one.
Here, i think it makes sense to remove it if it's deprecated. Because it's
more likely to be a disappointment than not. And users that really want to
use it can still do so.
João
>
[-- Attachment #2: Type: text/html, Size: 999 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-13 17:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-12 21:43 bug#60761: [PATCH] Remove deprecated RLS server from list of eglot servers Dimitri Belopopsky
2023-01-13 1:15 ` Stefan Kangas
2023-01-13 7:18 ` Eli Zaretskii
2023-01-13 7:36 ` Dimitri Belopopsky
2023-01-13 17:51 ` João Távora
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).