From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#57281: [PATCH] Speed up image-dired-display-image Date: Thu, 18 Aug 2022 22:53:38 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15668"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57281@debbugs.gnu.org To: Morgan.J.Smith@outlook.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 19 07:54:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOuxi-0003y5-Ci for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Aug 2022 07:54:30 +0200 Original-Received: from localhost ([::1]:44226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOuxg-0005dh-FZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Aug 2022 01:54:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOuxH-0005bR-1C for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2022 01:54:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39258) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOuxG-0005xV-D1 for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2022 01:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOuxF-0007FK-Ug for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2022 01:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Aug 2022 05:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57281 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57281-submit@debbugs.gnu.org id=B57281.166088842727822 (code B ref 57281); Fri, 19 Aug 2022 05:54:01 +0000 Original-Received: (at 57281) by debbugs.gnu.org; 19 Aug 2022 05:53:47 +0000 Original-Received: from localhost ([127.0.0.1]:57238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOux0-0007Eg-R4 for submit@debbugs.gnu.org; Fri, 19 Aug 2022 01:53:47 -0400 Original-Received: from mail-vk1-f169.google.com ([209.85.221.169]:43585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOuwy-0007EP-Ao for 57281@debbugs.gnu.org; Fri, 19 Aug 2022 01:53:45 -0400 Original-Received: by mail-vk1-f169.google.com with SMTP id w129so1784877vkg.10 for <57281@debbugs.gnu.org>; Thu, 18 Aug 2022 22:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:user-agent:references :in-reply-to:from:from:to:cc; bh=J2OJJsfaHrslngbQV5RwKlXxVSBRILrttRdtB0EJXro=; b=bLkC/95w4LI/CcTlgbxdxJFSdF7/DITHXc8bkKRYgXqbfaTb9N9vWaLAPNXSzhoLw/ 6VZnQUSvTGB9HtEc2/GutkRvkkgh841xEci6rcnxyorUZyFwHDlRKX92nBJDPTK3v6XP 5eNzGyl7YGXqtgyppmUlGa2UidxYpwEU7IkdwGnz6lGvXuSGuI2tsezekDNNzcAWAvC3 ZPNqwDRsZXusvi/VXNSmOwRGLLMo62C59B+RIkKqmkr+JMSXNXU0VWDmuYFPLD/RohYY oWL/lAf2x6GHa/1jxgC0cFXdIphQA8SzJbB1Af0CkX/brmCsFoTNiB0XUMXkyIa2qn2+ 9Ebg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:user-agent:references :in-reply-to:from:x-gm-message-state:from:to:cc; bh=J2OJJsfaHrslngbQV5RwKlXxVSBRILrttRdtB0EJXro=; b=JubldYUhvT0IrfqJXxHVoL156Fe4nRKxfynLmhf58wShDHGEVHDKy4mY53TlkH6yjx lVFLFZ/pCFUqEFoqjdXEPdX6RB09SLEvpG3XKdekVtrQJDICYNbBr2jt9RfY1Br/j60Q brltmuMvOpTOxxCKsGcv9hleQdM9AIQjkpYlrXX3atim8TWtw5MFjnOxdRjpb1NvASW0 qcKG/OJ/uUe3yEeP45N5bLRAiE7p6QUiwI4l3XcTU2YClXQFn8iSrBxNs9QTORkx1Ic7 d4/LaljkWmTwTqpSZaNe9ibs4ypiQp6zXgcjbLfTg4TXrnkiB8rcGxqIWcmC73Gtp6N1 8Onw== X-Gm-Message-State: ACgBeo1GQsKDp8SYi1eciaD3rNF3X4MMpZTtaVgpNTTixz4ONaaZ8aG5 CSi9cncL6kn6Fx2oPwphz9QJPund/W0WUNBdJlg= X-Google-Smtp-Source: AA6agR6zCyJdocFpH0jwVECJvuV4lawAsfCFGGQeDXbLA9wWfSYv0BIavAs2xhU7HqDcx7QVIPLDru8zXCf60DHpkzQ= X-Received: by 2002:a1f:e3c5:0:b0:380:68eb:e647 with SMTP id a188-20020a1fe3c5000000b0038068ebe647mr2619830vkh.11.1660888418572; Thu, 18 Aug 2022 22:53:38 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 18 Aug 2022 22:53:38 -0700 In-Reply-To: (Morgan J. Smith's message of "Thu, 18 Aug 2022 14:43:07 -0400") X-Hashcash: 1:20:220819:morgan.j.smith@outlook.com::oiGhYAQLL+2gmWaf:7fTq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240189 Archived-At: close 57281 29.1 thanks Morgan.J.Smith@outlook.com writes: > find-file-other-window runs image-mode and so does > image-dired-display-image-mode. By opening the file literally I was able to > speed this up from taking 0.8ish seconds to only taking 0.4ish seconds > according to elp > > 0.4 seconds is still a long time though. At a later time I might try to see if > there are more optimizations to make I can verify this speedup. Thanks for the patch, pushed to master (note that I changed `switch-to-buffer-other-window' to `pop-to-buffer'). For your next patch, please consider producing it using "git format-patch -1 HEAD" and send it as an attachment. It makes it easier for us to install it. Thanks in advance.