From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#60001: [PATCH] Improve completion of treesit-check-indent command Date: Mon, 4 Sep 2023 13:02:23 -0700 Message-ID: References: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> <83358lqm2q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15070"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60001@debbugs.gnu.org, Yuan Fu , mardani29@yahoo.es To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 04 22:03:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdFnK-0003g8-UV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Sep 2023 22:03:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdFmp-00088Q-4L; Mon, 04 Sep 2023 16:03:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdFmo-00087x-28 for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 16:03:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdFmn-0003jV-Qi for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 16:03:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdFmn-0001We-Qm for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 16:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 20:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60001 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60001-submit@debbugs.gnu.org id=B60001.16938577555823 (code B ref 60001); Mon, 04 Sep 2023 20:03:01 +0000 Original-Received: (at 60001) by debbugs.gnu.org; 4 Sep 2023 20:02:35 +0000 Original-Received: from localhost ([127.0.0.1]:52687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdFmM-0001Vp-Hx for submit@debbugs.gnu.org; Mon, 04 Sep 2023 16:02:34 -0400 Original-Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:54603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdFmI-0001VY-3p for 60001@debbugs.gnu.org; Mon, 04 Sep 2023 16:02:33 -0400 Original-Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50078e52537so2978024e87.1 for <60001@debbugs.gnu.org>; Mon, 04 Sep 2023 13:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693857744; x=1694462544; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=4DfcfVGwZYLhwrkaxeMuZON4BpzDcbTC/sXJd4hbYeE=; b=FzricrB7FfZosHm3zBylEABJ0b5sclJHZ4i4rllXTydnCQ9EsgPqXsAE/KVisjXP23 ao2pLaRw7ofwi5Kdm9BAgMxNYoDtLJ4VQKhn+NbqDOfCxlGWLrLSWOAbGYkydUR7jcld 0RfbNsQBCLF4jvgsza+82OvRM5XqV+JoiIc67NG9GlaB7+kfzdOtUzpuLDg1yo7hDGln sWBc3GyCaJoZKJvp4/XjGrV9iB3cujYxID7W6Q2pNK87+4nJzuVdTiww5K462nUxU+Jt aLXgqSTmUCgoMVSYo/UCvrKvDHuILskCVrmuYshI5XJxhoyzG6CLv4zjcvz3zV5zPk8+ UiZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693857744; x=1694462544; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4DfcfVGwZYLhwrkaxeMuZON4BpzDcbTC/sXJd4hbYeE=; b=XJp6v9QAE5IB6+0pMmTtR5ZtTI1micmnL3ngbC8At27LgtKUEXmabHx90pZCQPI/HI JE4cthe/UZH/JAcR0YUQ6VG3NspGRB1z0l23/HmxIrJd8bIl5P2hsO0NnQQ/hfmJsaa8 kf77NAZufHuKE2/fZ+x3B1RHQiKj34gr89q4A9eHop4CPRSn1nHjxOW76ufyKQbExvt6 CscppBNY9AWtI8fB5/poYsRAcK12x0oZkiQhPRjsJzNsk7i41uJuA/AMTZTXDtblXASV pUN8+9qNw0c1rzFAkqdHjPxPVga+9G2JDwioBGdvcrf7U/67pTZd5IuItxTeDGH2dhmB n1YA== X-Gm-Message-State: AOJu0YwUiSzpb2uxR6bd3IYOzNHGaUYQQFFz2kBY5TMoFJL+xeBh/ZS/ Le8jVhakFDgX/uAqHg9tKyMzq6CaJBkm82NGyqo= X-Google-Smtp-Source: AGHT+IHrwPS7grtx7fn3InYg7WUVkeW+vefNv0T2TsYla+HXl12/Ua8YAoah8kXTgiCzFSq87dJxHTC8aKIsZifGMWw= X-Received: by 2002:a05:6512:3085:b0:4f8:ff52:93b7 with SMTP id z5-20020a056512308500b004f8ff5293b7mr9892330lfd.30.1693857743819; Mon, 04 Sep 2023 13:02:23 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 4 Sep 2023 13:02:23 -0700 In-Reply-To: <83358lqm2q.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 Jan 2023 13:53:33 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269291 Archived-At: Eli Zaretskii writes: >> From: Yuan Fu >> Date: Sat, 7 Jan 2023 15:13:54 -0800 >> Cc: Daniel Mart=C3=ADn , >> 60001@debbugs.gnu.org >> >> >> Eli Zaretskii writes: >> >> >> Date: Mon, 12 Dec 2022 11:53:00 +0100 >> >> From: Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, >> >> the Swiss army knife of text editors" >> >> >> >> The treesit-check-indent command is not really related to Tree-sitter >> >> and could be in a more general place than treesit.el. WDYT? >> > >> > I agree, but then we'd need a definition for it that doesn't need >> > tree-sitter support. Is that easy to provide? >> > >> >> In any case, I have a patch to improve this command a bit by offering >> >> more accurate completion for major modes, not Emacs commands. I have >> >> also tried to improve its documentation a bit. >> > >> > How about a read-major-mode function in subr.el? >> > >> > But I think all these generalizations and improvements should go to >> > master. On the release branch, I'd prefer to leave >> > treesit-check-indent alone. >> >> Has this patch been pushed to master? > > No, I don't think so. > >> Should I close this report? > > If you agree with the change, please install it. It seems like this patch was never installed. Should it be?