unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Keith David Bershatsky <esq@lawlist.com>, 19684-done@debbugs.gnu.org
Subject: bug#19684: 25.0.50; `this-command` is set to `nil` before `window-scroll-functions` hook runs.
Date: Tue, 1 Oct 2019 22:16:57 +0200	[thread overview]
Message-ID: <CADwFkmn3z3zDv=_hMYqhxng66+y6LS607fNbFL7cajLG3FjgFw@mail.gmail.com> (raw)
In-Reply-To: <m2ppa3xr6z.wl%esq@lawlist.com>

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> tags 19684 notabug
> thanks
>
>> 1.  Expressly call `redisplay` at the tail end of the series of
>>     functions attached to the `post-command-hook`.
>>     Calling `redisplay` somehow prevents `this-command` from being
>>     reset to `nil` and the `window-scroll-functions` hook can then
>>     take advantage of the existing value of `this-command`.
>
> It's not that calling `redisplay' prevents it.  It's that the normal
> redisplay is run later (potentially much later if there are other things
> pending), at a point which is not directly connected with the command,
> hence this-command is not set any more because we're really not in the
> process of running that command any more.

This was already tagged notabug; I'm now also closing it.

Best regards,
Stefan Kangas





      parent reply	other threads:[~2019-10-01 20:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25  7:19 bug#19684: 25.0.50; `this-command` is set to `nil` before `window-scroll-functions` hook runs Keith David Bershatsky
2015-01-25 10:38 ` martin rudalics
2015-01-25 15:33 ` Eli Zaretskii
2015-01-25 16:14 ` Stefan Monnier
2015-01-25 17:42 ` Keith David Bershatsky
2019-10-01 20:16 ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmn3z3zDv=_hMYqhxng66+y6LS607fNbFL7cajLG3FjgFw@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=19684-done@debbugs.gnu.org \
    --cc=esq@lawlist.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).