From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#14130: 24.3.50; doc/help for advice and advised functions Date: Sat, 25 Sep 2021 10:15:06 -0700 Message-ID: References: <5BF8E36FD3EF4D1BBE8A1E79A0DCC421@us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15101"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 14130-done@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 19:16:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUBI8-0003ka-M6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 19:16:48 +0200 Original-Received: from localhost ([::1]:54218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUBI7-0001fF-1z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 13:16:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUBHP-0000lT-Ig for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 13:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUBHP-0000Vu-BN for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 13:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUBHP-0004hQ-7J for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 13:16:03 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 17:16:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14130 X-GNU-PR-Package: emacs Mail-Followup-To: 14130@debbugs.gnu.org, stefan@marxist.se, drew.adams@oracle.com Original-Received: via spool by 14130-done@debbugs.gnu.org id=D14130.163259011417920 (code D ref 14130); Sat, 25 Sep 2021 17:16:03 +0000 Original-Received: (at 14130-done) by debbugs.gnu.org; 25 Sep 2021 17:15:14 +0000 Original-Received: from localhost ([127.0.0.1]:34553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUBGc-0004ey-GT for submit@debbugs.gnu.org; Sat, 25 Sep 2021 13:15:14 -0400 Original-Received: from mail-pj1-f50.google.com ([209.85.216.50]:42864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUBGb-0004eh-9B for 14130-done@debbugs.gnu.org; Sat, 25 Sep 2021 13:15:13 -0400 Original-Received: by mail-pj1-f50.google.com with SMTP id rm6-20020a17090b3ec600b0019ece2bdd20so279840pjb.1 for <14130-done@debbugs.gnu.org>; Sat, 25 Sep 2021 10:15:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=AFIjG1N6pmlOEfys5lnE0HCWFQDPzO+2RrY7LEHOiXE=; b=g2KlebORjLWJMAoXjVAx6hmOVtYaSVKzncmkqz7Yo2KfkdIoitVzWTcTSC159jmDSD oFYEbIDWQpsxcfES/R/2CCBoezmeHGXbwc9mnpkjyYK196XhYWucIzjhGseWQPwkZLPU mLPc6LSbCp9tQIqsSUFgcotaglvReRdo5Ix/o6sdijchhwr0FkQguWWQskc6euDZAk/8 BfHmXSAHo44bkijOKAQiz2V/Baa8oeKNBGvfRibaydc0yWjMKYX9KFd5ptZdzHXOtBSU sdlsn5V6WTo0tRvSYBnojCo7bUO8kvHUPkD8QydML1DRn3jIbEhv0NA9yNHSCEKW3H1y 1YlA== X-Gm-Message-State: AOAM533VhWUiYllnq8vGQ3oeKZK0d01XbRFZP+DRGp01u7GZ+uE4lEBu rS9Off/DrLjBX7b23YEl04/900rCxfiNyhfTkKE= X-Google-Smtp-Source: ABdhPJzdsD6jfqRAOHcgiQXf2erhSZ0aArSLX3DRcvI06JKd7c7xARpVBcp8Dm7S34uifwwPEM4JpMpayPSnRDXZl3U= X-Received: by 2002:a17:90b:3805:: with SMTP id mq5mr9278211pjb.143.1632590107298; Sat, 25 Sep 2021 10:15:07 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 25 Sep 2021 10:15:06 -0700 In-Reply-To: <5BF8E36FD3EF4D1BBE8A1E79A0DCC421@us.oracle.com> (Drew Adams's message of "Wed, 3 Apr 2013 08:13:57 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215480 Archived-At: "Drew Adams" writes: > Mostly an enhancement request, I guess, but partly a bug report. > > 1. (elisp) `Advising Functions' > > Says "Note that enabling a piece of advice and activating advice for a > function are not the same thing." But it does not say clearly what the > difference is. It says only this: > > a. A piece of advice can be "enabled"/"disabled". It does not explain > what this means. > > b. Advice takes effect only if both enabled and activated. > > That's pretty incomplete. The difference between these two things > (enabling, activating) is presumably important, and it is not made > clear. It is not enough to tell users not to confuse the two, without > telling them clearly what the difference is. Start with this question: > What is the purpose of each of them (enabling, activating)? > > 2. The definition of "forward advice", and the *important* fact that you > can advise a function without the function being defined yet, should be > moved from (elisp) `Defining Advice' to (elisp) `Advising Functions'. > It is not a detail concerning just the keyword `activate'. (Note too > that there is zero use of or reference to "forward advice" in the > manual.) > > 3. If these concepts apply also to the new advice facility written by > Stefan, then please keep this request in mind in that context: document > each of the various states of a piece of advice (enabled but not > activated etc.) etc. (And where is the doc for that new facility?) Since the above was reported, this entire section seems to have been rewritten. I can't find any of the problematic text reported above in the new manual. I'm therefore closing this bug report. If this conclusion is incorrect and this is still an issue, please reply to this email (use "Reply to all" in your email client) and we can reopen the bug report.