From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#62751: 29.0.90; New libraries that still need to be assigned to packages Date: Mon, 18 Sep 2023 00:34:42 -0700 Message-ID: References: <87zg7fyjka.fsf@bernoul.li> <87wmwobgk6.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Monnier To: Jonas Bernoulli , 62751@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 09:36:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qi8nv-0001Qx-Lj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 09:36:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qi8nZ-00034M-P9; Mon, 18 Sep 2023 03:36:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qi8nT-00033f-A8 for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 03:35:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qi8nT-0003In-2E for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 03:35:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qi8na-0005h7-5u for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 03:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 07:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62751 X-GNU-PR-Package: emacs Original-Received: via spool by 62751-submit@debbugs.gnu.org id=B62751.169502250221788 (code B ref 62751); Mon, 18 Sep 2023 07:36:02 +0000 Original-Received: (at 62751) by debbugs.gnu.org; 18 Sep 2023 07:35:02 +0000 Original-Received: from localhost ([127.0.0.1]:51948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qi8mb-0005fD-E6 for submit@debbugs.gnu.org; Mon, 18 Sep 2023 03:35:01 -0400 Original-Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:45534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qi8mX-0005eo-HH for 62751@debbugs.gnu.org; Mon, 18 Sep 2023 03:35:00 -0400 Original-Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2ba1e9b1fa9so67471041fa.3 for <62751@debbugs.gnu.org>; Mon, 18 Sep 2023 00:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695022483; x=1695627283; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=rQDxgEHBI9hFP45uHG+Yb2CZZZLvdYpGG1MNIMWHa2U=; b=G1HEOG7uUoJ8SSolsBuyGzh/uSUQkd0qtwn3l6Hu6ZHr1r0fVuZTguy91uuvFk87sN eaKS2segspDrR4FelHPevwrzTrrk0Y1aiF2e3Q6ZiRF6lvRUFHOHu/CgUMvmTrsCoVfT wRVsyVwg2mQK2S4AdGNgq8sv+2F7Rak0NEnIy/w2tZ9QWyGwoyWQ6Vhli5wLxZPgbyGF XqerDedv+lLmN9//gaKqCY10jlS2xJXGvSVPgRN2kxXO3uT3q29uV3qRorxa4lMhbce3 FyB8zlEJmbgLFXTSvMKOjyCPtl7pLgXajF96KtP6QjwWbQG4taWgxZRrAAzbaMrkliz9 1XtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695022483; x=1695627283; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rQDxgEHBI9hFP45uHG+Yb2CZZZLvdYpGG1MNIMWHa2U=; b=HflHaF9Dp0kMiMR1h6NiKXAMVG+mni/70asb5vieNdPpq7LxeeNW4jxeI8BPUTlo+f WJuhXdn9jnXcdCOMICwZbbVJZSbe5fQsJHZcB8Eky+sUqpmuqbZPYuUdFWZLYGqJCsM0 bA4WsGFQNSq9m7SXEESuR2ZTuoZ5oyi+TEfSxGrf/w+2azXKDmqCJOGsrI0pTPhERfrJ lw5Y9qslZNIAF87bNTfUERHBSmH29W+mu3DHs0owsMlpR+mnTVkx2pVSd1ZfNGc174A5 N+K/eParaEx5Rnd02SFt2MjPWAqyiYh/wWtbjLasAqDMWsvrOGn0bskF5I0oCCkYpioU 2SyQ== X-Gm-Message-State: AOJu0Yz+ZtPYNSDDKIIOPxcdi8GrQL0U4zxieH4LM2thnJC791LZ4G3I 2oylrLAdtooa5YW/wdB+gswcTC2TQCMSTWMCYt8= X-Google-Smtp-Source: AGHT+IFR2qpZOkB1ZZLqxkKT6KUjaJLo2N6CrN7hd7kyWsOiVcN3o6coEFj2omwBry9SSJxoy7h4hCp06ms2r3SuLWY= X-Received: by 2002:a2e:8ec1:0:b0:2bf:cbff:7017 with SMTP id e1-20020a2e8ec1000000b002bfcbff7017mr7249315ljl.11.1695022483138; Mon, 18 Sep 2023 00:34:43 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 18 Sep 2023 00:34:42 -0700 In-Reply-To: <87wmwobgk6.fsf@bernoul.li> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270750 Archived-At: Jonas Bernoulli writes: >>> 9. It seems a bit excessive to consider each use-package*.el a separate >>> package. Maybe they should all be part of a single use-package >>> package. An entry in finder--builtins-alist should be used to >>> accomplish that. >> >> Done. > > Maybe lisp/use-package/bind-key.el should be a separate package (and > maybe it should be moved out of that directory). Right, so we either need to remove the "use-package" from package--builtins, or move it out of the lisp/use-package directory. Otherwise, it will show up in `M-x package-list-packages' as "available" rather than "built-in" (as it's now considered part of 'use-package'). Given that it is its own package on GNU ELPA, I can see some logic in moving it out of the use-package directory. It's never ideal to move files with git, but OTOH it's not been with us for that long yet. Eli, Stefan, any opinions/preferences? >>> Maybe we should stop falling though to assign a new library to its own >>> separate package, if nothing else is specified explicitly? It is of >>> course nice not having to either add a "Package" library header or a >>> finder--builtins-alist entry, but it also makes it easy to forget to >>> explicitly specify the package when doing that would be necessary. >> >> Hmm, yes that might make more sense. One would have to add package >> statements to a ton of libraries, though. So there'll be a lot of >> churn. >> >> Maybe it's worth it in the end, I don't know. > > Probably not, but "carefully check any additions to package--builtins" > should be added to the release steps. Yes, that's the other option. That's also less than ideal, as it involves tedious manual work. Do we have some way to list new additions to package--builtins? > For 29.1 I opened this issue, for 28.1 bug#55388. I have done that > early enough so that it could have been taken into account before these > releases shipped with questionable entries in package--builtins. > > I intend to do that well before the next release again. Thanks again for paying attention to this aspect. > By the way, IMO it would make sense to apply these on "emacs-29", not > just "master". You're right, now done. > I think that has to be extended for "leim", similar to how there is a > separate entry for every subdirectory of "lisp/semantic": > > ("leim" . emacs) > +("ja-dic" . emacs) > +("quail" . emacs) Also done, on emacs-29. > In addition to adding an entry for "lisp/obsolete", the "Package" header > should be removed from all files in that directory. Is that needed given the entry in finder--builtins-alist?