From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Wed, 9 Dec 2020 15:58:40 -0600 Message-ID: References: <87im9fgm27.fsf@protesilaos.com> <87zh2ozer4.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23047"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45068@debbugs.gnu.org To: "Basil L. Contovounesios" , Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 09 22:59:29 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kn7Uf-0005uG-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Dec 2020 22:59:29 +0100 Original-Received: from localhost ([::1]:43142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kn7Ue-0006G5-H2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Dec 2020 16:59:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kn7UE-0006EE-RJ for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2020 16:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kn7UE-0005Tw-Ju for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2020 16:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kn7UE-0003wd-Du for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2020 16:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Dec 2020 21:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.160755112815142 (code B ref 45068); Wed, 09 Dec 2020 21:59:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 9 Dec 2020 21:58:48 +0000 Original-Received: from localhost ([127.0.0.1]:36395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn7U0-0003wA-47 for submit@debbugs.gnu.org; Wed, 09 Dec 2020 16:58:48 -0500 Original-Received: from mail-pg1-f176.google.com ([209.85.215.176]:42116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn7Tz-0003vx-4d for 45068@debbugs.gnu.org; Wed, 09 Dec 2020 16:58:47 -0500 Original-Received: by mail-pg1-f176.google.com with SMTP id w16so2186867pga.9 for <45068@debbugs.gnu.org>; Wed, 09 Dec 2020 13:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=ftxustNVxjMZMrX65WfhZMGr3r9hXfQgtV6aBHQbzbE=; b=mWODcl6ej4TQVQAlkZw4CMW6PyCAAVlXlGKbb1R956CAYmRgNdGJ+tVoFyPQhMhDLZ hv2VW+JZpMxpMkE7woaYO3g6VyoOoibmwrRMvKShCa19eWZQrY7SJgbo/7NAXMJ/ihak XpVn/BKs+JWrpn3eEZh6TknTfxBL7NIzT1IO+pEATTnH0jajfxASWqzDFGm+1NKqX0Pj mnW1IHGto5/sJ2+BGzpu7SG06sl9mMUOVNFfF14M8tO6uAHNSERHyb7U4MDb0qGiJJ1Z Z//CYs7mWXB1Jy1XLQ0e/RwwK1JNFF70FsrZX73mDG6ej2j6kyecLhiKNAj9jQlyaKaV oY8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=ftxustNVxjMZMrX65WfhZMGr3r9hXfQgtV6aBHQbzbE=; b=jlgJMf3GD/P0Z3KxPttrbddnOv/q0xZW3wWgKZyvPOtfb70ExGN090OJKRoGdVb6po IeVdVvKQ9IlKvf6F6L+Alw0kZ0PiBeH76Pz3pOnqfeD1y4mT0AFRfxiiDZEKdbtYJIb2 y2cy7Msgk8gUJkgK9JII60BRSb5cRunfhORKxU7veQIs7+XV4ZvN7vegcOPZqS3ICTRv vS9vbpGpY5017DTYayIc+qiugsj2SpD24046m87s+EFZDGkwfySnlbAqJO8tuDVAsQGr tu6paGX7Vk8+uNPwnpHj3ADbqYaSHMG9CGDppD4lzfpxHJ5k0CjcccpRF48Bvy81kbV+ jFxg== X-Gm-Message-State: AOAM530FIG0ypFu53EevjX1UChsEwwiPAy+Qw5vNkxUceXBvFW1bBdnF WaXRf2LRNDe67lCSjWzyynD6uZXQDQujWZsfOYc= X-Google-Smtp-Source: ABdhPJx5CXs1rRH+hPJI3PBNSEFV2WiU6GYfiBZwavgv1s3gs5JnjlyGwzSm8ikuw+Xi7DPg0v8GQjw9eQhGaYWU/9s= X-Received: by 2002:a17:90a:a090:: with SMTP id r16mr4048000pjp.179.1607551121064; Wed, 09 Dec 2020 13:58:41 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 9 Dec 2020 15:58:40 -0600 In-Reply-To: <87zh2ozer4.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195604 Archived-At: "Basil L. Contovounesios" writes: >> Those are the issues I could identify. As such, the attached patch >> removes the old files and places the new ones in ../lisp/modus-themes/. >> The themes' manual is updated to cover the new version. The NEWS entry >> is edited accordingly. >> >> I understand you may object to the course of action covered by the >> patch. Please inform me of a better way to address this issue. My >> intent is to contribute version 1.0 of my themes to Emacs (1.0.2 to be >> precise) and am prepared to make the requisite changes based on your >> feedback. > > FWIW, I'd sooner make the infrastructure changes needed to make themes > under etc/themes/ more modular and package-like, than start moving them > out of etc/themes/. > > Otherwise, I'd expect themes under lisp/ to behave exactly like those > under etc/themes/, which would make the etc/themes/ directory redundant. > (Maybe we need a lisp/themes/ directory?) Yes, I think if we start adding a number of these themes under "lisp/-theme/" it risks getting messy over time. Would it make sense to just add a "lisp/themes" directory, as Basil suggests, containing the new files modus-themes-core.el and modus-themes.el? That way, I assume that we can just keep the themes in "etc/themes" for now, while any theme that needs it can put its support libraries in "lisp/themes". Does that make sense? Would it work without any changes to load-theme?