From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) Date: Tue, 2 Jul 2019 03:54:25 +0200 Message-ID: References: <550BCB14.90005@gmx.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000f59357058ca906ed" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135395"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 20150@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 02 05:33:41 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hi9Y4-000Yyf-3l for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 05:33:40 +0200 Original-Received: from localhost ([::1]:48064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi9Y3-0005KM-33 for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Jul 2019 23:33:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43936) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi81i-0003YD-TX for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2019 21:56:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hi81d-0007bU-2q for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2019 21:56:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37549) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hi80c-0007NP-8r for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2019 21:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hi80c-0007F9-5c for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2019 21:55:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <550BCB14.90005@gmx.com> Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 01:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20150 X-GNU-PR-Package: emacs Original-Received: via spool by 20150-submit@debbugs.gnu.org id=B20150.156203248727816 (code B ref 20150); Tue, 02 Jul 2019 01:55:02 +0000 Original-Received: (at 20150) by debbugs.gnu.org; 2 Jul 2019 01:54:47 +0000 Original-Received: from localhost ([127.0.0.1]:46370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi80N-0007Ea-Cd for submit@debbugs.gnu.org; Mon, 01 Jul 2019 21:54:47 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:55746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi80K-0007E8-Ek for 20150@debbugs.gnu.org; Mon, 01 Jul 2019 21:54:44 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id a15so1262457wmj.5 for <20150@debbugs.gnu.org>; Mon, 01 Jul 2019 18:54:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=eYUPgGqoLLexHhIkOrxdIG/9zTTdRM9e/b7+F6Dy2mE=; b=n+hVZbtNOP3FsW6y6iaRcitNw9dN2A4vIbb+Jo34/3fafHqE3udx6LVexXhRg6ADlB V1bNpa0+/QVz61VSBgGSJxySDbNKGI2Nb/d4AtRH1fVDQqwLdkxmOz1WAzCWV/qQ7ext ycw583qYk8VpkGlY6UuwIvs0kz40wjPYtPe/yyXqU129gXMS+FyqjoLJZx+5gfYmZgLB z4yk/hWg25FYnck0mQn1M8/kppNErDzbyXMhIq2Rvh4BZSnt49/vKP3NyW80utrpozWM wbiiz2ByuUTm0L4SBtXbhgeKiFnmXDJD5ug7XOca5I89ZLlzxfx4Ghk2Vm07A6wDLnSr BhbA== X-Gm-Message-State: APjAAAUM9d3tazherahrY4h2r8KNtgVGGKbU4Z0WdRlLiikkHiq9dtjx 1IcTTMglC4EwtxvNZHXdhH3Q+I+tPmsoioLtoFo= X-Google-Smtp-Source: APXvYqy91kUr0jDzYrlWM+HDfIHRTmJrDA1PQW91X1J3uVf/t3LVqe9h7mR2jdL79St6rKa1Dllkbh8knCjdusAXomI= X-Received: by 2002:a7b:c04f:: with SMTP id u15mr399088wmc.106.1562032477659; Mon, 01 Jul 2019 18:54:37 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161944 Archived-At: --000000000000f59357058ca906ed Content-Type: text/plain; charset="UTF-8" Boruch Baum writes: > When completing a bookmark annotation edit, the point on the bmenu-list > would move to point-max and the selected window would be wherever the > annotation buffer had been displayed. I can confirm this bug, and suggest the attached fix. Thanks, Stefan Kangas --000000000000f59357058ca906ed Content-Type: application/octet-stream; name="0001-Restore-focus-to-Bookmark-List-after-editing-annotat.patch" Content-Disposition: attachment; filename="0001-Restore-focus-to-Bookmark-List-after-editing-annotat.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxl5q7pl0 RnJvbSA0ZmQzN2RlNDJmNzA5NzgxYzg5YTNiMGRiOWY0NTNmNWQ3MTdlMTgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDM6MDY6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBS ZXN0b3JlIGZvY3VzIHRvIEJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyBhbm5vdGF0aW9uCgoq IGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLXNlbmQtZWRpdGVkLWFubm90YXRpb24pOiBSZXN0 b3JlIGZvY3VzIHRvCkJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyB0aGUgYW5ub3RhdGlvbi4g IEFsc28gdGFrZSBjYXJlIHRvIGRlbGV0ZQp3aW5kb3cgd2hlbiBuZWVkZWQsIGFuZCBtb3ZlIHBv aW50IGJhY2sgdG8gYm9va21hcmsuIChCdWcjMjAxNTApCgooYm9va21hcmstYW5ub3RhdGlvbi1u YW1lKTogSW1wcm92ZSBkb2NzdHJpbmcuCihib29rbWFyay1ibWVudS1idWZmZXIpOiBOZXcgdmFy aWFibGUuCihib29rbWFyay1ibWVudS1zdXJyZXB0aXRpb3VzbHktcmVidWlsZC1saXN0KQooYm9v a21hcmstYm1lbnUtbGlzdCk6IFVzZSBpdC4KLS0tCiBsaXNwL2Jvb2ttYXJrLmVsIHwgMzIgKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRp b25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2Jvb2ttYXJrLmVsIGIv bGlzcC9ib29rbWFyay5lbAppbmRleCBiYmVmMGE5MjdkLi5lNmQ1MjEyOTAxIDEwMDY0NAotLS0g YS9saXNwL2Jvb2ttYXJrLmVsCisrKyBiL2xpc3AvYm9va21hcmsuZWwKQEAgLTkwMCwxMSArOTAw LDkgQEAgYm9va21hcmsta2lsbC1saW5lCiAgICAgICAoZGVsZXRlLWNoYXIgMSkpKSkKIAogCi07 OyBEZWZ2YXJzIHRvIGF2b2lkIGNvbXBpbGF0aW9uIHdhcm5pbmdzOgogKGRlZnZhciBib29rbWFy ay1hbm5vdGF0aW9uLW5hbWUgbmlsCi0gICJWYXJpYWJsZSBob2xkaW5nIHRoZSBuYW1lIG9mIHRo ZSBib29rbWFyay4KLVRoaXMgaXMgdXNlZCBpbiBgYm9va21hcmstZWRpdC1hbm5vdGF0aW9uJyB0 byByZWNvcmQgdGhlIGJvb2ttYXJrCi13aG9zZSBhbm5vdGF0aW9uIGlzIGJlaW5nIGVkaXRlZC4i KQorICAiTmFtZSBvZiBib29rbWFyayB3aG9zZSBhbm5vdGF0aW9uIGlzIGJlaW5nIGVkaXRlZC4K K1RoaXMgaXMgdXNlZCBieSBgYm9va21hcmstZWRpdC1hbm5vdGF0aW9uLW1vZGUnLiIpCiAKIAog KGRlZnVuIGJvb2ttYXJrLWRlZmF1bHQtYW5ub3RhdGlvbi10ZXh0IChib29rbWFyay1uYW1lKQpA QCAtOTYzLDEyICs5NjEsMjQgQEAgYm9va21hcmstc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbgogICAg ICAgKGZvcndhcmQtbGluZSAxKSkpCiAgIDs7IFRha2Ugbm8gY2hhbmNlcyB3aXRoIHRleHQgcHJv cGVydGllcy4KICAgKGxldCAoKGFubm90YXRpb24gKGJ1ZmZlci1zdWJzdHJpbmctbm8tcHJvcGVy dGllcyAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkpCi0JKGJvb2ttYXJrLW5hbWUgYm9va21hcmst YW5ub3RhdGlvbi1uYW1lKSkKKyAgICAgICAgKGJvb2ttYXJrLW5hbWUgYm9va21hcmstYW5ub3Rh dGlvbi1uYW1lKQorICAgICAgICAoYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikpKQogICAgIChib29r bWFyay1zZXQtYW5ub3RhdGlvbiBib29rbWFyay1uYW1lIGFubm90YXRpb24pCiAgICAgKHNldHEg Ym9va21hcmstYWxpc3QtbW9kaWZpY2F0aW9uLWNvdW50CiAgICAgICAgICAgKDErIGJvb2ttYXJr LWFsaXN0LW1vZGlmaWNhdGlvbi1jb3VudCkpCi0gICAgKGJvb2ttYXJrLWJtZW51LXN1cnJlcHRp dGlvdXNseS1yZWJ1aWxkLWxpc3QpKQotICAoa2lsbC1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkp CisgICAgOzsgSWYgdGhlIGN1cnJlbnQgd2luZG93IHdhcyBvbmx5IGV2ZXIgdXNlZCBmb3IgZWRp dGluZyB0aGUKKyAgICA7OyBhbm5vdGF0aW9uLCBkZWxldGUgaXQuCisgICAgKHdoZW4gKG5vdCAo d2luZG93LXByZXYtYnVmZmVycykpCisgICAgICAoZGVsZXRlLXdpbmRvdykpCisgICAgOzsgUmVz dG9yZSBmb2N1cyB0byBCb29rbWFyayBMaXN0LgorICAgIChwb3AtdG8tYnVmZmVyIChnZXQtYnVm ZmVyIGJvb2ttYXJrLWJtZW51LWJ1ZmZlcikpCisgICAgKGJvb2ttYXJrLWJtZW51LWxpc3QpCisg ICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkKKyAgICA7OyBSZXN0b3JlIHBvaW50IHRvIHRoZSBi b29rbWFyayB3ZSBqdXN0IGVkaXRlZC4KKyAgICAodW5sZXNzICh0ZXh0LXByb3BlcnR5LXNlYXJj aC1mb3J3YXJkICdib29rbWFyay1uYW1lLXByb3AgYm9va21hcmstbmFtZSkKKyAgICAgIChnb3Rv LWNoYXIgKHBvaW50LW1pbikpKQorICAgIChtZXNzYWdlICJTZXQgYW5ub3RhdGlvbiBmb3IgXCIl c1wiIiBib29rbWFyay1uYW1lKQorICAgIChraWxsLWJ1ZmZlciBidWZmZXIpKSkKIAogCiAoZGVm dW4gYm9va21hcmstZWRpdC1hbm5vdGF0aW9uIChib29rbWFyay1uYW1lLW9yLXJlY29yZCkKQEAg LTE1NjMsOSArMTU3MywxMSBAQCBib29rbWFyay1sb2FkCiAJKHByb2dyZXNzLXJlcG9ydGVyLWRv bmUgcmVwb3J0ZXIpKSkpKQogCiAMCi07OzsgQ29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtl IGJvb2ttYXJrIG1lbnUuCis7OzsgQ29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtlIGJvb2tt YXJrIGxpc3QuCiA7OyBQcmVmaXggaXMgImJvb2ttYXJrLWJtZW51IiBmb3IgImJ1ZmZlci1tZW51 IjoKIAorKGRlZmNvbnN0IGJvb2ttYXJrLWJtZW51LWJ1ZmZlciAiKkJvb2ttYXJrIExpc3QqIgor ICAiTmFtZSBvZiBidWZmZXIgdXNlZCBmb3IgQm9va21hcmsgTGlzdC4iKQogCiAoZGVmdmFyIGJv b2ttYXJrLWJtZW51LWhpZGRlbi1ib29rbWFya3MgKCkpCiAKQEAgLTE2NTAsNyArMTY2Miw3IEBA IGJvb2ttYXJrLWJtZW51LW1vZGUtbWFwCiAoZGVmdW4gYm9va21hcmstYm1lbnUtc3VycmVwdGl0 aW91c2x5LXJlYnVpbGQtbGlzdCAoKQogICAiUmVidWlsZCB0aGUgQm9va21hcmsgTGlzdCBpZiBp dCBleGlzdHMuCiBEb24ndCBhZmZlY3QgdGhlIGJ1ZmZlciByaW5nIG9yZGVyLiIKLSAgKGlmIChn ZXQtYnVmZmVyICIqQm9va21hcmsgTGlzdCoiKQorICAoaWYgKGdldC1idWZmZXIgYm9va21hcmst Ym1lbnUtYnVmZmVyKQogICAgICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgICAgIChzYXZlLXdpbmRv dy1leGN1cnNpb24KICAgICAgICAgICAoYm9va21hcmstYm1lbnUtbGlzdCkpKSkpCkBAIC0xNjY0 LDcgKzE2NzYsNyBAQCBib29rbWFyay1ibWVudS1saXN0CiBkZWxldGlvbiwgb3IgPiBpZiBpdCBp cyBmbGFnZ2VkIGZvciBkaXNwbGF5aW5nLiIKICAgKGludGVyYWN0aXZlKQogICAoYm9va21hcmst bWF5YmUtbG9hZC1kZWZhdWx0LWZpbGUpCi0gIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRl ICIqQm9va21hcmsgTGlzdCoiKSkpCisgIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlIGJv b2ttYXJrLWJtZW51LWJ1ZmZlcikpKQogICAgIChpZiAoY2FsbGVkLWludGVyYWN0aXZlbHktcCAn aW50ZXJhY3RpdmUpCiAgICAgICAgIChzd2l0Y2gtdG8tYnVmZmVyIGJ1ZikKICAgICAgIChzZXQt YnVmZmVyIGJ1ZikpKQotLSAKMi4yMS4wCgo= --000000000000f59357058ca906ed--