From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58007: 28.1; compilation-error-properties skips non-matching FILE indices Date: Sun, 14 Jan 2024 00:18:36 -0600 Message-ID: References: <87edw23wd5.fsf@gnus.org> <8735ch12vy.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19241"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Axel Forsman , 58007@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 14 07:19:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOtq2-0004p0-GJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Jan 2024 07:19:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOtpp-0006ib-L2; Sun, 14 Jan 2024 01:19:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOtpn-0006iI-4k for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 01:19:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOtpm-0004rC-QZ for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 01:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOtpl-00043N-NL for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 01:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jan 2024 06:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58007-submit@debbugs.gnu.org id=B58007.170521312315553 (code B ref 58007); Sun, 14 Jan 2024 06:19:01 +0000 Original-Received: (at 58007) by debbugs.gnu.org; 14 Jan 2024 06:18:43 +0000 Original-Received: from localhost ([127.0.0.1]:41527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOtpT-00042m-Ev for submit@debbugs.gnu.org; Sun, 14 Jan 2024 01:18:43 -0500 Original-Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:54502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOtpR-00042X-I7 for 58007@debbugs.gnu.org; Sun, 14 Jan 2024 01:18:42 -0500 Original-Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-558ac3407eeso3335148a12.0 for <58007@debbugs.gnu.org>; Sat, 13 Jan 2024 22:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705213116; x=1705817916; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=hmetkSHIycQofcWjcMJKVN/muvq4Gf2T9X+liSUqGYI=; b=XEZGR8A8NumP4QvdoMF5HbMIfAelzRi1pGgh3FtdHxC0F/vjD95Tlxoh4NvD6YAEst Qh4QsqRwY0c2KvD4DB2JxXj5FAr8mBYi+mOv60yvkAu5m/LIKTJX+gb7hIz1zceI/Jjw yw/ow93lCkFNGgXCSQWgTwFTXWqxpXRbf63SYSgyUbYeeMvg9A7RxehtQW8dK+uKTr+O w2OQbWCMZ38bgahxWuTIzphe6fFsN9+6pjumaVvpCd0Gzf6uqky7bSAdF2+8rmogbHAE 7CWQJpgNqwiyod9+42fBlJjfsTrb4l7F8N53ybgcMj6Iuo6FCItyD5i0+RHwTNRNFJGP eL4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705213116; x=1705817916; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hmetkSHIycQofcWjcMJKVN/muvq4Gf2T9X+liSUqGYI=; b=X3/0hyQQboJubggQ4woOYi8Xh9Xlmt8fOnjzMRlwCZmSTTuLmVb+FhfNV6m1BIysDt viXd7BTZnhSmNfeOKxs/96tWDW1GYD/n3/RwT3a2OAV+ITl4gDUFDlo9yNjYX4WEVkAh ORHv/r36RquTwvafjeV+tJKASvHqzWoJNi/cs6PW/fSL7LKhv1pWmdW37HmYt6S1JHp+ A31gAgy++RHFWFnetrRyaQp6PgS49HFXF5AikWSpCJ+awjF7SRe5fzzw1/Z2GO9VTP0t N1miaHMgYJvIqJxhzkzUV/l7zEn+POuUbAXoQw2NPDiepQmjV4eVDmhM3fB6Cr3iRvga OiHg== X-Gm-Message-State: AOJu0YzYcABYU6PenhN7G4G9NbSydMmP9ykdCkspzKyvxCk5lSVTa/Tp HnHQ/8bzx/8AhzOcgZ39Jsuf3boHnSLwFElBM2I= X-Google-Smtp-Source: AGHT+IGRISBYXTO67f9qgVIvizK/57jEOxnLSSR+uTGJAu/7rqYYWxG+OPsfXFlD6YCameofwwcobcOPClAfzGsvDrs= X-Received: by 2002:a05:6402:518f:b0:557:af52:e7bb with SMTP id q15-20020a056402518f00b00557af52e7bbmr2025210edd.60.1705213116614; Sat, 13 Jan 2024 22:18:36 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 14 Jan 2024 00:18:36 -0600 In-Reply-To: (Stefan Kangas's message of "Wed, 6 Sep 2023 15:50:25 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278178 Archived-At: Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> Reading the patch again, you're right -- since most of the changes are >> indentation changes, we can apply the patch without a copyright >> assignment. >> >> However, your patch leads to a test failure -- can you have a look at >> that? > > That was one year ago. > > Axel, did you have a chance to look into the below test failure? Ping. >> Test compile-test-functions backtrace: >> file-name-absolute-p(("my-file")) >> compilation-error-properties((closure (t) nil '("my-file")) (closure >> compilation-parse-errors(1 17) >> (let ((rule (nth 0 test)) (str (nth 1 test)) (pos (nth 2 test)) (col >> (let ((ert--infos (cons (cons "testcase: " (format "%S" test)) ert-- >> compile--test-error-line((my-rule "My error message" 1 (39 . 24) (12 >> (let ((compilation-num-errors-found 0) (compilation-num-warnings-fou >> (progn (font-lock-mode -1) (let ((compilation-num-errors-found 0) (c >> (unwind-protect (progn (font-lock-mode -1) (let ((compilation-num-er >> (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn >> (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current >> (let* ((file-fun #'(lambda nil '("my-file"))) (line-start-fun #'(lam >> (closure (t) nil (let* ((file-fun #'(lambda nil '("my-file"))) (line >> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test >> ert-run-test(#s(ert-test :name compile-test-functions :documentation >> ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m >> ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co >> ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) >> ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un >> eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( >> command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/compile-te >> command-line() >> normal-top-level() >> Test compile-test-functions condition: >> testcase: (my-rule "My error message" 1 (39 . 24) (123 . 134) "my-file" 2) >> (wrong-type-argument stringp >> ("my-file")) >> FAILED 2/3 compile-test-functions (0.000089 sec) at lisp/progmodes/compile-tests.el:522 >> passed 3/3 compile-test-grep-regexps (0.001284 sec) >> >> Ran 3 tests, 2 results as expected, 1 unexpected (2022-09-24 12:26:55+0200, 0.083845 sec) >> >> 1 unexpected results: >> FAILED compile-test-functions