From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary Date: Mon, 29 Jan 2024 19:39:54 -0500 Message-ID: References: <87a5onlnwk.fsf@linj.tech> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13156"; mail-complaints-to="usenet@ciao.gmane.io" To: Lin Jian , 68810@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 30 01:41:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUcBx-0003Fk-J6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Jan 2024 01:41:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUcBa-00016g-6v; Mon, 29 Jan 2024 19:41:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUcBM-0000rN-B8 for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 19:40:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUcBK-00028c-3y for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 19:40:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rUcBS-0005oD-8R for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 19:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2024 00:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68810 X-GNU-PR-Package: emacs Original-Received: via spool by 68810-submit@debbugs.gnu.org id=B68810.170657521422249 (code B ref 68810); Tue, 30 Jan 2024 00:41:02 +0000 Original-Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 00:40:14 +0000 Original-Received: from localhost ([127.0.0.1]:33944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUcAf-0005mm-Sx for submit@debbugs.gnu.org; Mon, 29 Jan 2024 19:40:14 -0500 Original-Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:45331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUcAd-0005mT-5x for 68810@debbugs.gnu.org; Mon, 29 Jan 2024 19:40:12 -0500 Original-Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2d057b6df2aso3849501fa.3 for <68810@debbugs.gnu.org>; Mon, 29 Jan 2024 16:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706575196; x=1707179996; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=H111L9C6B5IGVS2edxOIY9GLuzqh4JfXCodxJ2EP8vA=; b=cC7rAJ6ydlOPVccpvTgzdT58Bx9k+nbd9HGZ5ailtWsdcry/jGWMQK6h2aYskNe1sT ml/2ZipNgfkboUZJ52h1rl12o1oGVEKpFgBjO92rwFkqxQeomrFjvvJB/nkoBqsXSBiv iLdReMlxX6QIgaSymuc0pjKCmhmHQFlgGOvecldvrvf+2+N2mbIRbee8GMgChxS7xadj Sjl97l7XZ86//lz192VC2AImpH0sNJREXxCEpnwuq9KU403ezC2NLhGKRDqNoe9zeZi4 nl5LR7G0Xv7XrDHquI0hHjHSNyRc6AjABNgON7IxGUXI5fD824z2+YatlAgeMavFchfq 7Aog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706575196; x=1707179996; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H111L9C6B5IGVS2edxOIY9GLuzqh4JfXCodxJ2EP8vA=; b=t+3g2lzGPicTBfnC5Qapfn+zvjnalJ/PiQP2g6qxeVRtUnmtmw4bUF1xCxPOIM7Lmg iEFSnSSlapmn5SobNfFEhyxtPN+60xAb4wDc/pJbjkH3lfnfJ4e98ePgOTGlBvxtgxR8 YCKKV+zx5DuMbA8lWNO6ladBW0rREwDuIqOOu8ytG6LDm6BDRxSjTaH08bPc0KbnQyLy mU54xqkRIhILYsGbnKaH/Z/CXRwpyPCiJBAcFgy+Mh2SOhmu12Ty39EtsLz2FQm4ZuRl 5MSaDeh1wyrFwawFo1Vxbd9Essy+EAj9kGFijLHwL9FSmCp8CT3LXRkXEUJ67AN0Be0f MeAw== X-Gm-Message-State: AOJu0YwV11lW95B6TYxkbpU/PVJEi0qu84H+XV8OWVB05xU4Pe42E76S AADzcelXDG+DYi04n9/Q+SIDnxbiGKoLg+t4d3M4KaSFIiqPkl6Vr34O9OZxr22SkTSwfhwbHwZ D6SKyjSkLimm9o3B+S54P38ewCNkgHNgw2N8= X-Google-Smtp-Source: AGHT+IFFmggKWcjLlGeLAfWR5QF2uO+fCEn5NBDN/O/XkzvVoJ+ca+BSkD/1Fygwn8/EfdHstKIGZurrA9EdKKg2AO0= X-Received: by 2002:a2e:b0f8:0:b0:2cf:3037:2a35 with SMTP id h24-20020a2eb0f8000000b002cf30372a35mr4789288ljl.48.1706575195704; Mon, 29 Jan 2024 16:39:55 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 29 Jan 2024 19:39:54 -0500 In-Reply-To: <87a5onlnwk.fsf@linj.tech> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279152 Archived-At: Lin Jian via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Recommendation about setting transfer.fsckObjects of git to true can be > found in admin/notes/git-workflow and CONTRIBUTE. In addition, it is > set in autogen.sh. > > This is triggered by a discussion[1] on emacs-devel. The first commit > about this is cedd7cad092809a97c1ed7fb883b68fa844cea58 on 2016-01-31. > However, on 2016-02-04, another discussion[2] shows that git is secure > by default so setting this option is not necessary. > > What about removing this unnecessary recommendation? > > By the way, the same recommendation can be found on Emacswiki[3][4]. > > [1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html > [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29 > [3]: https://www.emacswiki.org/emacs/GitQuickStartForEmacsDevs > [4]: https://www.emacswiki.org/emacs/GitForEmacsDevs Are you sure? The git documentation says: transfer.fsckObjects When fetch.fsckObjects or receive.fsckObjects are not set, the value of this variable is used instead. Defaults to false. When set, the fetch or receive will abort in the case of a malformed object or a link to a nonexistent object. In addition, various other issues are checked for, including legacy issues (see fsck.), and potential security issues like the existence of a .GIT directory or a malicious .gitmodules file (see the release notes for v2.2.1 and v2.17.1 for details). Other sanity and security checks may be added in future releases. https://git-scm.com/docs/git-config#Documentation/git-config.txt-transferfsckObjects