unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 59229@debbugs.gnu.org, Brian Leung <leungbk@posteo.net>
Subject: bug#59229: [PATCH] Add tree-sitter-based major modes to eglot-server-programs
Date: Thu, 24 Nov 2022 10:44:17 -0800	[thread overview]
Message-ID: <CADwFkmmtURzh9CpurP=zp8mSA=5cwK66JDzmf0cA0GoSp9SEZg@mail.gmail.com> (raw)
In-Reply-To: <83cz9rmkoc.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Nov 2022 08:29:39 +0200")

close 59229 29.1
thanks

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: Stefan Kangas <stefankangas@gmail.com>
>> From: Brian Leung <leungbk@posteo.net>
>> Date: Sat, 12 Nov 2022 22:35:38 +0000
>>
>> This adds several to-be-merged tree-sitter-based major modes to eglot.
>
> Thanks, but please hold your horses on the C/C++/Java modes, as we
> didn't yet finalize their integration into Emacs.  It is possible they
> will not be major modes after all.
>
> Not sure about JSON and CSS modes, but they might share the same fate.
>
> Bottom line: this is too soon for such change, we should wait at least
> until the tree-sitter branch lands on master.

AFAICT, these modes have all landed on master, so I've pushed the patch
and I'm closing the bug.  Thanks.





  parent reply	other threads:[~2022-11-24 18:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12 22:35 bug#59229: [PATCH] Add tree-sitter-based major modes to eglot-server-programs Brian Leung
2022-11-13  6:29 ` Eli Zaretskii
2022-11-13 13:58   ` Stefan Kangas
2022-11-24 18:44   ` Stefan Kangas [this message]
2022-11-24 19:41     ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmtURzh9CpurP=zp8mSA=5cwK66JDzmf0cA0GoSp9SEZg@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=59229@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=leungbk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).