From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#36588: Unable to revert M-x apropos help buffer Date: Fri, 12 Jul 2019 07:03:31 +0200 Message-ID: References: <87h87sk4fv.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000a05b10058d74d544" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205907"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36588@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 12 07:04:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlnj9-000rSn-5R for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 07:04:11 +0200 Original-Received: from localhost ([::1]:46630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlnj8-0001Px-3G for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 01:04:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55147) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlnj4-0001Pq-7o for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 01:04:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlnj2-0003l9-7p for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 01:04:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlnj0-0003ip-C3 for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 01:04:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlnj0-0000Vw-5H for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 01:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jul 2019 05:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36588 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36588-submit@debbugs.gnu.org id=B36588.15629078321961 (code B ref 36588); Fri, 12 Jul 2019 05:04:02 +0000 Original-Received: (at 36588) by debbugs.gnu.org; 12 Jul 2019 05:03:52 +0000 Original-Received: from localhost ([127.0.0.1]:39134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlnip-0000VX-QA for submit@debbugs.gnu.org; Fri, 12 Jul 2019 01:03:52 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:35160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlnin-0000VK-99 for 36588@debbugs.gnu.org; Fri, 12 Jul 2019 01:03:49 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id y4so8511407wrm.2 for <36588@debbugs.gnu.org>; Thu, 11 Jul 2019 22:03:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qp8MlD+YviRGPo6l6vKOdvAy9doQgyZ0kFIENl/j+wg=; b=KKt205GZv2WlkFUfHz7QN9duiOqFzOhvRUZsCNhAuyQLae5PnpdPU9bGe2mO+mdghX XMuPjuHZaOvb9CqmWB+iNfegaePynhZAjtmQYAjBubrHnNR6w0v+yKBUsCFchIKySTEY PwkwLn9dXGssc2STSleKXl76Znv3airOJoCJauhMGSMhWVJS0KR8jHjfkV1HYrEN5F/2 aGuGmWdSujkLMjuiBuGOH5Z+I6AcEHtQhXvPtAttLhRkVPyfQeWrJrFKxy37QOvpH+7T WaAS4xXQJ5CvTpl8vxzXxs81lMjVzkf/bVyPp2S67x0kZ+HCanxhsGua7PQLVXM2qcDw dxHQ== X-Gm-Message-State: APjAAAWafI8lCdYS4FH+2neVczZ1MdE8zE8ADr/wiKF/47RYPyj/mhGU bm6fmDC4jJAIPlaY38wGN3QIukYrDgRxjZewo10= X-Google-Smtp-Source: APXvYqzyx7Ggw5ZXKCUDvx9ZOFxm0GWkXdz1aVAQ7e8nSsVkYyBmOYVjGlYAlPC/5/gvWjSQ7bn8EK97uD1K9IZ7FG8= X-Received: by 2002:adf:eb49:: with SMTP id u9mr2902488wrn.215.1562907823323; Thu, 11 Jul 2019 22:03:43 -0700 (PDT) In-Reply-To: <87h87sk4fv.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162750 Archived-At: --000000000000a05b10058d74d544 Content-Type: text/plain; charset="UTF-8" Basil L. Contovounesios writes: > This is because Apropos buffers are set up in apropos-print using > with-output-to-temp-buffer, which by default calls help-mode, which sets > revert-buffer-function permanently-locally to help-mode-revert-buffer. > > [Aside: Why is revert-buffer-function permanent-local?] > > help-mode-revert-buffer expects the command which generated the Help > buffer to have previously called help-setup-xref. This should be > possible to do in Apropos, but it would be quite ugly as help-setup-xref > needs to be called with the Help buffer current, so Apropos commands > would need to set their own version of help-xref-stack-item before > apropos-print performs the help-setup-xref dance. Besides, Apropos > buffers are not (currently) really Help buffers. > > Instead, I propose emulating a simpler version of help-setup-xref > specific to Apropos: > > > I don't consider this duplication because, unless Apropos were > completely refactored, setting something like apropos--current would be > necessary either way. This has the added perk of not coupling Apropos > with Help any more than it currently needs to be. > > WDYT? Not familiar with this code, so I can't speak to your solution. I can confirm it fixes the problem though. Thanks for looking at it so promptly. I've attached a small patch with a test for this. Thanks, Stefan Kangas --000000000000a05b10058d74d544 Content-Type: application/octet-stream; name="0001-test-lisp-apropos-tests.el-New-file.patch" Content-Disposition: attachment; filename="0001-test-lisp-apropos-tests.el-New-file.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxzmygl50 RnJvbSA1NjJkMjYyMjA0OGJlOGFjNTUwOWQ4Y2NkNGI5ZmQxODI0NGZjM2E0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDEyIEp1bCAyMDE5IDA2OjU3OjI5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g KiB0ZXN0L2xpc3AvYXByb3Bvcy10ZXN0cy5lbDogTmV3IGZpbGUuCgotLS0KIHRlc3QvbGlzcC9h cHJvcG9zLXRlc3RzLmVsIHwgMzQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwog MSBmaWxlIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCB0ZXN0 L2xpc3AvYXByb3Bvcy10ZXN0cy5lbAoKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9hcHJvcG9zLXRl c3RzLmVsIGIvdGVzdC9saXNwL2Fwcm9wb3MtdGVzdHMuZWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMC4uNDQ3MzdkOTAyZQotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3QvbGlz cC9hcHJvcG9zLXRlc3RzLmVsCkBAIC0wLDAgKzEsMzQgQEAKKzs7OyBhcHJvcG9zLXRlc3RzLmVs IC0tLSBUZXN0cyBmb3IgYXByb3Bvcy5lbCAgLSotIGxleGljYWwtYmluZGluZzogdDsgLSotCisK Kzs7IENvcHlyaWdodCAoQykgMjAxOSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKwor OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEVtYWNzLgorCis7OyBHTlUgRW1hY3MgaXMgZnJl ZSBzb2Z0d2FyZTogeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQorOzsgaXQg dW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJs aXNoZWQgYnkKKzs7IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9u IDMgb2YgdGhlIExpY2Vuc2UsIG9yCis7OyAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJz aW9uLgorCis7OyBHTlUgRW1hY3MgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3 aWxsIGJlIHVzZWZ1bCwKKzs7IGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVu IHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7OyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBG T1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCis7OyBHTlUgR2VuZXJhbCBQdWJsaWMg TGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCis7OyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQg YSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorOzsgYWxvbmcgd2l0aCBH TlUgRW1hY3MuICBJZiBub3QsIHNlZSA8aHR0cHM6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+Lgor Cis7OzsgQ29tbWVudGFyeToKKworOzs7IENvZGU6CisKKyhyZXF1aXJlICdlcnQpCisocmVxdWly ZSAnYXByb3BvcykKKworKGVydC1kZWZ0ZXN0IGFwcm9wb3MtdGVzdHMtcmV2ZXJ0LWJ1ZmZlciAo KQorICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgIChhcHJvcG9zICJmb28iKQorICAgIChyZXZlcnQt YnVmZmVyIG5pbCB0KQorICAgIChzaG91bGQgKGxvb2tpbmctYXQgIlR5cGUgUkVUIG9uIGEgdHlw ZSBsYWJlbCIpKSkpCisKKyhwcm92aWRlICdhcHJvcG9zLXRlc3RzKQorOzs7IGFwcm9wb3MtdGVz dHMuZWwgZW5kcyBoZXJlCi0tIAoyLjIxLjAKCg== --000000000000a05b10058d74d544--