bug#38187: 27.0.50; No mouse-wheel scaling on images

[Stefan Kangas <stefan@marxist.se>]

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> FWIW, I think the opposite.  I think that zooming text, images and all
>> buffer content together should be the default.  I believe that it
>> would feel both natural and familiar, especially to new users, since
>> that's how e.g. web browsers, LibreOffice and evince, etc. works.
>
> That's true.  I guess the scroll button could change both
> image-scaling-factor and text-scale-mode-amount...

Perhaps we should open a separate issue for that?

> But, on the other hand, I could definitely see people preferring to
> change just one or the other.  So perhaps there should be separate
> commands that people can bind according to their preference?

100 % agree.

>> (That also reminds me that, IMO, text-scale-increase/decrease should
>> be renamed to font-size-increase/decrease.  The current names are not
>> very discoverable; when one wants to change the font size, and says:
>> `M-x font TAB'.  At the very least, we should have such defaliases.)
>
> Makes sense to me.

How does the attached patch look?  I took the minimal route of just
adding convenience aliases.

Best regards,
Stefan Kangas

[-- Attachment #2: 0001-Add-aliases-font-size-increase-decrease.patch --]
[-- Type: application/octet-stream, Size: 1022 bytes --]

From 98a7e30feaccc887354b05fcddb72c9bd715b95b Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Tue, 19 Nov 2019 15:45:15 +0100
Subject: [PATCH] Add aliases font-size-{increase,decrease}

* lisp/face-remap.el (font-size-increase, font-size-decrease): New
convenience aliases for 'text-scale-increase' and
'text-scale-decrease'.
---
 lisp/face-remap.el | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lisp/face-remap.el b/lisp/face-remap.el
index f2ff2ec6f1..08ef911d1f 100644
--- a/lisp/face-remap.el
+++ b/lisp/face-remap.el
@@ -312,6 +312,10 @@ text-scale-decrease
   (interactive "p")
   (text-scale-increase (- dec)))
 
+;; Convenience aliases.
+(defalias 'font-size-increase 'text-scale-increase)
+(defalias 'font-size-decrease 'text-scale-decrease)
+
 ;;;###autoload (define-key ctl-x-map [(control ?+)] 'text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control ?-)] 'text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control ?=)] 'text-scale-adjust)
-- 
2.23.0