From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Date: Mon, 26 Oct 2020 15:59:45 +0100 Message-ID: References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20935"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Kevin Foley , 44202@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 26 16:01:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX3zj-0005MU-55 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 16:01:11 +0100 Original-Received: from localhost ([::1]:39742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX3zi-0004Tj-4n for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 11:01:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX3za-0004Tc-3p for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 11:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kX3zZ-000464-Pk for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 11:01:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kX3zZ-00078U-OQ for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 11:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44202 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44202-submit@debbugs.gnu.org id=B44202.160372440527290 (code B ref 44202); Mon, 26 Oct 2020 15:01:01 +0000 Original-Received: (at 44202) by debbugs.gnu.org; 26 Oct 2020 15:00:05 +0000 Original-Received: from localhost ([127.0.0.1]:40763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX3ye-000765-UE for submit@debbugs.gnu.org; Mon, 26 Oct 2020 11:00:05 -0400 Original-Received: from mail-ej1-f42.google.com ([209.85.218.42]:39779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX3yd-000752-2M for 44202@debbugs.gnu.org; Mon, 26 Oct 2020 11:00:03 -0400 Original-Received: by mail-ej1-f42.google.com with SMTP id qh17so14021535ejb.6 for <44202@debbugs.gnu.org>; Mon, 26 Oct 2020 08:00:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W2VQfT4uLECvb0P+zqcGycI9Jjc1D0fFJ063t8GFoIo=; b=dla9jKu3JXLlf4CHgyKgoa1T02iFuEV1nUK3BQjQHw1/Rtg6BUn4LxqFx5gE0d9efe um1HtUWn1fdkXZ4jR1TxtwEaw5G33HEAkRZjmqzQBLTs/c352Z9f/GE8hUKI80W7X4sD KxPM0zdnz/ccvIImRFiPGMr3SLHOzIopfmc2CGfGJ63Z9Ad6l65kwkORFeWhDeEK0N++ p44FESTDyn9EP4MoWy33uWOSObeJ39rm7SI7H0PsRwQro7yP7dnfAie1hBCcyV5tPMod EOzdcKV/BxVehkHV8sEEFw4Euz3GnImVCRQ5GtHw69bBdBzBcqBbQEmBHOjgEWuFFIEv DTMw== X-Gm-Message-State: AOAM5339P29Z1duSLEuOtPQCyjaJSYRD5JaCNFf7a34N/BfX4KRzoQgh K+cwlPjfU3Wk7R1B1Bs9IVb1F+1uz2g1/tekbo4= X-Google-Smtp-Source: ABdhPJxKyyR+tT4ee2BMMZ4iFnLfofuYYgHN8MsbAT+iQS87VWROka2V+FurSvZxMCzItdmCkrlSu8ehUIzR7Y7sCRI= X-Received: by 2002:a17:906:1246:: with SMTP id u6mr16104066eja.432.1603724397027; Mon, 26 Oct 2020 07:59:57 -0700 (PDT) In-Reply-To: <87sga1477z.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191583 Archived-At: Lars Ingebrigtsen writes: > I've looked at some of the different usages of `revert-buffer-function', > and the help-functions one seems to be an outlier -- very few of the > non-file ones ask at all (I haven't found one yet, but I've only looked > at a handful). Which makes me wonder why the *Help* one does? I've > always found that pretty odd. What's the use case for prompting the > user when the user hits `g' here? Thank you for looking into this more deeply. I think not prompting here could work, unless there is some important reason not to. > I am a bit worried about incompatibles by hoisting that code up to > `revert-buffer'... Indeed, I missed to mention that in my previous email. So it might not be worth it if we can do the above instead.