bug#71490: [PATCH] ; Fix customisation buffer for dired group

bug#71490: [PATCH] ; Fix customisation buffer for dired group

[Visuwesh]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

Tags: patch

To reproduce,

1. emacs -Q 
2. M-x customize-group RET dired RET
3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep

In GNU Emacs 30.0.50 (build 8, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.18.0, Xaw scroll bars) of 2024-05-07 built on astatine
Repository revision: 4b31074f5f49898ba0499a2b617cad425750eafa
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101011
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure --with-sound=alsa --with-x-toolkit=lucid --with-json
 --without-xaw3d --without-gconf --without-libsystemd --with-cairo
 --with-xft'

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-customisation-buffer-for-dired-group.patch --]
[-- Type: text/patch, Size: 1429 bytes --]

From 628afa281e1c050a9fe49a4c362b1572c439c4d2 Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Tue, 11 Jun 2024 10:51:39 +0530
Subject: [PATCH] ; Fix customisation buffer for dired group

* lisp/dired-aux.el
(dired-create-destination-dirs-on-trailing-dirsep): Actually
concat the string.
---
 lisp/dired-aux.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index a2ce3083cfe..a0fa1ce6fe5 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -2218,14 +2218,14 @@ dired-create-destination-dirs-on-trailing-dirsep
 trailing /) is given or this option or
 `dired-create-destination-dirs' is nil, `old_name' will be
 renamed to `new_name'."
-  :type '(choice
+  :type `(choice
           (const :tag
-                 (concat "Do not treat destination dirs with a "
-                         "trailing directory separator specially")
+                 ,(concat "Do not treat destination dirs with a "
+                          "trailing directory separator specially")
                  nil)
           (const :tag
-                 (concat "Treat destination dirs with trailing "
-                         "directory separator specially")
+                 ,(concat "Treat destination dirs with trailing "
+                          "directory separator specially")
                  t))
   :group 'dired
   :version "29.1")
-- 
2.43.0

bug#71490: [PATCH] ; Fix customisation buffer for dired group

[Stefan Kangas]

Version: 30.1

Visuwesh <visuweshm@gmail.com> writes:

> Tags: patch
>
> To reproduce,
>
> 1. emacs -Q
> 2. M-x customize-group RET dired RET
> 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep

Thanks, pushed as commit 076e8ad5fc5 and closing.

bug#71490: [PATCH] ; Fix customisation buffer for dired group

[Eli Zaretskii]

> From: Visuwesh <visuweshm@gmail.com>
> Date: Tue, 11 Jun 2024 11:05:12 +0530
> 
> 1. emacs -Q 
> 2. M-x customize-group RET dired RET
> 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep

Why do we use 'concat' there in the first place?

I fixed the defcustom not to use 'concat' (and fixed the text while at
that).