From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44166: pcase-exhaustive doc string could be more didactic Date: Sun, 19 Sep 2021 08:34:16 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10451"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: monnier@iro.umontreal.ca To: 44166@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 19 17:35:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRyqr-0002VA-4s for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 17:35:33 +0200 Original-Received: from localhost ([::1]:42346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRyqq-0002Oj-2q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 11:35:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRyqN-0001fT-0a for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 11:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56278) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRyqM-0000kX-Oq for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 11:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRyqM-0007LL-Mw for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 11:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Sep 2021 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44166 X-GNU-PR-Package: emacs Original-Received: via spool by 44166-submit@debbugs.gnu.org id=B44166.163206567128179 (code B ref 44166); Sun, 19 Sep 2021 15:35:02 +0000 Original-Received: (at 44166) by debbugs.gnu.org; 19 Sep 2021 15:34:31 +0000 Original-Received: from localhost ([127.0.0.1]:39590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRypq-0007KR-PO for submit@debbugs.gnu.org; Sun, 19 Sep 2021 11:34:31 -0400 Original-Received: from mail-pl1-f173.google.com ([209.85.214.173]:46715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRypi-0007Jj-SB for 44166@debbugs.gnu.org; Sun, 19 Sep 2021 11:34:30 -0400 Original-Received: by mail-pl1-f173.google.com with SMTP id bg1so9374340plb.13 for <44166@debbugs.gnu.org>; Sun, 19 Sep 2021 08:34:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=w0LW0UbHGpCH4hHD05Tcgo7gR6rg19uH0ee5+8g9uG8=; b=YXRH39YeZpyPwT6g3JO/1vbS/EaX1S/jYOGZ0kQsiobSToCxKpuB6ISL1jjPSwo0y2 +UhkL1K1kxezYNyZXhvQkT2QJDg0DwyrjH5Yh3OSsVDSUM2EWM3CVqIoW2mvzDZlm1we bPMr+0bl2iqwSNsr111RFfVt/AS6caA06JliPuRPwFQ73plVMfJZrtNcD/5KNwF/anle saarDAhkKBhs4DZCDvGQetYA4pJ3JAylbkISXgBs2+FQBgnCTCI/637opduRY+nLuyjf dy2QreWZcvwaKLzIBgL665ku1NQNMdf+ov8oSHJGMqD0wiqB70eMmkgTLyJ2mqW6rr6X kcBQ== X-Gm-Message-State: AOAM533fkPudE4Ns1U5/9V7AbjY+H4rEjGR5WZVGCi9z4jPf68sy0A67 558UuAxGutT0TLS+dXVX2eOcmzcglZ4oCWL9V9WdVLj+ X-Google-Smtp-Source: ABdhPJwejg4WVbUIkG22wreXhVl4nzAWrbJxKfOsbv77MDcVCP1zXvPSGKGVri6wVLup8KMaR/KIbPvlj/27rof6qng= X-Received: by 2002:a17:90a:7c42:: with SMTP id e2mr32570417pjl.132.1632065657147; Sun, 19 Sep 2021 08:34:17 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Sep 2021 08:34:16 -0700 In-Reply-To: (Stefan Kangas's message of "Thu, 22 Oct 2020 20:30:41 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214732 Archived-At: tags 44166 + fixed close 44166 28.1 thanks Stefan Kangas writes: > The doc string of `pcase-exhaustive' could be more didactic. It says: > > pcase-exhaustive is a Lisp macro in =E2=80=98pcase.el=E2=80=99. > > (pcase-exhaustive EXP &rest CASES) > > The exhaustive version of =E2=80=98pcase=E2=80=99 (which see). > If EXP fails to match any of the patterns in CASES, an error is signa= led. > >>>From reading the code, I understand that this is the same as pcase, but > signals an error if there is no match? If this is correct, may I > suggest to amend the doc string as follows? > > The exhaustive version of =E2=80=98pcase=E2=80=99 (which see). > If EXP fails to match any of the patterns in CASES, an error is > signaled. > In contrast, `pcase' will only return nil if there is no match. There have been no comments here within a year, so I've now pushed a change like this to master (commit 86837a87b7). > Also, should it be added to the ELisp manual? I guess not. Closing this bug.