From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#73552: obsolete (and broken) face attribute :reverse-video Date: Sun, 29 Sep 2024 06:55:19 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10835"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= , Eli Zaretskii , Stefan Monnier To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 73552@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 29 15:58:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1suuR7-0002cq-Ji for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Sep 2024 15:58:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1suuQt-0000YZ-VL; Sun, 29 Sep 2024 09:57:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1suuQr-0000Xr-B0 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 09:57:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1suuQq-000228-ND for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 09:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=0e3IMGJ6VFa3ASf2JVQ6DhmGeYWAQHSphe0ofWXKdz8=; b=YFnO1etYihyYlQEsxsi4d0B748KmiSc6CDA8zTJvN7oWYXdFkDui3FDqJGhR0m5MZ8IRu3TVYF578koXZnClP2joEvGq6wRvDF/Aqn6Hi3wR5pDAKs5h23zQRz3JRsrHY9eBcNZJkHdgXpSyyVcFg6HFo9WP4ykKb/HDEDo+XT+cmp2oiaUFcnXHKpuL4wJpCOODECGezpeKzZfvzTA40jfR6wSztPTuSY3DCPi8gfxUh7k2U6/fxCDEt+E8vOJ9dKtcFfRiPziQgarCGKLcUCIOJVmpr0m2Xcx8PqoIkb4nGqJm6WGtJuirRMdQQiB2OXN0ANbjWubvQB9Zr+jOFw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1suuRK-0007Mq-T2 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 09:58:22 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2024 13:58:21 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73552 X-GNU-PR-Package: emacs Original-Received: via spool by 73552-submit@debbugs.gnu.org id=B73552.172761827828039 (code B ref 73552); Sun, 29 Sep 2024 13:58:21 +0000 Original-Received: (at 73552) by debbugs.gnu.org; 29 Sep 2024 13:57:58 +0000 Original-Received: from localhost ([127.0.0.1]:40316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1suuQj-0007G8-QZ for submit@debbugs.gnu.org; Sun, 29 Sep 2024 09:57:54 -0400 Original-Received: from [209.85.208.41] (port=42317 helo=mail-ed1-f41.google.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1suuPy-0006zO-7N for 73552@debbugs.gnu.org; Sun, 29 Sep 2024 09:57:35 -0400 Original-Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5c88e45f467so1140358a12.1 for <73552@debbugs.gnu.org>; Sun, 29 Sep 2024 06:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727618120; x=1728222920; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=0e3IMGJ6VFa3ASf2JVQ6DhmGeYWAQHSphe0ofWXKdz8=; b=Ifn+KkQw+Ko7zy4Gv9+fWKS0On5R5G5OV+wJZNdx7dNsgwSLHVWg5c0xwcvGLBEs1N YLKV8QIPe9kUGNJU6kqZ/5u6J2MiYk7+/OlgHw6vcLnNzvgy4poNG/9YQv7BfloNjpft NLrktFgQEX5h82DStwrwRx4yfTBifjv13q7CkxlsUoO9hkTqZDMV7/7TPHcfPbsNCqHI GY6ibNaDkcmT1zZq9jE5wF7G7VNnoXM1+kijxAps0TGiBwuEJMkRqNg7rBfdYE2tezLI XXAi4nOSdwr+X0DdcxK5VHdBDN8MqbGxGK8WktorhAbDU0T02fs5974A/qzXvP1iIRsS GePQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727618120; x=1728222920; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0e3IMGJ6VFa3ASf2JVQ6DhmGeYWAQHSphe0ofWXKdz8=; b=dHTbm4f3wxToNsh8GEcHJ50putgS6G9l7QeRRV+NawrQL7Z2nQD6/NbCPzcyM7guUh AV52+maFStOucNVymLikk3TIv/mMQsafFk4iKjZri/t8WOwvt0fv5wAdsuT1zl0Gn9rd F+82LAJgZiCHCsy0WKYjZ0AMivxbQb7hQG3FZBGJnf7hggCLuPNIlEF5ckV6xZVs0O6O xph2qcfyNh5hP54Dk3FDigZn5uJnRh2/5VgjlUFxK57PHrNHEay7Cao0r7sEHWvOX3x6 a3/xGiaF4jJP6/v8CIYmU9ywlsMofcdMVqstNb3+IgzK+VN0pt5czInsFA/mkpl0svSJ 4nbA== X-Forwarded-Encrypted: i=1; AJvYcCX2AURu/ZHAHye4HI7pt2/W7zDNA0q8jsJ5XB36V6gxmPwCsNpdMFLOaAQwm0Nt4kQ/yzJeHA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz0KxfyWiwAbcJdZusakifSADU5l/HLQk9BRsIKQASzX7t8hPUw 1Sv68CUz2BrpbEPBRrzAqDgvX3UpVLH2/y8V05vtGvQczNbGcXlcYQo3/cs1KYNcksPW94WPofr TUygbr3WvT+wYnBYQqetUXLNzwdo= X-Google-Smtp-Source: AGHT+IG7GXV51j3+F7yuxhATGTib7YXzxr0OfzdyECC1vIJbu6ckOETjxRnFAZrMYwJU6/6C120sQ3ZTK6OwutVf1Us= X-Received: by 2002:a05:6402:430e:b0:5c6:3ebf:5c10 with SMTP id 4fb4d7f45d1cf-5c882455ae7mr11597618a12.10.1727618120321; Sun, 29 Sep 2024 06:55:20 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 29 Sep 2024 06:55:19 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292641 Archived-At: Mattias Engdeg=C3=A5rd writes: > I first blamed a simple 14 years old mistake in `custom-fix-face-spec` > but fixing that doesn't help, not sure why. But it means that we > probably don't need to fix it, and indeed there are precious few > packages using :reverse-video. One is make-mode.el; outside Emacs, I > only found one (yaml-mode). I suggest fixing this in make-mode.el to avoid the warning. > While :bold and :italic are obsolete as well, they are used a lot more > (and actually seem to work) so I'm not warning about them now. We could start by doing s/:bold t/:weight bold/ and s/:italic t/:slant italic/ in our tree. > To summarise: > - Should we fix `custom-fix-face-spec`? Maybe, or just stop pretending th= at it handles :reverse-video. > - Should we bother to fix what other mechanism preventing :reverse-video = from working? Probably no. > - Should we remove :reverse-video from the display machinery? Yes, but ma= ybe not now? It doesn't seem worth fixing :reverse-video at this point, indeed. I suggest removing it, given that it's been broken for so long and that we now have a warning instead. > - Should we remove :bold and :italic? Yes, but definitely not now. I'd propose adding obsoletion warnings for :bold and :italic. I note that they are not documented in the elisp manual.