bug#66971: 30.0.50; [PATCH] Invert for flashing

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]


Hi,

Maybe that's just me (or the theme I'm using) but when there is
antialiasing involved, the visible flashing produces rather ugly glyphs.

It is much more pleasing with this patch.  Or maybe, we need a user
custom for it.  WDYT?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Just-invert-destination-for-flashing.patch --]
[-- Type: text/x-patch, Size: 986 bytes --]

From be50297d437e7cd42e89f0fb7f4b4ef233db7dbf Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Mon, 6 Nov 2023 17:12:01 +0100
Subject: [PATCH] Just invert destination for flashing

* src/xterm.c (XTflash): Use invert for flashing.
---
 src/xterm.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/xterm.c b/src/xterm.c
index d01c4da0564..31892f22690 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -11435,12 +11435,9 @@ XTflash (struct frame *f)
 
   if (FRAME_X_VISUAL_INFO (f)->class == TrueColor)
     {
-      values.function = GXxor;
-      values.foreground = (FRAME_FOREGROUND_PIXEL (f)
-			   ^ FRAME_BACKGROUND_PIXEL (f));
+      values.function = GXinvert;
 
-      gc = XCreateGC (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
-		      GCFunction | GCForeground, &values);
+      gc = XCreateGC (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), GCFunction, &values);
     }
   else
     gc = FRAME_X_OUTPUT (f)->normal_gc;
-- 
2.42.0

[-- Attachment #3: Type: text/plain, Size: 6846 bytes --]



In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.4) of 2023-11-06
 built on computer
Repository revision: be50297d437e7cd42e89f0fb7f4b4ef233db7dbf
Repository branch: mgi/blink
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: OpenBSD computer 7.4 GENERIC.MP#0 amd64

Configured using:
 'configure CC=egcc MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --exec-prefix=/home/manuel --with-x-toolkit=no --without-cairo
 --without-dbus --without-gconf --without-gsettings --without-sound
 --without-compress-install'

Configured features:
FREETYPE GIF GLIB GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES
NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER
WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB

Important settings:
  value of $LC_CTYPE: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Dired

Minor modes in effect:
  gnus-dired-mode: t
  display-time-mode: t
  display-battery-mode: t
  server-mode: t
  override-global-mode: t
  repeat-mode: t
  savehist-mode: t
  desktop-save-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/manuel/.emacs.d/elpa/ef-themes-1.4.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs

Features:
(shadow sort mail-extr wdired misearch multi-isearch emacsbug
smerge-mode diff whitespace org-duration org-agenda sh-script smie
treesit executable vc-cvs vc-rcs log-view pcvs-util emacs-authors-mode
org-indent oc-basic org-element org-persist org-id avl-tree ol-eww eww
url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect
ol-docview doc-view image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m
ol-doi org-link-doi gnus-icalendar org-capture org-refile org ob
ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint
org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp
ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys
oc org-loaddefs org-version org-compat org-macs mule-util jka-compr
on-screen paredit gnus-dired autorevert filenotify make-mode vc-hg
conf-mode vc-dir ewoc vc-git diff-mode vc vc-dispatcher bug-reference
time battery cus-load exwm-randr xcb-randr exwm-config ido exwm
exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor
xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb
xcb-xproto xcb-types xcb-debug server ef-summer-theme ef-themes
modus-operandi-theme modus-themes zone speed-type url-http url-auth
url-gw nsm compat ytdious mingus libmpdee reporter edebug debug
backtrace transmission color calc-bin calc-ext calc calc-loaddefs rect
calc-macs supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu
mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill
kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus
gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int
gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg
rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231
rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win ebdb-mua
ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage
dframe find-func eieio-base pcase timezone icalendar gnus nnheader
gnus-util mail-utils range mm-util mail-prsvr wid-edit visual-basic-mode
cl web-mode derived disp-table erlang-start smart-tabs-mode skeleton
cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine
cc-vars cc-defs slime-asdf grep slime-tramp tramp rx trampver
tramp-integration files-x tramp-message tramp-compat xdg shell pcomplete
parse-time iso8601 time-date format-spec tramp-loaddefs slime-fancy
slime-indentation slime-cl-indent cl-indent slime-trace-dialog
slime-fontifying-fu slime-package-fu slime-references
slime-compiler-notes-tree advice slime-scratch slime-presentations
bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context
slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c
slime-editing-commands slime-autodoc slime-repl slime-parse slime
apropos compile text-property-search etags fileloop generator xref
project arc-mode archive-mode noutline outline icons pp comint ansi-osc
ansi-color ring hyperspec thingatpt slime-autoloads edmacro kmacro
use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu
calendar cal-loaddefs dired-x dired-aux dired dired-loaddefs
notifications dbus xml cl-extra help-mode use-package-core repeat
easy-mmode savehist desktop frameset debbugs-autoloads ebdb-autoloads
ef-themes-autoloads exwm-autoloads hyperbole-autoloads magit-autoloads
git-commit-autoloads finder-inf magit-section-autoloads dash-autoloads
on-screen-autoloads osm-autoloads paredit-autoloads rust-mode-autoloads
speed-type-autoloads transmission-autoloads with-editor-autoloads info
compat-autoloads ytdious-autoloads package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt
fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode
register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads kqueue lcms2 dynamic-setting font-render-setting xinput2 x
multi-tty move-toolbar make-network-process emacs)

Memory information:
((conses 16 774061 172874) (symbols 48 53736 2)
 (strings 32 176156 9038) (string-bytes 1 5540049) (vectors 16 106081)
 (vector-slots 8 2168684 207892) (floats 8 523 330)
 (intervals 56 27844 62) (buffers 992 103))

-- 
Manuel Giraud

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> Hi,
>
> Maybe that's just me (or the theme I'm using) but when there is
> antialiasing involved, the visible flashing produces rather ugly glyphs.
>
> It is much more pleasing with this patch.  Or maybe, we need a user
> custom for it.  WDYT?

(Disclaimer: I have not tried the patch.)

The introduction of new user options which affect the visible bell on
one window system must be attended by comparable modifications to all
the others, which is infeasible inasmuch as other window systems don't
provide straightforward mechanisms for inverting the contents of a
window.

While the last sentence is not directly relevant to the patch itself,
I'm for leaving the code as it is; the present state of affairs has
withstood the test of time, and it would be unwise to change it by
caprice.

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Po Lu <luangruo@yahoo.com> writes:

> Manuel Giraud <manuel@ledu-giraud.fr> writes:
>
>> Hi,
>>
>> Maybe that's just me (or the theme I'm using) but when there is
>> antialiasing involved, the visible flashing produces rather ugly glyphs.
>>
>> It is much more pleasing with this patch.  Or maybe, we need a user
>> custom for it.  WDYT?
>
> (Disclaimer: I have not tried the patch.)
>
> The introduction of new user options which affect the visible bell on
> one window system must be attended by comparable modifications to all
> the others, which is infeasible inasmuch as other window systems don't
> provide straightforward mechanisms for inverting the contents of a
> window.

You're right and I won't be able to test (or even implement) for other
window systems.  Or why not have a 'x-...' specific user option.

> While the last sentence is not directly relevant to the patch itself,
> I'm for leaving the code as it is; the present state of affairs has
> withstood the test of time, and it would be unwise to change it by
> caprice.

Yes but I wonder if I'm the only one seeing this (I'll try to capture
some screenshots of those flashing).  It might be a just configuration
problem.
-- 
Manuel Giraud

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> You're right and I won't be able to test (or even implement) for other
> window systems.  Or why not have a 'x-...' specific user option.

I think a proliferation of such options is likely to prove detrimental
in the long run.  There are already far too many.

> Yes but I wonder if I'm the only one seeing this (I'll try to capture
> some screenshots of those flashing).  It might be a just configuration
> problem.

Sure, please do that.

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

Po Lu <luangruo@yahoo.com> writes:

[...]

>> Yes but I wonder if I'm the only one seeing this (I'll try to capture
>> some screenshots of those flashing).  It might be a just configuration
>> problem.
>
> Sure, please do that.

So here is the top of my window (themed with ef-summer) in neutral
state:

[-- Attachment #2: themed-neutral.png --]
[-- Type: image/png, Size: 19772 bytes --]

[-- Attachment #3: Type: text/plain, Size: 43 bytes --]


The same space flashed with current code:

[-- Attachment #4: themed-flash-current.png --]
[-- Type: image/png, Size: 19974 bytes --]

[-- Attachment #5: Type: text/plain, Size: 35 bytes --]


Same but flashed with this patch:

[-- Attachment #6: themed-flash-invert.png --]
[-- Type: image/png, Size: 19852 bytes --]

[-- Attachment #7: Type: text/plain, Size: 73 bytes --]


Note that this much less of a trouble with no theme and black on white:

[-- Attachment #8: not-themed-flash-current.png --]
[-- Type: image/png, Size: 21692 bytes --]

[-- Attachment #9: not-themed-flash-invert.png --]
[-- Type: image/png, Size: 21620 bytes --]

[-- Attachment #10: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Stefan Kangas]

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
> [...]
>
>>> Yes but I wonder if I'm the only one seeing this (I'll try to capture
>>> some screenshots of those flashing).  It might be a just configuration
>>> problem.
>>
>> Sure, please do that.
>
> So here is the top of my window (themed with ef-summer) in neutral
> state:
>
> x
>
>
> The same space flashed with current code:
>
> x
>
>
> Same but flashed with this patch:
>
> x

I can see that effect here too.  I don't think we need a user option for
this, it just looks like a plain bug that should be fixed.

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

[...]

> I can see that effect here too.  I don't think we need a user option for
> this, it just looks like a plain bug that should be fixed.

Thanks.  What do you think of my patch then?
-- 
Manuel Giraud

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Stefan Kangas]

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> I can see that effect here too.  I don't think we need a user option for
>> this, it just looks like a plain bug that should be fixed.
>
> Thanks.  What do you think of my patch then?

The current behaviour seems suboptimal, so if it works and there aren't
any other problems with it, then I don't see why we shouldn't install
it.

Let's wait to see if anyone else has anything to add.

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

> Let's wait to see if anyone else has anything to add.

Only that follow-ups from this thread always run afoul of the mail
delivery issues my provider suffers from :-(

Please postpone installing this patch until I get around to testing it
on a few X servers besides Xsun and Xorg.

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Po Lu <luangruo@yahoo.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Let's wait to see if anyone else has anything to add.
>
> Only that follow-ups from this thread always run afoul of the mail
> delivery issues my provider suffers from :-(
>
> Please postpone installing this patch until I get around to testing it
> on a few X servers besides Xsun and Xorg.

Hi Po,

Did you happen to have time to test this issue on other X servers?
Thanks.
-- 
Manuel Giraud

bug#66971: 30.0.50; [PATCH] Invert for flashing

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

close 66971 30.0.50
thanks

Thanks for it Po.  I'm therefore closing this bug.
-- 
Manuel Giraud