From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68684: [PATCH] dictonary.el documentation Date: Thu, 25 Jan 2024 15:29:33 -0800 Message-ID: References: <8734uof4m4.fsf@gmail.com> <878r4frl79.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16184"; mail-complaints-to="usenet@ciao.gmane.io" Cc: torsten.hilbrich@gmx.net, 68684@debbugs.gnu.org, iarchivedmywholelife@gmail.com To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 26 00:30:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rT9Aq-00040C-5t for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Jan 2024 00:30:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rT9AU-0005qc-I2; Thu, 25 Jan 2024 18:29:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rT9AT-0005qE-80 for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 18:29:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rT9AS-0004Qi-Ve for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 18:29:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rT9AZ-0005QR-0C for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 18:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 23:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68684 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68684-submit@debbugs.gnu.org id=B68684.170622538820809 (code B ref 68684); Thu, 25 Jan 2024 23:30:02 +0000 Original-Received: (at 68684) by debbugs.gnu.org; 25 Jan 2024 23:29:48 +0000 Original-Received: from localhost ([127.0.0.1]:49585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT9AJ-0005PY-Iz for submit@debbugs.gnu.org; Thu, 25 Jan 2024 18:29:47 -0500 Original-Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:47615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT9AH-0005PM-Vp for 68684@debbugs.gnu.org; Thu, 25 Jan 2024 18:29:46 -0500 Original-Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-55ad2a47b7aso6961185a12.3 for <68684@debbugs.gnu.org>; Thu, 25 Jan 2024 15:29:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706225374; x=1706830174; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=s9T0bLyUgW6X+q7/SUQ7NeTVKBaU77ubq98V+2hF2pQ=; b=bE/suchlC203Jnw90tY0RNHAKOxXFx6PhHIT4n7LzmtMulouUQbRkbFoXsXkCVMPa+ VPzZ0LzNBMhmU7GBIyem3ORDn5Zp58vLiaQSA10E9srDPanSFqMC+IW0/VEX6JISYlD/ 2V5AZm4YVK7hPV1MAoD3bBhtD9wLmt8g/dRAJfkTo1KAG7cHIAztPLO84+QpCmoUQSyf NHEGJFheDn7ti+3ABGRxt4qNmjRA4XGL9qz1xD1w+RiXr9tn71ytvqryCCen80IQAGYq 02b3StiDclyJU3lxxg2FJdXhXtR5q7PpRRUZm+hJGcn+xTG45HDlgCifCTQ03yvYqtX8 kx1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706225374; x=1706830174; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s9T0bLyUgW6X+q7/SUQ7NeTVKBaU77ubq98V+2hF2pQ=; b=eXYKG2fp1ZzoGS70VYge8nidx12hls+SGtyCNOLxyiKegRw6v+WH11/mvgiw18mxBA FFsgdpD1OBSvtCFy4MQcyZFYsxoLh3TYyf0PQK6YvTB1f7xH4L2BPtNr1OUCX69MUYQ4 Fw7/cydFvuimJlgj7oFtw2h8IZ51QMCgXrGzPArPtQUrNzMXfBnzs47R3AxbHH9P3Qt+ b4s0uHzeSxHpThz3jVnck1qIhzOjo+TVmsBH1VUhUu7+G0Azmwqxjs9okBnRHbHQg8KE ohhP7Ja7aZtryTp58CITDJZsc934LSEaenUTG1+0AKoBADvfDZMxawJFIHpwVSCYqNiZ cxbg== X-Gm-Message-State: AOJu0YxYT6FePMcWdWyDulydad49ISylqSR2GAsSOcuxhqbKXQ0jqfRf Ar/DhB7N6uCBBk/A0/vkFLw+ojpCRwjTxoRo+ayYLW7+5A9fvZ8SibanILKbasi+Ry94dN3QsAE OCc2OdGov5d6L3/t4THVK0FEE8UQ= X-Google-Smtp-Source: AGHT+IG2TPSUxkX/qAD6HhVWG5GJyAFuNFpxo/EZvr2MWDpyVDGDDOIJNoCuO+vXaFzCBM7R9Hx2cGUFYczTslrrKHo= X-Received: by 2002:a05:6402:22ce:b0:55a:70cf:26d5 with SMTP id dm14-20020a05640222ce00b0055a70cf26d5mr119210edb.48.1706225373896; Thu, 25 Jan 2024 15:29:33 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 25 Jan 2024 15:29:33 -0800 In-Reply-To: <878r4frl79.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278877 Archived-At: Po Lu writes: > Thanks. Nowayman, we cannot install this as-is, since the formatting > of the commit message does not meet our standards. Well, I'm happy to fix it up and install it. I assume you reviewed it, so do you see any other problems with the patch? Skimming it very quickly, it looked like a fine contribution to me. > fewer than 64 columns. ChangeLogs should fit within 80 columns prefixed with a tab, so that should be 72 columns. > I find that a surprising number of individuals cannot produce > correctly formatted entries on the first attempt. Is the layout of > our documentation part of the problem? I think it's the format that's the problem. It's archaic and foreign to most developers. There's not much to do about it, I think. > correcting improperly formatted patches individually gets old fast. I find that it's generally more time-effective to just fix up patches when installing them, and then say something like: Installed. I changed the commit message to better fit our conventions, please have a look for next time. Usually, people will be more appreciative of that than long lists enumerating every dot and comma that they got wrong.