unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 41328@debbugs.gnu.org
Subject: bug#41328: [PATCH] Declare some ancient compat aliases obsolete
Date: Mon, 27 Jul 2020 13:26:47 +0200	[thread overview]
Message-ID: <CADwFkmmh9B371YTFn4_Q1paSJCUEUCRTZJB1=3Qc4yb01Z8UQQ@mail.gmail.com> (raw)
In-Reply-To: <87pn8hurre.fsf@tcd.ie>

Basil L. Contovounesios <contovob@tcd.ie> writes:

> No objections from me, just one question:
>
> > diff --git a/lisp/progmodes/inf-lisp.el b/lisp/progmodes/inf-lisp.el
> > index 9f34a377f4..7447c25fc0 100644
> > --- a/lisp/progmodes/inf-lisp.el
> > +++ b/lisp/progmodes/inf-lisp.el
> > @@ -134,6 +134,7 @@ lisp-mode-map
> >  ;;;  (with-eval-after-load 'inf-lisp 'inferior-lisp-install-letter-bindings)
> >  ;;;You can modify this function to install just the bindings you want."
> >  (defun inferior-lisp-install-letter-bindings ()
> > +  (declare (obsolete nil "28.1"))
> >    (define-key lisp-mode-map "\C-ce" 'lisp-eval-defun-and-go)
> >    (define-key lisp-mode-map "\C-cr" 'lisp-eval-region-and-go)
> >    (define-key lisp-mode-map "\C-cc" 'lisp-compile-defun-and-go)
>
> What makes this an "ancient compat" or obsolete function?

Thanks for the review.  I initially had that impression from reading
the comments, but I have changed my mind since sending the patch.  I
think it's fair to say that some users might legitimately still use
it.  I'm therefore taking this part out.

Best regards,
Stefan Kangas





  reply	other threads:[~2020-07-27 11:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16 16:08 bug#41328: [PATCH] Declare some ancient compat aliases obsolete Stefan Kangas
2020-07-27 11:22 ` Basil L. Contovounesios
2020-07-27 11:26   ` Stefan Kangas [this message]
2020-07-31  4:07     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmh9B371YTFn4_Q1paSJCUEUCRTZJB1=3Qc4yb01Z8UQQ@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=41328@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).