From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41998: case nil in load-path not handled in function read-library-name Date: Thu, 13 Aug 2020 10:36:52 -0700 Message-ID: References: <559250595.465596.1592802115447@email.ionos.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22463"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41998@debbugs.gnu.org To: Tobias Zawada Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 13 19:37:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6HAB-0005m5-8l for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 19:37:15 +0200 Original-Received: from localhost ([::1]:50584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6HAA-0004I8-8X for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 13:37:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6H9y-0004Gc-ID for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 13:37:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39407) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6H9y-0000e2-9E for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 13:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6H9y-00080j-4E for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 13:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Aug 2020 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41998 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41998-submit@debbugs.gnu.org id=B41998.159734021930785 (code B ref 41998); Thu, 13 Aug 2020 17:37:02 +0000 Original-Received: (at 41998) by debbugs.gnu.org; 13 Aug 2020 17:36:59 +0000 Original-Received: from localhost ([127.0.0.1]:50953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6H9v-00080T-Fv for submit@debbugs.gnu.org; Thu, 13 Aug 2020 13:36:59 -0400 Original-Received: from mail-yb1-f196.google.com ([209.85.219.196]:34298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6H9u-000808-Fp for 41998@debbugs.gnu.org; Thu, 13 Aug 2020 13:36:58 -0400 Original-Received: by mail-yb1-f196.google.com with SMTP id c9so3751190ybq.1 for <41998@debbugs.gnu.org>; Thu, 13 Aug 2020 10:36:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=kdlP0nBh2Xe0l/cGOE51Vu6CAZlbk4bS3EhWOReOIZw=; b=XeROk99u0ZcR3k37Qyzzh3YQLT8zXeYcmpKuDaPz5LYim/AZqHWmu43vdm56KMcXa3 OMmQXV1WPJgddSi60eHCRgs4yiP+EJl0NdCaeQDn9mtRntmnKrihyQsv8GXhc6sKqq3g 4yEvTq6cSbcAcCZIpO4ST1S26MKLi/rb0fWhPs/4reclGWFCSulipL7+7aS5vmcJgcGG 89yiGtZ/IF8YWi6neq2+n/1JB8c3Sbg79FTXo1xy4t58dgExQcrpyrIsHJtRxEWbiOoz HIUObMJJjBan+JZC0DAthlYBl5zlpvEdRIWMYWTUVf2wzO2AbqLhA9/swLGQC34ANH1R oAsg== X-Gm-Message-State: AOAM530FGn61CVI66FwWzJ9UYOTLJbzgBZI2FMAEhg5BgbL251DhNBqt 41B3EuQEt/J5Trt5zwIgmbSZQILcl21va43Hm/0= X-Google-Smtp-Source: ABdhPJyjXz958n/gfqcwO5WndksITp8vyn5V+uRHH3eCeiCaWX+EVyUjhbbt/NL028y8IdQz355vcdrgcxcKfNRLgeE= X-Received: by 2002:a5b:410:: with SMTP id m16mr8055083ybp.309.1597340212867; Thu, 13 Aug 2020 10:36:52 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Aug 2020 10:36:52 -0700 In-Reply-To: <559250595.465596.1592802115447@email.ionos.de> (Tobias Zawada's message of "Mon, 22 Jun 2020 07:01:55 +0200 (CEST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185051 Archived-At: close 41998 28.1 thanks Tobias Zawada writes: > Version: 28.0.50, commit 2c4509179110459f42119ce328d72fea65689288 > > Variable `load-path' admits nil as entry standing for `default-directory'. > This case is not handled in function `read-library-name' of library `lisp/emacs-lisp/find-func.el'. To reproduce: 0. cd ~/some-path-with-elisp-files/ 1. emacs -Q 2. Evaluate: (progn (add-to-list 'load-path nil) (with-temp-buffer (insert "library") (read-library-name))) And you will get an error. > Diff that fixes this problem: > > diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el > index e35db56550..4498a50f90 100644 > --- a/lisp/emacs-lisp/find-func.el > +++ b/lisp/emacs-lisp/find-func.el > @@ -292,12 +292,13 @@ read-library-name > (find-library-suffixes) > "\\|")) > (table (cl-loop for dir in (or find-function-source-path load-path) > - when (file-readable-p dir) > + for dir-or-default = (or dir default-directory) > + when (file-readable-p dir-or-default) > append (mapcar > (lambda (file) > (replace-regexp-in-string suffix-regexp > "" file)) > - (directory-files dir nil > + (directory-files dir-or-default nil > suffix-regexp)))) > (def (if (eq (function-called-at-point) 'require) > ;; `function-called-at-point' may return 'require Thanks for the bug fix. I've added a commit message and ChangeLog entry and pushed it to master branch in your name. One small thing: it would be helpful if you could send your next patch as formatted by `git format-patch' and with a ChangeLog entry as described in the CONTRIBUTE file in emacs.git. I'm closing this bug with this message. Best regards, Stefan Kangas