From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#72915: Docstrings of add-hook and remove-hook improvement? Date: Sat, 14 Sep 2024 09:31:41 -0400 Message-ID: References: <87v7zgrhrt.fsf@posteo.net> <86y14c9dk3.fsf@gnu.org> <87plpnqstj.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31143"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72915@debbugs.gnu.org To: Tomas Nordin , Eli Zaretskii , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 14 15:33:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1spStj-0007vT-D9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Sep 2024 15:33:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spStS-000400-AA; Sat, 14 Sep 2024 09:32:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spStQ-0003zk-4O for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 09:32:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spStP-0004BS-O8 for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 09:32:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=XLPkc+5V0cNRqQy1o2dUc9g1uNorBNLVgtL+yrZOcRU=; b=oVVhNK+/5W6lgVnEVsbs4ug36QgETP0/Eu/D52DLEH2eyd9VhAyO4IXHek1SCIqT9ujBoNXkRvRXnaJVRPwqEFYFQckxyu/jQsQ+hb2k94XoWXi8tJpKDKOZO847Qy2fmqEUppt+rPw/Xv59HxQIqw6XT0aXGVNrJq5/wspMXct0IqStG+sotL5v2v9oaD4Ur56TuWNs5tS7qQl5k9A2j8FsVQGSgkXLGMI8tvOhjBtBkIl+j+kgTG3xDsNvHOffBrnAWUJaGAvoOdMWDYLsrGXx0BZjVI5LenFch3NxLkIvIT8rVLnLXtIoSBbfeskt3WPMrM7QFrq3jIw5LtJ2AQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1spSta-0006QI-6D for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 09:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2024 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72915 X-GNU-PR-Package: emacs Original-Received: via spool by 72915-submit@debbugs.gnu.org id=B72915.172632078024681 (code B ref 72915); Sat, 14 Sep 2024 13:33:02 +0000 Original-Received: (at 72915) by debbugs.gnu.org; 14 Sep 2024 13:33:00 +0000 Original-Received: from localhost ([127.0.0.1]:45126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spStY-0006Pz-Iy for submit@debbugs.gnu.org; Sat, 14 Sep 2024 09:33:00 -0400 Original-Received: from mail-ed1-f43.google.com ([209.85.208.43]:47244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spStW-0006Pa-GG for 72915@debbugs.gnu.org; Sat, 14 Sep 2024 09:32:59 -0400 Original-Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5c4226a56a8so1658812a12.2 for <72915@debbugs.gnu.org>; Sat, 14 Sep 2024 06:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726320702; x=1726925502; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=XLPkc+5V0cNRqQy1o2dUc9g1uNorBNLVgtL+yrZOcRU=; b=m95SedJzF7u08uPcO9ZvuwKZOIlTkzAk8JNkkUVOXD5USaImWorBakaIvOHG59YcEG rGunOJv51nrmNpFaHfP4ngNiHaSqGFZ4PS4Vmg3akvG7nyNSNYwy2ZRPqqNwfmcn1QF8 wiWJxG6Fc2PF2pAPvsuAxQUyLwCF6kMpm5X2TNMpvtognZr0/VenEjOdfDot+uajoIgM h2fRyyJekSmkuYsd50ewfWr4bWH4tRtROgSmaXQw56pGEGh2zooa2eC/MQxJNDth7Q/a bg0/qdquBNOgjB2WcMvi1zha2Ogh50PwEowIaZRBxheDoi16TSsFf0WUYPs9ZVQW84V5 iqgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726320702; x=1726925502; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XLPkc+5V0cNRqQy1o2dUc9g1uNorBNLVgtL+yrZOcRU=; b=EXeBNOI36f/QBCweSrmWQkEQhk0NxK50ktuIH02Owpf6VIPAG42pLGm0ehCISy89T6 7jkqmqP/XATmNI5xWz1ZBFisuwM/ZK+cPhwUDnnCvXIdCiiyDXDDHmXKBfQ4EdzMFXUU aLls+/bYdYX6JaUQLHl4Vc5xi2XzGYaCTwfY7TgJtoDQfK32q2NL6aVPfWs+oKKYB/A9 WSBa/m09ACyTNoZT5jGJZdLvWdHqSpG/dOjctZWUR2Ne1Q1bE32HI/NXHtpZ88Xqz53G r7mnW9zE1NmVTwHPib3ACWtLy56luVcwFZecgO6U7aryV/JWcL07VQZCNIbQOI7zVMUR hKOA== X-Gm-Message-State: AOJu0Yx0Anin+KPrdTp/+B64ZxujXvVNZX0Xed3bBHMUZf/AzFblD9n3 q0uVR637rsbxhYTa4Dru8LSMxisMdixEgtr+RSRqAFYTQVGh/Iu7rMQPchbhyJrRwH8KgbH+0zL G6MQ/geJU4HPHeg8f7FoRIw94Hqw= X-Google-Smtp-Source: AGHT+IFDAtGAE2SVIIPCvxONGCT1pZQs+9XVa6+nkWuF9yN0eSlgllPP7mW8FHZh3FmgL7PaK9VWE5sIw7XTi3IRovs= X-Received: by 2002:a05:6402:295:b0:5c2:7727:6109 with SMTP id 4fb4d7f45d1cf-5c413e53f72mr6180428a12.30.1726320701608; Sat, 14 Sep 2024 06:31:41 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 14 Sep 2024 09:31:41 -0400 In-Reply-To: <87plpnqstj.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291743 Archived-At: Tomas Nordin writes: > Stefan Kangas writes: > >> Stefan Kangas writes: >> >>> The wording in the manual is probably all that is needed here: >>> >>> This function removes FUNCTION from the hook variable HOOK. >> >> BTW. Here's another idea: >> >> If HOOK is a list of functions, remove FUNCTION from that list. >> >> If HOOK is equal to FUNCTION, set HOOK to nil. >> >> Otherwise do nothing. > > I like that, adjusted maybe to respect Stefan M's nitpick: > > If HOOK's value is a list of functions, remove FUNCTION from that list. > If HOOK's value is FUNCTION, set HOOK to nil. > Otherwise do nothing. Stefan M, does Tomas' edited version look okay to you?