From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#62677: 30.0.50; Need to find a better name for flyspell-prog-mode Date: Wed, 6 Sep 2023 11:51:14 -0700 Message-ID: References: <87mt3mv5e9.fsf@web.de> <076460cb-f203-de49-c949-bdc213fd1965@gmail.com> <83y1n5r0i9.fsf@gnu.org> <83o7if35x5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, jporterbugs@gmail.com, 62677@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 20:52:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdxda-0005Xc-GZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 20:52:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdxdF-0003ob-Vq; Wed, 06 Sep 2023 14:52:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdxdB-0003nr-6a for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 14:52:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdxdA-0006H0-Um for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 14:52:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdxdC-0004nr-3s for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 14:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62677 X-GNU-PR-Package: emacs Original-Received: via spool by 62677-submit@debbugs.gnu.org id=B62677.169402628418406 (code B ref 62677); Wed, 06 Sep 2023 18:52:02 +0000 Original-Received: (at 62677) by debbugs.gnu.org; 6 Sep 2023 18:51:24 +0000 Original-Received: from localhost ([127.0.0.1]:37714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdxcZ-0004mo-U0 for submit@debbugs.gnu.org; Wed, 06 Sep 2023 14:51:24 -0400 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:54602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdxcY-0004mY-6A for 62677@debbugs.gnu.org; Wed, 06 Sep 2023 14:51:22 -0400 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50078e52537so159113e87.1 for <62677@debbugs.gnu.org>; Wed, 06 Sep 2023 11:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026275; x=1694631075; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=FPNESlGRq+O2V8I5lDz/IbEWYRgYCLHiQHceJt7tAuM=; b=BeP4CuN7fb6LhgJrbgsPWxwnKvbRxOfDjaqXeulMsB3BB2sOMHCUH1DUdBgmywK0rK F7XBjwEITYTewgRUO95wI7ElIO+AI67G+59S+ecx2IcqWpzEvZ/Xm5q20ClSCpaqtEcT Kri9hP5Hn4dYb4ZFP3SUVs8kheWfY+tQjA7TJNPSIXv/2sUpLlOx1zTCS0R7FPwsKrLl b7zJ4QW7st3VubwtS8C0NgXEvHnt4mcgKEBIZOCWN5dk+fAjK29qZVRvVupzfDw2+3ZU zmmemU/fg0FmoQXK7icV+gJFF6naBnv4TPW7y0jolnEQ+0366n269Mi7ja1EGCydl+bj /u9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026275; x=1694631075; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FPNESlGRq+O2V8I5lDz/IbEWYRgYCLHiQHceJt7tAuM=; b=bS2HFWmApCaeyzY25AuYNSQ0WHS94aLWsbhI+873sSoXkQGF/JsC5yQdczQLE14ZR3 cJSHVS7FzN4+7WOjcd9Ov1YgK7jC/QySn3B0EhbForiN71SrYkIQrZ4es61OHcYSa2Ug u1ZYH/FLLxZNkHBIaJruc5zfv96IBNsMoZLGzsMGgU3GnKexs+A1OX/OoA49X0b4zV7T qgD8COse5OlX1w2NAdkRWR24Mtn2Vp/nZ/XXG+JcUe3fqtY7Ujq4Vcx+Y6vakw/fkNzq R0BeZzmqVlHFP/s+cC4BWXCSiQ+x1Gl0JXTX9myGSOH6s4tKBU5Q5lusI5SUXICcp0bj 4gZw== X-Gm-Message-State: AOJu0Yx2QSHLHRRt41GvrX+RYnFUKBBnKpm92R9XIjsgxxiwMaWmas0V Fh7h2HXRsoYA0P2cI/KckpesSLHSPsgJ45bdMfWg81UEXV0= X-Google-Smtp-Source: AGHT+IHBD3wrJPHhX4wnxNr5DEqnoVZmVt9Y78d3PsN1ctS0jXjvZlCfvrJj/IeHHmzP/qzTZA8rGTo7j7AeFu8VVgA= X-Received: by 2002:a05:6512:450:b0:4f8:ff52:93b7 with SMTP id y16-20020a056512045000b004f8ff5293b7mr2471207lfk.30.1694026274772; Wed, 06 Sep 2023 11:51:14 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 6 Sep 2023 11:51:14 -0700 In-Reply-To: <83o7if35x5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269571 Archived-At: retitle 62677 Merge flyspell-mode with flyspell-prog-mode tags 62677 + easy thanks Eli Zaretskii writes: >> I'm not sure why I can't just enable `flymake-mode' and have it do the >> right thing, which IMO would be to enable `flymake-prog-mode' in modes >> where it might make sense to have that behavior. Major modes can tell >> us what makes sense themselves, and if there are modes where the >> decision is not clear-cut, they could make it into a user option. >> >> Enabling something like `flymake-global-mode' and have it just work >> would be pretty neat. > > I guess you mean flyspell-mode. > > Yes, having the command automatically DTRT is always best. So if we > can do that in at least some significant proportion of cases, I think > we should. I took a look, and it seems like it would be a relatively straightforward addition to `flyspell-mode'. I'm adding the tag "easy", as this seems like a pretty good introductory project. Here's the plan I'd propose: Add a new defvar-local `flyspell-use-prog-mode' or somesuch that major modes can set. Now, when a user enables `flymake-mode' in a buffer where that variable is non-nil, the extra stuff done in `flyspell-prog-mode' gets done too. Then decide which built-in major modes that would benefit, and set that variable in them. Would `prog-mode' be a candidate though, or do we expect any modes inheriting from it to want the regular `flyspell-mode'?