unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 38072@debbugs.gnu.org, pogonyshev@gmail.com,
	monnier@iro.umontreal.ca, akrl@sdf.org
Subject: bug#38072: when `byte-compile-file' finds out that a file is `no-byte-compile', it ignores `load' parameter
Date: Tue, 20 Oct 2020 16:56:07 +0000	[thread overview]
Message-ID: <CADwFkmmYJCxf4edbkCUjKwEq3mu_GhGdaR5j_ajkLKsjfK9cZg@mail.gmail.com> (raw)
In-Reply-To: <835z86y26v.fsf@gnu.org>

close 38072 28.1
thanks

Eli Zaretskii <eliz@gnu.org> writes:

>> > We cannot just remove it.  We should document that it's deprecated and
>> > use advertised-calling-convention to advertise the signature without
>> > it (which will also produce a warning about using the argument in some
>> > situations).
>>
>> How about the attached patch?
>
> OK, but I'd prefer not to rename the argument itself, as that would
> get in the way of understanding the code.

Thanks, so I fixed that and pushed to master as commit 4a575eb18c.





      reply	other threads:[~2020-10-20 16:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 20:58 bug#38072: when `byte-compile-file' finds out that a file is `no-byte-compile', it ignores `load' parameter Paul Pogonyshev
2020-09-05  0:30 ` Stefan Kangas
2020-09-05  6:21   ` Eli Zaretskii
2020-09-05 15:26     ` Stefan Monnier
2020-09-07 16:37       ` Stefan Kangas
2020-09-07 16:44         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-13 13:06           ` Stefan Kangas
2020-09-13 14:52             ` Eli Zaretskii
2020-09-21 22:30               ` Stefan Kangas
2020-09-22  2:28                 ` Eli Zaretskii
2020-10-20 16:56                   ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmmYJCxf4edbkCUjKwEq3mu_GhGdaR5j_ajkLKsjfK9cZg@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=38072@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=pogonyshev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).