From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file Date: Thu, 12 Jan 2023 17:56:33 -0800 Message-ID: References: <87o7r5ji3q.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26176"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60730-done@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 13 02:57:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pG9Jz-0006dR-MB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Jan 2023 02:57:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pG9JZ-0005bn-2T; Thu, 12 Jan 2023 20:57:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pG9JX-0005bD-3t for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 20:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pG9JW-0002qJ-OX for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 20:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pG9JW-0004IK-KM for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 20:57:02 -0500 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jan 2023 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60730 X-GNU-PR-Package: emacs Mail-Followup-To: 60730@debbugs.gnu.org, stefankangas@gmail.com, jp@neverwas.me Original-Received: via spool by 60730-done@debbugs.gnu.org id=D60730.167357500116472 (code D ref 60730); Fri, 13 Jan 2023 01:57:02 +0000 Original-Received: (at 60730-done) by debbugs.gnu.org; 13 Jan 2023 01:56:41 +0000 Original-Received: from localhost ([127.0.0.1]:48991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG9JB-0004Hc-87 for submit@debbugs.gnu.org; Thu, 12 Jan 2023 20:56:41 -0500 Original-Received: from mail-ot1-f44.google.com ([209.85.210.44]:41783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG9J9-0004HO-Mg for 60730-done@debbugs.gnu.org; Thu, 12 Jan 2023 20:56:40 -0500 Original-Received: by mail-ot1-f44.google.com with SMTP id f88-20020a9d03e1000000b00684c4041ff1so1880910otf.8 for <60730-done@debbugs.gnu.org>; Thu, 12 Jan 2023 17:56:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=/EKkWUiIXTIXVTwZhrA/qtvs2WQzI9F9HUZTlO02Oag=; b=lkdRnVyYe2Fcp3PXO2tV5HNQWgLOCf1bR/ZRH/dedksGNxHSevOVz414A4pa8KP3i4 Fi9DJ+lJN2gfMRsTe4mtgofz0SgZwluk71cOZ2DsMruoXkfU9rBxCVswfr6rmrFoZ1Nm RcrZ/e/zcj9cq7eUXYXZ6JUwRZvunxIkLkGNu2Ca6Xj4btm8MTmMS+B6mM6ThfvPGs8X jWTzhVxxV3xvh5Z4X+7KY0Y8Pt8BfqubNn1sPzAD3jJBws60OmOYvZV1DZ+wkB1IKdQq dGYedrh3KC1In9JkeeW2ceLZhF1g2pm9n7he0MQm1+339K0dFLSBSX4CKIXylt9eeq8o A9JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/EKkWUiIXTIXVTwZhrA/qtvs2WQzI9F9HUZTlO02Oag=; b=afWoCad7xpHcMvFSsDc6eeka9e/pCOW36cf+0cdV3Ic/CrdJheZ+1EWgXNE87/MzyA NAzGNqhvk77pTHV2Fv1LmyUXLNF/kgOxc1+nv/3yj6gWEwGMG6cErhN9XdKhIMsQnHVi x3zeQ+wokCVEF6oXLmudLCavW+B9zP0bJyOI4uhs7JU3Qb28nylZ5RX6FLJzKHAl0Ppp uqbN4CXfTbFxpYtWZhx4ZwiV9JvlX+p5H7Q2QV4XzEv0q/bj4ZVbXgQO99u/Fj33Wiq3 xBpoJbTdbq1SC8zLDa4Af7ZdS67nlGfy6rihismgdMhf3eI82G2q5+rNri3K6udOf5S+ 2Tww== X-Gm-Message-State: AFqh2kprq3+4UutjE1OiNlqSXiCoZim/+Kh9N1p4zFzrVJR8GOtJsAUM yeLT7F7EGCA40FAqesa3fP20zar35q4k348xQPo= X-Google-Smtp-Source: AMrXdXsZFUUQF+ZRc+2c9nGmuHswU/dRc8r03f64YktQ3ryRHIwUNw1KaneXicSX4JkvpEufwpgc5HcQwKXb+zp/9Gw= X-Received: by 2002:a05:6830:1b78:b0:677:9c09:55d1 with SMTP id d24-20020a0568301b7800b006779c0955d1mr3860064ote.224.1673574994030; Thu, 12 Jan 2023 17:56:34 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 12 Jan 2023 17:56:33 -0800 In-Reply-To: <87o7r5ji3q.fsf@neverwas.me> (J. P.'s message of "Wed, 11 Jan 2023 05:50:17 -0800") X-Hashcash: 1:20:230113:60730-done@debbugs.gnu.org::tVHO+mQ7NtlWpypM:278y X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253258 Archived-At: "J.P." writes: > Pretty sure this is just a (functional) typo. [...] > diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el > index 83705ca5b8..7cf60bfeae 100644 > --- a/lisp/emacs-lisp/ert-x.el > +++ b/lisp/emacs-lisp/ert-x.el > @@ -496,7 +496,7 @@ ert-with-temp-file > (progn ,@body) > (ignore-errors > ,@(when buffer > - (list `(with-current-buffer buf > + (list `(with-current-buffer ,buffer > (set-buffer-modified-p nil)) > `(kill-buffer ,buffer)))) > (ignore-errors > > seems to make it go away. Thanks, fixed on emacs-29 (commit f27a330b99e).