From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68246: 30.0.50; Add non-TS mode as extra parent of TS modes Date: Fri, 5 Jan 2024 10:43:11 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25109"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca To: 68246@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 05 19:44:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rLpB7-0006Mu-AS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jan 2024 19:44:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLpAq-0004qZ-EY; Fri, 05 Jan 2024 13:44:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLpAk-0004nY-N9 for bug-gnu-emacs@gnu.org; Fri, 05 Jan 2024 13:43:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLpAk-00028D-Dp for bug-gnu-emacs@gnu.org; Fri, 05 Jan 2024 13:43:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLpAo-0002it-KJ for bug-gnu-emacs@gnu.org; Fri, 05 Jan 2024 13:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jan 2024 18:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68246 X-GNU-PR-Package: emacs Original-Received: via spool by 68246-submit@debbugs.gnu.org id=B68246.170448020710411 (code B ref 68246); Fri, 05 Jan 2024 18:44:02 +0000 Original-Received: (at 68246) by debbugs.gnu.org; 5 Jan 2024 18:43:27 +0000 Original-Received: from localhost ([127.0.0.1]:57896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLpAE-0002hr-PY for submit@debbugs.gnu.org; Fri, 05 Jan 2024 13:43:27 -0500 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:56515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLpAA-0002hY-Jd for 68246@debbugs.gnu.org; Fri, 05 Jan 2024 13:43:25 -0500 Original-Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-555aa7fd668so2141433a12.0 for <68246@debbugs.gnu.org>; Fri, 05 Jan 2024 10:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704480192; x=1705084992; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=XOi4ybxGTguRKN3pWbQLlvdgNgWo4z9DkwiGPJR1TgU=; b=RTX3ugQUW1rUyKDX/a7RSw7jqdgzBp/oqwOrt1IXiXpUWB3bWiWgYc/q/ixFO4OLyQ U7kJkknIMpPLee6dy5Ga0ny6izvkNN5k2yUWjuN1NHU+JXkKEeaDh3HY2YF7nrRAG+wf 9Jvo8KdoqSkDj0bM1SpprKJUU1RJP6Au6ua7DMTbIcjf5MqYdyzkp5+BWmyLzvsazGhd dOsIfcCcRop1sAL2BPTYKg5n++xrIm4hxN+PQAl8GhGUWtoL/69JdP60gN5sxaHAqMV6 Xo/Df0Kbmn1MFs32upqpOsbOGw3weuP2JyoYtjB2y68FcCLehWbxaXUU0V1m7CXTHN2F oATA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704480192; x=1705084992; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XOi4ybxGTguRKN3pWbQLlvdgNgWo4z9DkwiGPJR1TgU=; b=a854Q1tLmFOmbdROoXTE7EyEOoCQms6K0Cw4qipn4nqpGquXl0skNktgnh5H4Cf29P Tv2Sg274xYgNHymCbJzWfin5Svn4yO5veSYwPxAjj9aU9kBRRFaB9d+tTOn94VUrD3lE kN2e3JAwboooouVdOK64htcg74M8ddXFDFCZY+mYbDWBZcNGqGsqbHEZTsLRJn4WAsNc x8p+ZRZ2/ru+T6Y1XFil/3GLQDY4EE7AB/hQn0RrwK1uon7eaqbYBlHvcyIZoJCsncs7 BztMaL4hw7NVCETppaY4mLwYcuYTOFpN+fu38x1U5IPDkSKLmpnF5J8lGWVLygFT1CTf u3oQ== X-Gm-Message-State: AOJu0Yz4ywJuiweUMluQ1wpxYSrsnLAL4Fz8vkZGQCzSnjHONepsK2mH 9ThMlL82mEisbwDSEfAZ0/QG6TlFTmiKGpCEDY4GkFY5 X-Google-Smtp-Source: AGHT+IG4qZDRGWu6jqH7G+JPzILxaXt5O34C9MtTS7aWnBGMfSu4KiwpJjKc5W0arUr79cIqfyKCTz5CGz3u53HHYls= X-Received: by 2002:a50:aac3:0:b0:556:e0ee:85bc with SMTP id r3-20020a50aac3000000b00556e0ee85bcmr1447919edc.51.1704480191935; Fri, 05 Jan 2024 10:43:11 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 5 Jan 2024 10:43:11 -0800 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277407 Archived-At: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Many packages use the `major-mode` as a proxy for the type of content > in the buffer. When using the new TS modes, these packages tend to > behave poorly because they do not understand that a buffer in `js-ts-mode` > contains Javascript. > > I suggest we add the non-TS mode as an extra parent, so > `derived-mode-all-parents` includes `js-mode` in `js-ts-mode`. We should probably also change *Help* to displays the extra parents, or this will be pretty confusing. It should probably both list it as a parent mode, and say that it will run the corresponding hook. Here's an example: (progn (define-derived-mode python-super-mode prog-mode "SuperPython" "Doc") (derived-mode-add-parents 'python-super-mode '(python-mode)) (describe-function 'python-super-mode))