From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#57000: Wrong entry "c-mode" in definition prefix for semantic Date: Fri, 5 Aug 2022 12:51:55 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2113"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 57000@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 05 12:53:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJuxC-0000Pl-AB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Aug 2022 12:53:18 +0200 Original-Received: from localhost ([::1]:47752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJuxB-00061V-9o for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Aug 2022 06:53:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJuwx-0005xh-Gn for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 06:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJuwx-00057T-83 for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 06:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJuwx-0001cC-4J for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 06:53:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Aug 2022 10:53:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57000 X-GNU-PR-Package: emacs Original-Received: via spool by 57000-submit@debbugs.gnu.org id=B57000.16596967246113 (code B ref 57000); Fri, 05 Aug 2022 10:53:03 +0000 Original-Received: (at 57000) by debbugs.gnu.org; 5 Aug 2022 10:52:04 +0000 Original-Received: from localhost ([127.0.0.1]:56343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJuw0-0001aV-7o for submit@debbugs.gnu.org; Fri, 05 Aug 2022 06:52:04 -0400 Original-Received: from mail-vs1-f42.google.com ([209.85.217.42]:38726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJuvx-0001a2-Sm for 57000@debbugs.gnu.org; Fri, 05 Aug 2022 06:52:02 -0400 Original-Received: by mail-vs1-f42.google.com with SMTP id 125so2076615vsd.5 for <57000@debbugs.gnu.org>; Fri, 05 Aug 2022 03:52:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to; bh=Yw3WIIvRpyd/T89oOAcau92b8N58HIh1OdXT9ot7I7A=; b=YsGEtBYl9smAJgcshPHZED5jz/OgJ2TE1s1Fgp/EVSewg9ZqzHwyClrRcLgptun7+a sIyJJW37sSY9iESuKuBGrAqOZvzcmequNM7cDMAO2foGnOgBiQo+mSVlbTwrQbhQlg7o LaB6Xm4nhpZu3NSUhWYCqr13rTbyyjBCxfuBhXi/dmne4O4sfmKQTclEpg+JCB1HnDh1 MqLUMgweNgPk4PpQa2X1Ybp7e2Cy2gYI4znvcKXeU0UP6J9E5adcFwTH6U7EYw+9z4T9 1tVRZEGl5i0QsUGFBlIEkyWqkqHSrTHOeXbHXRSz4UMokSFZGPsIL6SGOIw55QhkkPo/ Xbqg== X-Gm-Message-State: ACgBeo2Y8inOxv9Ky8SP5pXDRploF4IjCokD+508F7wVFGDSjyX9656u f95wPk8XSEUcFhYzIyZ9JGkbB7hWqAUSoaUSLxnGaTv8 X-Google-Smtp-Source: AA6agR4pS7JC/0LkIbXG74zNXRkCuvGCyJDtrguQF8PrBpdd722kAQSPFDypFVGTQG3I5Ss7vrDKf4UAohPuvR8AvT0= X-Received: by 2002:a05:6102:d89:b0:379:2914:9cfa with SMTP id d9-20020a0561020d8900b0037929149cfamr2759748vst.18.1659696716303; Fri, 05 Aug 2022 03:51:56 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 5 Aug 2022 12:51:55 +0200 In-Reply-To: (Stefan Kangas's message of "Fri, 5 Aug 2022 12:06:06 +0200") X-Hashcash: 1:21:220805:57000@debbugs.gnu.org::TxtL2xkxZhGnP+OC:8yHM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238855 Archived-At: Stefan Kangas writes: > I see in loaddefs.el: > > (register-definition-prefixes "semantic/bovine/c" '("c-mode" "semantic")) > > I think "c-mode" shouldn't be there, but I can't seem to figure out why > it is. This is caused by defcustom-mode-local-semantic-dependency-system-include-path One possible fix below, but I'm not sure we want to do this generally: diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el index afba9f8fbc..8aa17be765 100644 --- a/lisp/emacs-lisp/loaddefs-gen.el +++ b/lisp/emacs-lisp/loaddefs-gen.el @@ -68,6 +68,7 @@ autoload-ignored-definitions "define-short-documentation-group" "def-edebug-elem-spec" "defvar-mode-local" + "defcustom-mode-local-semantic-dependency-system-include-path" "define-ibuffer-column" "define-ibuffer-sorter") "List of strings naming definitions to ignore for prefixes. @@ -456,7 +457,7 @@ loaddefs-generate--compute-prefixes (let ((prefs nil)) ;; Avoid (defvar ) by requiring a trailing space. (while (re-search-forward - "^(\\(def[^ \t]+\\)[ \t]+['(]*\\([^' ()\"\n]+\\)[\n \t]" nil t) + "^(\\(def[^ \t\n]+\\)[ \t\n]+['(]*\\([^' ()\"\n]+\\)[\n \t]" nil t) (unless (member (match-string 1) autoload-ignored-definitions) (let ((name (match-string-no-properties 2))) (when (save-excursion