From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#15934: [Feature request] Highlight full lines Date: Sun, 18 Aug 2019 19:52:43 +0200 Message-ID: References: <86pppuvpv2.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="172329"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Sebastien Vauban , 15934@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 18 19:54:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzPNd-000ifw-0u for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 19:54:13 +0200 Original-Received: from localhost ([::1]:42358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzPNb-0001K8-Th for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 13:54:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46952) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzPNW-0001K0-EA for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzPNS-0007kh-B5 for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:54:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49747) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzPNS-0007kc-7Z for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hzPNS-0004Wj-4q for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:54:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <86pppuvpv2.fsf@somewhere.org> Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2019 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15934 X-GNU-PR-Package: emacs Original-Received: via spool by 15934-submit@debbugs.gnu.org id=B15934.156615078217325 (code B ref 15934); Sun, 18 Aug 2019 17:54:02 +0000 Original-Received: (at 15934) by debbugs.gnu.org; 18 Aug 2019 17:53:02 +0000 Original-Received: from localhost ([127.0.0.1]:58568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzPMU-0004VL-0s for submit@debbugs.gnu.org; Sun, 18 Aug 2019 13:53:02 -0400 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:39511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzPMS-0004Ut-2R for 15934@debbugs.gnu.org; Sun, 18 Aug 2019 13:53:00 -0400 Original-Received: by mail-pg1-f179.google.com with SMTP id u17so5543857pgi.6 for <15934@debbugs.gnu.org>; Sun, 18 Aug 2019 10:52:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=Rpo+E1fO81oKf7Q7od8DrrTK9Z8xQHuxQjWQ0LCl8L4=; b=dpBdYsV3cwSJawgE8v1tra6S9hVgfwD/kfyeWHSKs2A+3NA5t8eghCaPZV73Kye/kq WgFMur810NPeE6DfQsf9HyRIjy7swiFYVu1K7hURJrVR7yYAIqQmgEOZMkIFh3AEpU1n Am7cZwGciZCa+j6VPKX+80PKlXq1jrTmcDhiIu3rMP0aF9R76C3x+TDZgc0CaRmzKG3i TrohLB8uB8DVP3Z6Z2QEFA5n3exfcwO4vlFq1WsocFVMHea67FaUeKtqhDp2/dO7H1pM Ji5UjHc7SThIcr5nnhtlOX2r5EipGNHW9zvULsY3hsslqlrhM+VsbWapVqdhPSSuH+Dx Iteg== X-Gm-Message-State: APjAAAUiLljGGRgxv8WsDKORowOsEa7qmxSVjuDMZjdpW5fLHSLKKZJl ZjMktUHQ6d29jgYlVrEnSIp0JyWJKyUL/VpEIxk= X-Google-Smtp-Source: APXvYqySVLq+DXMg24yZ/DeLphwiQc9W7TcxRZxHFWyxnp+7DJJZdN1+39vq2NZs7d2SG1vrkhWTmGNB1YS1TIerGDE= X-Received: by 2002:a17:90a:c086:: with SMTP id o6mr17602374pjs.2.1566150774178; Sun, 18 Aug 2019 10:52:54 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165350 Archived-At: Michael Heerdegen writes: > Hi Sebastien, > >> I think it'd be nicer to highlight full lines (vs up to the last character) >> when using C-x w l (highlight-lines-matching-regexp). > > I too think that this would be more appropriate. Something like > the following should do the job: > > *** /home/micha/software/emacs/lisp/hi-lock.el 2013-10-26 18:26:42.117620602 +0200 > --- /home/micha/today/hi-lock.el 2013-12-11 02:31:03.251432385 +0100 > *************** > *** 448,454 **** > (hi-lock-set-pattern > ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ? > ;; or a trailing $ in REGEXP will be interpreted correctly. > ! (concat "^.*\\(?:" regexp "\\).*$") face)) > > > ;;;###autoload > --- 448,454 ---- > (hi-lock-set-pattern > ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ? > ;; or a trailing $ in REGEXP will be interpreted correctly. > ! (concat "^.*\\(?:" regexp "\\).*\\($\\)\n?") face)) > > > ;;;###autoload > > > Can we use this? > > > Regards, > > Michael. The suggested change works here, and I think the new behaviour makes more sense. The user would want this to stand out, and it can be hard to spot short lines. Are there any objections to making this change? If there are none, could you Michael please consider committing this to master? Thanks, Stefan Kangas