From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68421: Possible use after free in w32notify.c Date: Sat, 13 Jan 2024 03:25:44 -0600 Message-ID: References: <83jzodha0w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1997"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68421-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 13 10:26:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOaHa-0000IU-Hi for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jan 2024 10:26:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOaHH-0006xL-4B; Sat, 13 Jan 2024 04:26:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOaHD-0006we-S8 for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 04:26:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOaHD-0003uj-EB for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 04:26:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOaHB-0005Ae-SP for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 04:26:01 -0500 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jan 2024 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68421 X-GNU-PR-Package: emacs Mail-Followup-To: 68421@debbugs.gnu.org, stefankangas@gmail.com, stefankangas@gmail.com Original-Received: via spool by 68421-done@debbugs.gnu.org id=D68421.170513795219851 (code D ref 68421); Sat, 13 Jan 2024 09:26:01 +0000 Original-Received: (at 68421-done) by debbugs.gnu.org; 13 Jan 2024 09:25:52 +0000 Original-Received: from localhost ([127.0.0.1]:38397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOaH1-0005A6-NG for submit@debbugs.gnu.org; Sat, 13 Jan 2024 04:25:51 -0500 Original-Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:44511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOaGz-00059u-Nf for 68421-done@debbugs.gnu.org; Sat, 13 Jan 2024 04:25:51 -0500 Original-Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-558fc54e28eso264332a12.1 for <68421-done@debbugs.gnu.org>; Sat, 13 Jan 2024 01:25:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705137945; x=1705742745; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=u5CHuu47lZBY4ar72sUGfHT9K8v5NO8GrqWby9vFamw=; b=UqauOEn8pVRCxCAlGWvsfDTXtug0LuGJr+3/WQDlEXOB9rqD9MviYA7qc6MeAAZRx4 NKOMp8EhVXuoxkMAl+H0iDFQb+qejVIozutXyiy1xnzExWlDWBoB00p+sueE3AQ17xQR /aG1mupkV6YYon1VpHnRiSTg+5ILgWbb5l4WP/SjSiy5zVH5IOLmaCeOznHQABp7tsp/ xeNFu4G0citfj+8oQ9p75JKluJHmTX+53vrZwhZZ1ulH1yVo0c3o53Vv7peXoaLLEmGX 3G0SsSzzAwAF0d1lrJ6k+upd8Nlm9GPMDcS9DQpoYkQYphI8CE5JLDLoowWxjVxyEe9G TomQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705137945; x=1705742745; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u5CHuu47lZBY4ar72sUGfHT9K8v5NO8GrqWby9vFamw=; b=VUybQRvEtif7rbdCxcxCYhBrTY9+lFlvYfjdBGZwPuYOMzzF5D9dzWutGNjkKyx/JG 3la437B5xFRY8xQ+PXL6yu6btuobcDzeVNIPHH5SoRByG9vVJT9mMT+YzYv4Dvs4UG9Y LpKURG1aMzEJUYMIK7b14E4BWMvupAz54UVdnpYy4K+uhTSG3bkhB28uJXC4lbw93tsU tt+p6H64qcW/lvCvYZ+f1yrw8LWDHi9YThABUa/+C8X2d/5VUMYnrApTazWlxtDx46Mo BZmK77LwZPNYBLYsStyp85Cb+6VasgetAM9KJlTlaGxVv4f9ZCPKxsZT1Dk7O+eXFWpC Y3Xg== X-Gm-Message-State: AOJu0Ywqmshjy6g/BVlFYGlH0IYrTvGJIRf/kmDk5gQpClYwMLqgRRWY 9m7AbCggTg8k8AlWPuixBD2VXzmFqjD0EqRFRF2rf97E X-Google-Smtp-Source: AGHT+IFZBGYGJUkre/AXNUjRaJrMsGjxuXYwSHuCu/HnZvENDyKaZslrYqVHWtFXWrekYmutmQAXUAcRD2S3KHfA7Mw= X-Received: by 2002:a05:6402:909:b0:559:2e6:bb1c with SMTP id g9-20020a056402090900b0055902e6bb1cmr200596edz.63.1705137945307; Sat, 13 Jan 2024 01:25:45 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 13 Jan 2024 03:25:44 -0600 In-Reply-To: <83jzodha0w.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278108 Archived-At: Version: 30.1 Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Sat, 13 Jan 2024 01:49:36 -0600 >> >> Could someone familiar with w32notify.c look over the attached patch? >> >> It looks like we are trying to dereference NULL in add_watch, and >> returning an already freed value from start_watching. > > Feel free to install on master, and thanks. Thanks, done in commit 893829021bd.