From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68236: [PATCH] help.el: allow help-quick to use local commands/quick-sections Date: Wed, 10 Jan 2024 07:50:46 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5079"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 68236@debbugs.gnu.org, Philip Kaludercic To: JD Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 16:51:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNarg-0001BT-8U for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 16:51:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNarL-0008Ru-DC; Wed, 10 Jan 2024 10:51:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNarF-0008RP-ES for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 10:51:09 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNar9-00043F-Tt for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 10:51:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNar8-0003U1-9o for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 10:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68236 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68236-submit@debbugs.gnu.org id=B68236.170490185313370 (code B ref 68236); Wed, 10 Jan 2024 15:51:02 +0000 Original-Received: (at 68236) by debbugs.gnu.org; 10 Jan 2024 15:50:53 +0000 Original-Received: from localhost ([127.0.0.1]:42537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaqz-0003Ta-51 for submit@debbugs.gnu.org; Wed, 10 Jan 2024 10:50:53 -0500 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:45387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaqx-0003TO-Ui for 68236@debbugs.gnu.org; Wed, 10 Jan 2024 10:50:52 -0500 Original-Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2cca8eb0509so49322581fa.3 for <68236@debbugs.gnu.org>; Wed, 10 Jan 2024 07:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704901847; x=1705506647; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=x3MW5Wby/mK6aYzlYkP/Koqg+ScaluW6OkRyKy+b21M=; b=P9Pp1cpaDBTyEbnKhN/DOY7N6qpi1L2Wj7UmYdJnTm3mLsV7r/0M1lQcCXtCOQoMEe UbUXfFJrtNS6j2s3mJA2d282QDprLHJrY8HAZsTdRq4+NhgS12vda4evJxMEDzg4Mw0c fL63JPDBi0E6VLGfvYOH8Ii2seN89oBxt42fy1llJCzTb8TmwsL+5i8DL58dh1M+3WAr r6lf+5SQU5Ks6VMDA0oi4v/8zVqm86jUsF8GfdSZOwzSYQtZm+WQv0BvqennayF/0qN5 gyzpQZXTZgwdFkqQlOgz8SgnZNTY6Io/bgeEkF0Q/+6aKgbsx73UAiT3+5YUHy0gTysG Xasw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704901847; x=1705506647; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=x3MW5Wby/mK6aYzlYkP/Koqg+ScaluW6OkRyKy+b21M=; b=gTY9RjK+66Irub+1+XQpE03kYGTzKrY1SnqazA2LRn9yu7fdj3V55qTbR1ODfwIwgf 7iM/iUdtSi96dMfjL8RLltD7K7wBEr6EhZuixjYuGzz2GYFH441pXD2/r4eI7iZN6qCz ZXJvk89zJHK4JBoM+yHNcfiMFzX+HE5t0UieseYUFeKVzLes8rW1EOjKK0psl2ZSRFqI gsP+h0pI74d9rgdW2pjcPEzqrTFBQ/UTzkq0gP1sbFjygLoYuxUkhUXMa1JUaZ4qzoS1 /HIu3dJnYBm2HhtfU/WdloHPa5nVj2YpZJh8HyHZOA6hVQLV3G5wMmvEyNhtZcw+Hv+G i7HQ== X-Gm-Message-State: AOJu0Yy/9W4wcv91H/1Wfxx9O0H4ValX5rfFdP8cL27IFGWjGPsBbhRP C/WAQDTxPdQX5pFYRErVEvWs1f3bLrk8yesow0g= X-Google-Smtp-Source: AGHT+IFBg7zmVbI0V1NrAKA1Vb9AmdV/lh6+iS98sjOtQpv5rn5qUc+g3ngraejtp0dGo+YpGxvTnPPS5znTqQh0res= X-Received: by 2002:a2e:9c96:0:b0:2cc:6e47:6215 with SMTP id x22-20020a2e9c96000000b002cc6e476215mr649549lji.57.1704901846997; Wed, 10 Jan 2024 07:50:46 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 07:50:46 -0800 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277766 Archived-At: JD Smith writes: >> On Jan 10, 2024, at 7:51=E2=80=AFAM, Stefan Kangas wrote: >> >> We could also add a separate command to show only those commands >> somehow in a similar way to `help-quick-toggle'. > > One advantage of this approach is you can craft your *own* short > command description, if the docstring or command name is not clear to > you (things like org-ctrl-return being prime examples). But what > about instead of a separate command to remember, just creating an > (optional) section in the existing help-quick popup, for local > commands? where-is-internal would consult the global keymap for the > global commands, and the current buffer=E2=80=99s keymap for the locals. That might make sense, yes. In that case, perhaps we could also add an option to disable the global keybindings, for advanced users, so that only the mode specific ones were displayed. But I would separate this into two changes: - A "cheatsheet" module - Support for the cheatsheet module in help-quick-toggle Because I can then imagine other ways of displaying and using the cheatsheets (such as the way I proposed). IOW, I would avoid tightly coupling the cheatsheet functionality to help-quick-toggle.