From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#1501: Emacs 22 loses undo buffer Date: Thu, 21 Oct 2021 13:46:23 -0700 Message-ID: References: <85k1b7k763.fsf@gmail.com> <87ef1engij.fsf@gmail.com> <83k0i7c35d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25564"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emerick@gmail.com, 1501@debbugs.gnu.org, cyd@stupidchicken.com, npostavs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 21 22:49:01 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdezl-0006TG-6V for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 22:49:01 +0200 Original-Received: from localhost ([::1]:34856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdezk-0007yR-6F for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 16:49:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdexq-0003Xg-Rq for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 16:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdexq-0007IY-Gm for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 16:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdexq-0002xP-Di for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 16:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Oct 2021 20:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1501 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 1501-submit@debbugs.gnu.org id=B1501.163484919211321 (code B ref 1501); Thu, 21 Oct 2021 20:47:02 +0000 Original-Received: (at 1501) by debbugs.gnu.org; 21 Oct 2021 20:46:32 +0000 Original-Received: from localhost ([127.0.0.1]:58727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdexL-0002wS-O2 for submit@debbugs.gnu.org; Thu, 21 Oct 2021 16:46:32 -0400 Original-Received: from mail-pl1-f173.google.com ([209.85.214.173]:38662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdexJ-0002w3-IF for 1501@debbugs.gnu.org; Thu, 21 Oct 2021 16:46:30 -0400 Original-Received: by mail-pl1-f173.google.com with SMTP id i5so1251747pla.5 for <1501@debbugs.gnu.org>; Thu, 21 Oct 2021 13:46:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=/8pH3RWNknwUsxHGOkzJraBXj8CTuvNeEvOCidUVLRk=; b=NfzzSx4T+PLa3UG1Eym8LX5ndP+lOnWih7zcQMPyhPzaXCyug03WmklB1s9OsB46vg MLJRLi7ah+SzeVUFIpWebowKy04jaGy4lYhrs4ZC7nL07rpqO/PnooZEvrmC8V6N4AL5 k51JOZhWLV+I6BCzYoZamWjz2XCVfEmrW0cTprOJ5lxkpLlzK14L0acedWUVueKJnOqK Dpl0Q5fwsAPfFZMnlKHY9wvVR5n3+xvU0tufnE7Ze3UyZW2TOR6HH+4ePWeC+HWVAGE0 IMBkLJRn43rQ2FBWm9zr9ebMWpxOz98NzizHxx1IV+NwIXfHwMCYutvFs9HF1GbFI6M5 FnXQ== X-Gm-Message-State: AOAM532x75Fwhzzn2dZQe+qCLfO5Tmkvd6isvvcYunP9qj0kaJoSe2Nq xHAIMH71YZDuzhPep5VkV4yw1JB1UauqRIztvwk= X-Google-Smtp-Source: ABdhPJzgEaZPG3pl2TC7EBVCNnI+/zMZkTUoAakyBqnVyAk37ktAuZcWK7oHQgD9g4hCKUg+Rg2T/zFQC6dsAKGFgwU= X-Received: by 2002:a17:902:b691:b029:12d:2b6:d116 with SMTP id c17-20020a170902b691b029012d02b6d116mr7149298pls.71.1634849183784; Thu, 21 Oct 2021 13:46:23 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 21 Oct 2021 13:46:23 -0700 In-Reply-To: <83k0i7c35d.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Oct 2021 15:05:34 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217821 Archived-At: tags 1501 wontfix close 1501 thanks Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Tue, 19 Oct 2021 18:01:43 -0700 >> Cc: Emerick Rogul , 1501@debbugs.gnu.org, >> Chong Yidong >> >> + /* Remove the `face' property to save space. (Bug1501) */ >> + if (!NILP (string)) >> + Fremove_list_of_text_properties (make_fixnum (0), >> + make_fixnum (SCHARS (string)), >> + CALLN (Flist, Qface), >> + string); > > This modifies the text properties of STRING, which you don't own. > > Also, it will do unnecessary non-trivial processing when undo is > turned off. > > I definitely think that with the enlarged undo-limit we should leave > this obscure situation alone. It isn't worth making such significant > low-level changes due to such obscure problems, which are arguably > cockpit errors. OK, I'm therefore closing this bug as wontfix. (Alternatively, we could just close it as "fixed" (with the doubling of undo limits) but let's be a bit more explicit.)