From: Stefan Kangas <stefankangas@gmail.com>
To: "J.P." <jp@neverwas.me>
Cc: emacs-erc@gnu.org, 58840@debbugs.gnu.org
Subject: bug#58840: 29.0.50; Make scheduled reconnects friendlier in ERC
Date: Sat, 12 Nov 2022 20:11:34 -0800 [thread overview]
Message-ID: <CADwFkmmL7-=R5pED-omQmi04Up9CJRHM92086Tmv3HFSk0JWqw__29993.1415285513$1668312766$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <87cz9t4ma3.fsf@neverwas.me> (J. P.'s message of "Fri, 11 Nov 2022 06:07:48 -0800")
"J.P." <jp@neverwas.me> writes:
> v2. Added user option to specify function run by reconnect timer.
> Factored out reconnect scheduling for use in user code.
Looks good to me after a cursory read. I didn't test it, but if you
feel confident about it, I think it should go in. Bonus points for the
regression tests, as always.
Don't forget to add the bug number to the commit message.
next prev parent reply other threads:[~2022-11-13 4:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87lep0nkmb.fsf@neverwas.me>
2022-11-11 14:07 ` bug#58840: 29.0.50; Make scheduled reconnects friendlier in ERC J.P.
[not found] ` <87cz9t4ma3.fsf@neverwas.me>
2022-11-13 4:11 ` Stefan Kangas [this message]
[not found] ` <CADwFkmmL7-=R5pED-omQmi04Up9CJRHM92086Tmv3HFSk0JWqw@mail.gmail.com>
2022-11-13 15:31 ` J.P.
2022-10-28 13:27 J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmmL7-=R5pED-omQmi04Up9CJRHM92086Tmv3HFSk0JWqw__29993.1415285513$1668312766$gmane$org@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=58840@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
--cc=jp@neverwas.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).