From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68246: 30.0.50; Add non-TS mode as extra parent of TS modes Date: Fri, 5 Jan 2024 11:03:46 -0800 Message-ID: References: <83edeww73j.fsf@gnu.org> <83o7dzvrmf.fsf@gnu.org> <838r53vlo5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16175"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68246@debbugs.gnu.org, monnier@iro.umontreal.ca To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Eli Zaretskii , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 05 20:05:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rLpVW-00044h-3l for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jan 2024 20:05:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLpV5-0000Mb-1M; Fri, 05 Jan 2024 14:04:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLpV3-0000MO-N1 for bug-gnu-emacs@gnu.org; Fri, 05 Jan 2024 14:04:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLpV3-0000ha-Eg for bug-gnu-emacs@gnu.org; Fri, 05 Jan 2024 14:04:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLpV7-0008V9-SV for bug-gnu-emacs@gnu.org; Fri, 05 Jan 2024 14:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jan 2024 19:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68246 X-GNU-PR-Package: emacs Original-Received: via spool by 68246-submit@debbugs.gnu.org id=B68246.170448144332609 (code B ref 68246); Fri, 05 Jan 2024 19:05:01 +0000 Original-Received: (at 68246) by debbugs.gnu.org; 5 Jan 2024 19:04:03 +0000 Original-Received: from localhost ([127.0.0.1]:57923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLpUB-0008Tt-B5 for submit@debbugs.gnu.org; Fri, 05 Jan 2024 14:04:03 -0500 Original-Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:45188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLpU6-0008TK-71 for 68246@debbugs.gnu.org; Fri, 05 Jan 2024 14:04:02 -0500 Original-Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2cd2f472665so11322681fa.2 for <68246@debbugs.gnu.org>; Fri, 05 Jan 2024 11:03:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704481428; x=1705086228; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=0neHecBQ4zYJ+c84cFn3/0/Z3EZLi1Zlt3OSqXa4oY8=; b=D1/HXXiZu4K4Z32PyYYvJJMyVCdzMEvSSBQWMrnLfxW0G8VQIdrqYKyw2xZ1rxIbB6 YnE+fhQtWxOzwSsMv3NAl/odtyimGe9uLYce3wZnwGt0Al/JcEBqKoR44dW/9Ed0F9Y9 YbeI/ErTRMADoz4zlWQ659UagBmucsqkN67r39R3iCb75oMo29BsEtml+0rwtYscIYSQ oqSaidKJyaotLjEmMTWSAVL3AlXDVST2CmVFqrsAYQY2nAMBmpJQ0pHGklnN2/ut/CE7 +Y4N+E3AVPjFSE+yXAbG1WrvYCGu2Pw6bPPU4zAFDCx0LoieWoj7SdGAE0dc7tlN2PUI Mw0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704481428; x=1705086228; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0neHecBQ4zYJ+c84cFn3/0/Z3EZLi1Zlt3OSqXa4oY8=; b=J4o/nBBBn0Wsa/1ZxcxUHp/0LZ2kSRaYiXvGr6s3RvIlxufafy3fDH/TlrEZoEoImW BSSKp2hrOSjhjKsr2DmKPzit8GwFsnQYpdcjRoEQ4ysVO6ZUsrnTtr9RzGKguPOQ1SkU +S8XnAzKB6OvwWIA7EK5EHMgmNqBcYn/HEmVwNLH0ZDJISN3Fmv5qNpHJSDExgKoUPe7 Ejb4VCkUi0SfAuv5wwfgDRJ878ccDaOojZqmodgtY8RYT7BxNu6L4xni3iONg1S1T74q iHleerbeD9N/DqNbXvv6FJAKKWufPoln9T2jsOl6qKv1Ak68gME+BmVX6fc+f0Wn8eB1 BvNQ== X-Gm-Message-State: AOJu0Yxf3P4JyNaVCGGTr1PkPY952g0XqhODrtadl9X6zxf2t4yTLglY eC4ExRGSkr429IgNZu2P06tBJ+g0mN+MpUo693A= X-Google-Smtp-Source: AGHT+IEjOA+N3XigsypQirl9PsDlBAWX8xIDZb12ggVoPWCl7eZYHuV58bEiFWVGhPNoYkaZ4Nq6THmlzq8FJUHVqmE= X-Received: by 2002:a2e:a26e:0:b0:2cc:708a:456f with SMTP id k14-20020a2ea26e000000b002cc708a456fmr1191722ljm.17.1704481427452; Fri, 05 Jan 2024 11:03:47 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 5 Jan 2024 11:03:46 -0800 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277409 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > In summary, my position is that regardless of Stefan's patch, which > I'm not opposed to, we should: > > 1. Use add-derived-mode-parents sparingly and consider foo-base-mode when > possible. I agree that inheriting from a `foo-base-mode' is a good way to reuse code between different modes. It's easy to think of examples of where this will be useful: looking up some documentation, running a REPL, interacting with a debugger, and so on and so forth. But even if we added all the base modes today (as empty stubs), AFAIU it wouldn't solve the exact problem that Monnier's patch is addressing, namely to make packages and customizations work in both foo-mode and foo-ts-mode even if they only say: (derived-mode-p 'foo-mode) So I'm not sure doing one excludes the other, or that one should be considered preferred over the other. IOW, I'm not sure about the recommendation to use `add-derived-mode-parents' sparingly, as that would seem to defeat the point. Am I missing something?