From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#46701: [PATCH] small cleanups related to `unlock-buffer' Date: Thu, 25 Feb 2021 18:45:01 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4568"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46701@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 26 01:46:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFRGr-00016V-D6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Feb 2021 01:46:17 +0100 Original-Received: from localhost ([::1]:58678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFRGq-00037N-Cd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Feb 2021 19:46:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFRGe-000366-28 for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 19:46:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFRGd-0000HG-Cs for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 19:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lFRGd-0005n1-9I for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 19:46:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Feb 2021 00:46:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46701 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46701-submit@debbugs.gnu.org id=B46701.161430030922136 (code B ref 46701); Fri, 26 Feb 2021 00:46:03 +0000 Original-Received: (at 46701) by debbugs.gnu.org; 26 Feb 2021 00:45:09 +0000 Original-Received: from localhost ([127.0.0.1]:39796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFRFl-0005kx-Bj for submit@debbugs.gnu.org; Thu, 25 Feb 2021 19:45:09 -0500 Original-Received: from mail-pl1-f179.google.com ([209.85.214.179]:38035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFRFj-0005kf-Ps for 46701@debbugs.gnu.org; Thu, 25 Feb 2021 19:45:08 -0500 Original-Received: by mail-pl1-f179.google.com with SMTP id f8so4271179plg.5 for <46701@debbugs.gnu.org>; Thu, 25 Feb 2021 16:45:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=rNu/JaqqVGm/u1OP3+h+yxtw/Qad24H9D5DiFMf90e4=; b=VHBIbEWg82siO9YEkiO0cDKgbA6QPA99eQ/j+lSkoM+dtpqBnxV/DCZX8sMchoMkA2 jHOyM3M1KpL3vc1jCbk04Nx6qOxjv4n9IhqvoZ3pL/3g7F9zOEGJyZTEySnwogbsko2/ piqq6Sl+ttg1HEbBM8NnsmULSuFZRa7CU5ikKfWQdGO6d3xgLs5Y/el36jd0fmXE5iEV VWMNLY3rdRexXN9iughD1Xy+RIuqgj3Hfq/fzkdUsvvnVq1b3r51t8GHnsrWBjsierPk OybcEr9oW9CPXZZa7HJ8NxS0CLuHhP64yp8Dtl2DLwVlEERRjrpnmOLDiT3PL4c/ahIp owLQ== X-Gm-Message-State: AOAM530oOSr47GgI7K4DgHz31GS7SznC0ZMw8LtwYDhUzvDej5Tk5Jky i6lG1tFN2td+NIcUIxHXAldTH63dRqjtkvw4t+m1ef81 X-Google-Smtp-Source: ABdhPJwQS6DAn6w0ytRtsfi5BUR/STBGtwI8FzZY5WlM33he498dg8t9PtOkP+l0vP7D3Ck14wlznzBx1P2tFl5F/ds= X-Received: by 2002:a17:90b:3697:: with SMTP id mj23mr621019pjb.104.1614300301975; Thu, 25 Feb 2021 16:45:01 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 25 Feb 2021 18:45:01 -0600 In-Reply-To: (Matt Armstrong's message of "Mon, 22 Feb 2021 16:56:44 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200826 Archived-At: Matt Armstrong writes: > I did a manual test. I edited a file, then changed the file outside > emacs, then ran revert-buffer. The file's lock file was still removed, > even with the patch below applied. Perhaps we should write some automatic tests before changing anything in this area?