From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#57906: [PATCH] Add face help-key-binding in help-char echo Date: Sun, 18 Sep 2022 05:40:43 -0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000a42b6905e8f0637b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21085"; mail-complaints-to="usenet@ciao.gmane.io" To: 57906@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 18 11:41:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZqnb-0005PC-7c for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 11:41:15 +0200 Original-Received: from localhost ([::1]:45238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZqna-0007Ou-8G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 05:41:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZqnO-0007Oc-Sv for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 05:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZqnO-0005sU-CH for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 05:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZqnO-0002uU-7W for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 05:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57906 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166349405011153 (code B ref -1); Sun, 18 Sep 2022 09:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Sep 2022 09:40:50 +0000 Original-Received: from localhost ([127.0.0.1]:47798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZqnC-0002tp-BP for submit@debbugs.gnu.org; Sun, 18 Sep 2022 05:40:50 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZqnA-0002tg-Im for submit@debbugs.gnu.org; Sun, 18 Sep 2022 05:40:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZqnA-0007OL-7e for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 05:40:48 -0400 Original-Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:33439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZqn8-0005rz-AN for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 05:40:48 -0400 Original-Received: by mail-oi1-x234.google.com with SMTP id j188so8929360oih.0 for ; Sun, 18 Sep 2022 02:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date; bh=AxgJivHfOtdAW23OUE6l1V3S/PCocHyZwNSJfOIN0V8=; b=qbYXR+4UZa4/MxfSz1y2RcuZS6GRnoNMCWO8byf/SaYeDm6bp9FGjuwy6Esyz71+Hc sbGlfvMUOkV/FfB8XAcj4TfpeIfBZYbjSZ128qvNxGvHiPt3+HOOmwFL71Qd3FHqg8SU dhaJNWmpTx9wvMJUwC6yAniNNNzWCC0MxJebajFBZ/1XbPsrngFRb3AhDXrr1aX9Sh2y VlsyyE31sWEnJFBlpqepNXWd/jPcTAeC1zRplX5p7Gd0SkBghGrDzxA6XA/n0Qe38i+C ior7gq9MaImrsYksAnpM6LsLLWT+Cm0hu+J/EZ/7He0vfD+7bx80YefRGXcmxQ6nqq67 JdJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date; bh=AxgJivHfOtdAW23OUE6l1V3S/PCocHyZwNSJfOIN0V8=; b=BY3tBNhDxy4xP86mRT0jQ226AJf/cd483+K6CS2m7ZYYid7BwAh364sB7MJ4p4kwIz 9YN5BECNaYjPkghqXfFtgJU7s6t6HGHh+CPB5XZvp+6h6qrPo+Oe0h6sSKvNfarxKV3N UusPd4Ti9pZSeESreKi3+dpyZShQ2BCgOwHjN027knASwV0e/qbV/ndr5ZAR51vXfxbO tdY5jhMQ4xI5tTx/PCDcniR4zT0cBVIskUNYvB5dzgsmPmgK7d9Z9Wot9IJwqTz/awT7 i57rZGYLx3irFYR87jZ8z8s0TBa/BUOdeqGAjydbwtxF2RRgqA8C0XRmHBJ8qmLR6gns XMaQ== X-Gm-Message-State: ACgBeo2B5+fAu9SNCiRdu9S9FpMZg+fw1nGeXSneda/iwPrdG4zsG27u 00gJkWsN+UpwOqEy6b0KWd1YSAKmCWQLwJygSvICzf1r X-Google-Smtp-Source: AA6agR7RseYo6cQ5jmwYMYGDlzNM85TXCR4MggivlSQAz9/LlstK6CQ28RSE1E8QkmUTKFB+oYI4r5xkPKSsXaQ1y5k= X-Received: by 2002:a05:6808:1688:b0:345:ea9a:2954 with SMTP id bb8-20020a056808168800b00345ea9a2954mr10055018oib.199.1663494045025; Sun, 18 Sep 2022 02:40:45 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 18 Sep 2022 05:40:43 -0400 Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=stefankangas@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242940 Archived-At: --000000000000a42b6905e8f0637b Content-Type: text/plain; charset="UTF-8" Severity: minor For the sake of consistency, I think we should use the `help-key-binding' face to the "?" key in the message that shows up when typing `C-h' and waiting. Please see the attached patch. --000000000000a42b6905e8f0637b Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Add-face-help-key-binding-in-help-char-echo.patch" Content-Disposition: attachment; filename="0001-Add-face-help-key-binding-in-help-char-echo.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: acf6ed3c7f4bb8ed_0.1 RnJvbSA2NWEzOWI3YTU0NGVlMDI4YTFlNjE1M2JkN2U2Yjg2ZDMyZDJmM2U5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDE4IFNlcCAyMDIyIDExOjI5OjUyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIGZhY2UgaGVscC1rZXktYmluZGluZyBpbiBoZWxwLWNoYXIgZWNobwoKKiBzcmMva2V5Ym9h cmQuYyAoZWNob19hZGRfa2V5KTogQWRkIGhlbHAta2V5LWJpbmRpbmcgZmFjZSB0byB0aGUKIj8i IGtleSBpbiAnaGVscC1jaGFyJyBlY2hvLgooc3ltc19vZl9rZXlib2FyZCkgPFFoZWxwX2tleV9i aW5kaW5nPjogTmV3IERFRlNZTS4KLS0tCiBzcmMva2V5Ym9hcmQuYyB8IDIyICsrKysrKysrLS0t LS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL3NyYy9rZXlib2FyZC5jIGIvc3JjL2tleWJvYXJkLmMKaW5kZXgg Y2E1MWM4MGRhMC4uMGE4NDA0NzQzNSAxMDA2NDQKLS0tIGEvc3JjL2tleWJvYXJkLmMKKysrIGIv c3JjL2tleWJvYXJkLmMKQEAgLTQ5OSwyNyArNDk5LDE5IEBAIGVjaG9fYWRkX2tleSAoTGlzcF9P YmplY3QgYykKIAkJCVNUUklOR19NVUxUSUJZVEUgKG5hbWUpLCAxKTsKICAgICB9CiAKKyAgTGlz cF9PYmplY3QgbmV3X3N0cmluZyA9IG1ha2Vfc3RyaW5nIChidWZmZXIsIHB0ciAtIGJ1ZmZlcik7 CiAgIGlmICgoTklMUCAoZWNob19zdHJpbmcpIHx8IFNDSEFSUyAoZWNob19zdHJpbmcpID09IDAp CiAgICAgICAmJiBoZWxwX2NoYXJfcCAoYykpCiAgICAgewotICAgICAgc3RhdGljIGNvbnN0IGNo YXIgdGV4dFtdID0gIiAoVHlwZSA/IGZvciBmdXJ0aGVyIG9wdGlvbnMpIjsKLSAgICAgIGludCBs ZW4gPSBzaXplb2YgdGV4dCAtIDE7Ci0KLSAgICAgIGlmIChzaXplIC0gKHB0ciAtIGJ1ZmZlcikg PCBsZW4pCi0JewotCSAgcHRyZGlmZl90IG9mZnNldCA9IHB0ciAtIGJ1ZmZlcjsKLQkgIHNpemUg Kz0gbGVuOwotCSAgYnVmZmVyID0gU0FGRV9BTExPQ0EgKHNpemUpOwotCSAgcHRyID0gYnVmZmVy ICsgb2Zmc2V0OwotCX0KLQotICAgICAgbWVtY3B5IChwdHIsIHRleHQsIGxlbik7Ci0gICAgICBw dHIgKz0gbGVuOworICAgICAgQVVUT19TVFJJTkcgKHN0ciwgIiAoVHlwZSA/IGZvciBmdXJ0aGVy IG9wdGlvbnMpIik7CisgICAgICBBVVRPX0xJU1QyIChwcm9wcywgUWZhY2UsIFFoZWxwX2tleV9i aW5kaW5nKTsKKyAgICAgIEZhZGRfdGV4dF9wcm9wZXJ0aWVzIChtYWtlX2ZpeG51bSAoNyksIG1h a2VfZml4bnVtICg4KSwgcHJvcHMsIHN0cik7CisgICAgICBuZXdfc3RyaW5nID0gY29uY2F0MiAo bmV3X3N0cmluZywgc3RyKTsKICAgICB9CiAKICAga3NldF9lY2hvX3N0cmluZwogICAgIChjdXJy ZW50X2tib2FyZCwKLSAgICAgY29uY2F0MiAoZWNob19zdHJpbmcsIG1ha2Vfc3RyaW5nIChidWZm ZXIsIHB0ciAtIGJ1ZmZlcikpKTsKKyAgICAgY29uY2F0MiAoZWNob19zdHJpbmcsIG5ld19zdHJp bmcpKTsKICAgU0FGRV9GUkVFICgpOwogfQogCkBAIC0xMjA5OCw2ICsxMjA5MCw4IEBAIHN5bXNf b2Zfa2V5Ym9hcmQgKHZvaWQpCiAJICAgICAgIGRvYzogLyogTWVzc2FnZSBkaXNwbGF5ZWQgYnkg YG5vcm1hbC10b3AtbGV2ZWwnLiAgKi8pOwogICBWaW50ZXJuYWxfX3RvcF9sZXZlbF9tZXNzYWdl ID0gcmVndWxhcl90b3BfbGV2ZWxfbWVzc2FnZTsKIAorICBERUZTWU0gKFFoZWxwX2tleV9iaW5k aW5nLCAiaGVscC1rZXktYmluZGluZyIpOworCiAgIC8qIFRvb2wtYmFycy4gICovCiAgIERFRlNZ TSAoUUNpbWFnZSwgIjppbWFnZSIpOwogICBERUZTWU0gKFFoZWxwX2VjaG8sICJoZWxwLWVjaG8i KTsKLS0gCjIuMzAuMgoK --000000000000a42b6905e8f0637b--