unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: wkirschbaum@gmail.com, casouri@gmail.com, 75192@debbugs.gnu.org
Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode
Date: Thu, 2 Jan 2025 02:41:12 -0600	[thread overview]
Message-ID: <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@mail.gmail.com> (raw)
In-Reply-To: <86zfk9k3xr.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Thu, 2 Jan 2025 01:45:22 -0600
>> Cc: Eli Zaretskii <eliz@gnu.org>, Yuan Fu <casouri@gmail.com>
>>
>> Wilhelm Kirschbaum <wkirschbaum@gmail.com> writes:
>>
>> > This updates heex-ts-mode to use font-lock-string-face to be consistent
>> > with html-ts-mode on attribute values.
>>
>> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?
>
> Are we all in agreement with the change itself?  Why should an
> attribute be highlighted as a string?

I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
simply noted that the code directly above the change said

    :feature 'heex-string

which is why I assumed that using a string face should make sense.

I'll let others chime in here.





  reply	other threads:[~2025-01-02  8:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30 10:59 bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Wilhelm Kirschbaum
2025-01-02  7:45 ` Stefan Kangas
2025-01-02  8:36   ` Eli Zaretskii
2025-01-02  8:41     ` Stefan Kangas [this message]
2025-01-02  8:56       ` Wilhelm Kirschbaum
2025-01-02  9:06       ` Eli Zaretskii
2025-01-02 10:13         ` Wilhelm Kirschbaum
2025-01-02 15:24           ` Eli Zaretskii
2025-01-03  5:49             ` Yuan Fu
2025-01-03 15:14               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=75192@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=wkirschbaum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).