From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: thomas.hisch@ims.co.at, 41852@debbugs.gnu.org
Subject: bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode
Date: Mon, 19 Oct 2020 15:41:48 -0700 [thread overview]
Message-ID: <CADwFkmmH30+dX5fh5AR3YJH+6gg48=Z1L6OcPqDhVkG6fMj_rA@mail.gmail.com> (raw)
In-Reply-To: <83wnzmnioj.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> Can we continue supporting text-scale-mode-remapping in
> text-scale-mode--remappings? I'd like to avoid backward-incompatible
> changes if possible.
Do you mean something like this?
diff --git a/lisp/face-remap.el b/lisp/face-remap.el
index 4d7be7d65a..377976782f 100644
--- a/lisp/face-remap.el
+++ b/lisp/face-remap.el
@@ -219,7 +219,8 @@ text-scale-mode-step
;; current remapping cookie for text-scale-mode
(defvar text-scale-mode-remapping nil)
-(make-obsolete-variable 'text-scale-mode-remapping "no longer used." "28.1")
+(make-obsolete-variable 'text-scale-mode-remapping
+ 'text-scale-mode--remappings "28.1")
(defvar text-scale-mode--remappings nil
"List of current remapping cookies for `text-scale-mode'.")
@@ -239,8 +240,10 @@ text-scale-remap-header-line-face
(make-variable-buffer-local 'text-scale-header-line)
(defun face-remap--clear-remappings ()
- (dolist (remapping text-scale-mode--remappings)
+ (dolist (remapping (cons text-scale-mode-remapping ; backwards-compatibility
+ text-scale-mode--remappings))
(face-remap-remove-relative remapping))
+ (setq text-scale-mode-remapping nil) ; backwards-compatibility
(setq text-scale-mode--remappings nil))
(defun face-remap--remap-face (sym)
> Do mouse clicks work well, even if you click close to the edges of a
> much-enlarged header-line?
This seems to work as expected, yes. I've tested with both very large
and very small text sizes.
> Otherwise the changes look fine to me, thanks.
Thank you for reviewing.
next prev parent reply other threads:[~2020-10-19 22:41 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 13:36 bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode Thomas Hisch
2020-06-14 14:42 ` Eli Zaretskii
2020-06-14 16:25 ` Thomas Hisch
2020-10-18 23:34 ` Stefan Kangas
2020-10-19 14:19 ` Eli Zaretskii
2020-10-19 18:21 ` Stefan Kangas
2020-10-19 19:02 ` Eli Zaretskii
2020-10-19 22:41 ` Stefan Kangas [this message]
2020-10-20 14:15 ` Eli Zaretskii
2020-10-20 14:40 ` Stefan Kangas
2020-10-20 14:45 ` Eli Zaretskii
2020-10-20 19:10 ` Thomas Hisch
2020-10-29 17:43 ` Stefan Kangas
2020-10-29 19:37 ` Thomas Hisch
2020-10-29 21:45 ` Stefan Kangas
2020-10-30 8:01 ` Eli Zaretskii
2020-10-29 17:33 ` Stefan Kangas
2020-10-29 18:02 ` Drew Adams
2020-10-29 18:15 ` Stefan Kangas
2020-10-29 18:32 ` Drew Adams
2020-10-29 18:47 ` Stefan Kangas
2020-10-30 8:54 ` martin rudalics
2020-10-30 16:04 ` Stefan Kangas
2020-10-30 17:37 ` martin rudalics
2020-10-30 19:01 ` Eli Zaretskii
2020-10-31 0:31 ` Stefan Kangas
2020-10-31 8:00 ` martin rudalics
2020-10-30 18:54 ` Eli Zaretskii
2020-10-30 20:22 ` Stefan Kangas
2020-10-30 20:53 ` Eli Zaretskii
2020-10-31 16:15 ` Stefan Kangas
2020-10-31 16:48 ` Eli Zaretskii
2020-10-31 16:57 ` Eli Zaretskii
2020-10-31 17:55 ` Eli Zaretskii
2020-11-12 22:25 ` Stefan Kangas
2020-11-13 7:51 ` Eli Zaretskii
2020-11-25 2:08 ` Stefan Kangas
2020-11-13 8:49 ` martin rudalics
2020-11-25 2:08 ` Stefan Kangas
2020-11-13 13:00 ` Jean Louis
2020-11-13 14:32 ` Stefan Kangas
2020-11-13 15:33 ` Jean Louis
2020-11-13 16:07 ` github.com
2020-11-13 16:49 ` Stefan Kangas
2020-10-31 16:50 ` Stefan Kangas
2020-10-31 8:29 ` Eli Zaretskii
2020-10-31 16:25 ` Stefan Kangas
[not found] <<955fe4fe-a64d-b7c6-fe31-7efd810f97a5@ims.co.at>
[not found] ` <<83mu553e0x.fsf@gnu.org>
2020-06-14 16:28 ` Drew Adams
2020-06-14 17:23 ` Thomas Hisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmmH30+dX5fh5AR3YJH+6gg48=Z1L6OcPqDhVkG6fMj_rA@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=41852@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=thomas.hisch@ims.co.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).