From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#57691: 29.0.50; image-tests failures Date: Fri, 9 Sep 2022 05:03:00 -0400 Message-ID: References: <83y1utcbcl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000002a42af05e83ad0ec" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2792"; mail-complaints-to="usenet@ciao.gmane.io" To: Eli Zaretskii , 57691@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 09 11:04:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWZw0-0000VA-Hl for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Sep 2022 11:04:24 +0200 Original-Received: from localhost ([::1]:35528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWZvz-0007Nw-HZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Sep 2022 05:04:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWZve-0007N4-3z for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 05:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWZvd-0003Bv-RA for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 05:04:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWZvd-0007sD-MU for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 05:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Sep 2022 09:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57691 X-GNU-PR-Package: emacs Original-Received: via spool by 57691-submit@debbugs.gnu.org id=B57691.166271419130209 (code B ref 57691); Fri, 09 Sep 2022 09:04:01 +0000 Original-Received: (at 57691) by debbugs.gnu.org; 9 Sep 2022 09:03:11 +0000 Original-Received: from localhost ([127.0.0.1]:60876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWZup-0007rA-Cm for submit@debbugs.gnu.org; Fri, 09 Sep 2022 05:03:11 -0400 Original-Received: from mail-ot1-f49.google.com ([209.85.210.49]:38627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWZul-0007qu-CU for 57691@debbugs.gnu.org; Fri, 09 Sep 2022 05:03:09 -0400 Original-Received: by mail-ot1-f49.google.com with SMTP id c39-20020a05683034a700b006540d515722so671090otu.5 for <57691@debbugs.gnu.org>; Fri, 09 Sep 2022 02:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date; bh=Nd9ABd+kvc7UC86CTDAVkxFCK9PY05w5sYt1i4c/Lv8=; b=mbyD2xpNDQ/t845QwPF5Z1nfUfOJE5F7ijKN94eRkwjsXhCjgvofl3GeTGLutJBbe3 Pm0lfmMRIYEZEH5/aeeKm+gqdECS1fUKABx918IL6b+duIDI+hX3HpsBnZVVS7PjpVYW XgxIkLvKWh6BAVGi9YdeOznr9b4ZA2DhwTPiHIW5kPOkbYem2jA1m65ETBR70w30yZEF GEr3ZeD584Y7I6kA5taFVcZ0hiD4LG8Yh7+z33FXUZK/wZ6+Y9nY0a2C9/p4HCvyxI31 HIxiXjH++1YHZVHONGTHJ94e0omkgoZXcCf1bIdiE3gPRsiZvOtwzEl3nc/BENpwu4UT I34Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date; bh=Nd9ABd+kvc7UC86CTDAVkxFCK9PY05w5sYt1i4c/Lv8=; b=uXCuQ7nt1/7YE/OfqO+2Wsvqz2co44WExt2eBwHSQ4tYcZybY66N/nc3BpZhb0DEZ+ 0dCxkNXtwwKBAVrLPMGe43XA135ETpqYcvpwIeVqoD0bZA29X7hXZk/QRvNV3GUy6y07 FqO7UTAlIQznvo4RcEatzbqFNwSe8BNpZvPtCkuFBcTgIoEVTnWZO9yAULxKXZnWe+Co mFsGxjRWpqFTmZ3VniyC56O1q/rmySslyoLvrYGCRyUICkbNScXR8NLicNXPGkknJpJi iFNy/s9mucFKs+SdMevHG6wo1DHfC0s9230ugbRG8FwSP6RGEYZKimFaCDD297IvjIc/ zjEw== X-Gm-Message-State: ACgBeo1Hz0Dj/UVsTvdYix2L/KDDp4jvbHtHYxe9l0BT9BdJ5jwNczyp JN2A50Amf1mq3WamJK5nLJQR1SPEj7IdJAwjDjk= X-Google-Smtp-Source: AA6agR4V7LW1AmJK3Bw/HQvr97+xf1ndWNDJAZh1GpUnkC63MbeDcQOob+5EPOlKx/2/ce2N+rp8CDhOqjtKK3F9mBc= X-Received: by 2002:a05:6830:3c1:b0:637:28be:7920 with SMTP id p1-20020a05683003c100b0063728be7920mr4872957otc.105.1662714181715; Fri, 09 Sep 2022 02:03:01 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 9 Sep 2022 05:03:00 -0400 In-Reply-To: <83y1utcbcl.fsf@gnu.org> X-Hashcash: 1:20:220909:57691@debbugs.gnu.org::KBV6iu8PhHRoBGUj:98We X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241961 Archived-At: --0000000000002a42af05e83ad0ec Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: > Running test/manual/image-tests.el, as in > > ./src/emacs -Q -l test/manual/image-tests.el --eval "(ert t)" > > produces 2 failures: Thanks for reporting this. > F image-tests-image-metadata/gif > (ert-test-failed > ((should > (memq 'delay > (image-metadata > (create-image ...)))) > :form > (memq delay nil) > :value nil)) That doesn't happen here, so maybe it's MS-Windows specific? Could you build with --enable-checking=3D"glyphs", and see what you get from evaluating: (let ((img (create-image (expand-file-name "test/data/image/black.gif" source-directory)))) (cons (lookup-image img) (image-metadata img))) It should print some output to the terminal too, which is also interesting. For reference, I get: (10 delay 0.06666666666666667 extension-data (249 "\^A\0\0\^A")) Note that the above 1/15=3D0.066 delay is what we expect (see image.c:9452). I also get this terminal output: (image :type gif :file "/home/skangas/wip/emacs/test/data/image/black.gif" :scale 1.0031746031746032 :transform-smoothing t) I'm not sure if it matters or not, but do you happen to know which version of giflib you're using? > F image-tests-load-image/svg-invalid > (ert-test-failed > ((should > (string-search "XML parse error" > (buffer-string))) > :form > (string-search "XML parse error" "For information about GNU Emacs a= nd the GNU system, type C-h C-a.\nType C-c C-c to view the image as text\nE= rror parsing SVG image: Error domain 1 code 4 on line 1 column 1 of data: S= tart tag expected, '<' not found [3 times]\n") > :value nil)) This looks like some version of librsvg giving a different error message. Does the attached patch fix this for you? Also, out of interest, do you know which version of librsvg you're using? --0000000000002a42af05e83ad0ec Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Fix-SVG-test-for-old-librsvg.patch" Content-Disposition: attachment; filename="0001-Fix-SVG-test-for-old-librsvg.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 6e8660f4281e94ef_0.1 RnJvbSA5ZTdjZWFhOTNhYjJhNzk0YmQwMjIzYmJlYzBkNDBhOTBhZWNjMDljIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDkgU2VwIDIwMjIgMTA6MzE6MjUgKzAyMDAKU3ViamVjdDogW1BBVENIXSBG aXggU1ZHIHRlc3QgZm9yIG9sZCBsaWJyc3ZnCgoqIHRlc3QvbWFudWFsL2ltYWdlLXRlc3RzLmVs IChpbWFnZS10ZXN0cy1sb2FkLWltYWdlL3N2Zy1pbnZhbGlkKToKTWF0Y2ggZXJyb3IgbWVzc2Fn ZSBpbiBvbGQgdmVyc2lvbnMgb2YgbGlicnN2Zy4gIChCdWcjNTc2OTEpCi0tLQogdGVzdC9tYW51 YWwvaW1hZ2UtdGVzdHMuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3Rlc3QvbWFudWFsL2ltYWdlLXRlc3RzLmVs IGIvdGVzdC9tYW51YWwvaW1hZ2UtdGVzdHMuZWwKaW5kZXggYzcyNjg0NWJkMy4uOGY2NDc2ZjNl MiAxMDA2NDQKLS0tIGEvdGVzdC9tYW51YWwvaW1hZ2UtdGVzdHMuZWwKKysrIGIvdGVzdC9tYW51 YWwvaW1hZ2UtdGVzdHMuZWwKQEAgLTg2LDggKzg2LDkgQEAgaW1hZ2UtdGVzdHMtbG9hZC1pbWFn ZS9zdmctaW52YWxpZAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi aW52YWxpZCBmb28gYmFyIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICA6dHlwZSBzdmcpKSkKICAgICAocmVkaXNwbGF5KSkKKyAgOzsgbGlicnN2ZyBlcnJvcjogIi4u LiBTdGFydCB0YWcgZXhwZWN0ZWQsICc8JyBub3QgZm91bmQgWzMgdGltZXNdIgogICAod2l0aC1j dXJyZW50LWJ1ZmZlciAiKk1lc3NhZ2VzKiIKLSAgICAoc2hvdWxkIChzdHJpbmctc2VhcmNoICJY TUwgcGFyc2UgZXJyb3IiIChidWZmZXItc3RyaW5nKSkpKSkKKyAgICAoc2hvdWxkIChzdHJpbmct bWF0Y2ggIltFZV1ycm9yLitTdGFydCB0YWcgZXhwZWN0ZWQiIChidWZmZXItc3RyaW5nKSkpKSkK IAogDAogOzs7OyBpbWFnZS10ZXN0LXNpemUKLS0gCjIuMzAuMgoK --0000000000002a42af05e83ad0ec--