From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#70182: [PATCH] Fix + ert for segmentation fault in get-variable-watchers (1 of 9) Date: Sat, 22 Jun 2024 04:05:19 -0700 Message-ID: References: <86sezz3qco.fsf@gnu.org> <86bk6l1u5z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39680"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70182@debbugs.gnu.org To: Robert Burks , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 13:07:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKyaS-000A0L-86 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 13:07:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKyaG-0002n9-Vf; Sat, 22 Jun 2024 07:07:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKyaE-0002mn-Qb for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 07:07:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKyaE-00062t-ID for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 07:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKyaE-0003yG-2j for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 07:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70182 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70182-submit@debbugs.gnu.org id=B70182.171905438815212 (code B ref 70182); Sat, 22 Jun 2024 11:07:02 +0000 Original-Received: (at 70182) by debbugs.gnu.org; 22 Jun 2024 11:06:28 +0000 Original-Received: from localhost ([127.0.0.1]:44554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKyZf-0003xH-Na for submit@debbugs.gnu.org; Sat, 22 Jun 2024 07:06:28 -0400 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:53483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKyZe-0003x4-48 for 70182@debbugs.gnu.org; Sat, 22 Jun 2024 07:06:26 -0400 Original-Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-57cc30eaf0aso1580804a12.2 for <70182@debbugs.gnu.org>; Sat, 22 Jun 2024 04:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719054320; x=1719659120; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=lkNThm+uGwhUIftRKohK03b9KkdpTjfJXMLfQFDA00w=; b=Zx2a+rFVsbTgnq9nywpp+iVmCfaEpsUTbF5pAR3zoYACGeDEQ5vsu4CQN0ofjgU6o/ 7fk4HSpiPrrDjcp7aiyYMwjOkV7/NIGpFZlPHPdM5gpNn5z59N8ndRcOSRjZ/R6qQIfA vL9IJLh5gVfjqd++Hy67HMpL5N2557Hb8sVvgtH+6DJ06DabcVyLzCUewL+P1m4+B9LJ 9bpdy63nkEjUnAIN+jvV9dyw5uQQx2EwdeNjLrdIODkUnWlCE3fHHikXolKZQUlp7YbI 387peU4t8l9WOUXEHpOOmPlVsVofX9Yb/9pt1XbOWxyo0JuEa//kt3YXqkkxnPOi1dB5 up6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719054320; x=1719659120; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lkNThm+uGwhUIftRKohK03b9KkdpTjfJXMLfQFDA00w=; b=TE/nHrVJcPZoVS+SuUyzhSu0Ytf+5UhL+rJ5vFr7Xekc+cLJOMfxo1d/frC9sE3Eie 5DZfjESbIRYKGQDbHjPOlS0AeI/8X/ZBTaD987/jrxGlPfgsvtmLAtX8PacGi44AzZsk p3nV0r3ptQP04x8WjYOIkPSTV1yYYnFjUxYfLZqlggHLyQ7gwxr6KnonenLpfghE0s7e RvTahDVgZdExeN6/AJwq7is6z2EANCbMhS8a32I5qAvrvYtrZBgFar0jYwhjP0X9pdGG xyFtJ79w+61zdpVerOKdKuI47OYA6nxbAltmMX8MgtQe6t0HKZ99ANAgC1qpL7luY7kB BgYQ== X-Gm-Message-State: AOJu0YzTN77tteDQpcul+QEcMACiPJBbuBxtEVco7ElNLsn4tw7mfYtb Vfd1ariWPEAdikHGVPIu72U3jFRVRBow6LcoEACdJ3Qtd7aXjntPGAtbbPtXXRA07bbboxNOX94 cJI7c0b2Cj5pTQxCB41fRvdSGIew= X-Google-Smtp-Source: AGHT+IEASf7t4wcmaeUINuHBt0de0qGuCcwK0Ulav4XicDt1k4vtum0P7nB0BnyUwsqISphzIq402OSMt/bEmrbiNyQ= X-Received: by 2002:a05:6402:2789:b0:57d:f84:11aa with SMTP id 4fb4d7f45d1cf-57d0f841369mr10601706a12.31.1719054320284; Sat, 22 Jun 2024 04:05:20 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 22 Jun 2024 04:05:19 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287692 Archived-At: Robert Burks writes: > Got it. > > On Sun, Apr 7, 2024 at 3:58=E2=80=AFAM Eli Zaretskii wrote= : > >> [Please use Reply All to reply, to keep the bug tracker CC'ed.] >> >> > From: Robert Burks >> > Date: Sun, 7 Apr 2024 02:30:54 -0400 >> > >> > I will make the changes. Sorry if my previous reply came across as >> rash, wasn't the intent. >> > Should I remove the bug number tag also? >> >> The bug number should be mentioned in the commit log message, not in >> the sources. >> >> > Also, kicking myself, I know they should end with a period and two >> spaces, every other >> > comment I've written probably does. Somehow the only ones I didn't >> check was the very >> > first patch, lol. That first comment wasn't even supposed to go out, >> that was my personal note >> > for when I was going through looking for more of the same bug. >> > >> > There will probably be other comments to remove. >> >> Thanks. >> Any news here? The patch looks okay to me, so perhaps we should just fix up the minor stylistic issues and install it?