From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44854: [PATCH] Add lexical-binding cookie to autoload files Date: Tue, 24 Nov 2020 13:05:31 -0800 Message-ID: References: <925908cd-bc9d-4c57-9cec-d961c9dbad95@default> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36449"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca To: Drew Adams , 44854@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 24 22:06:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khfW6-0009No-L3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Nov 2020 22:06:26 +0100 Original-Received: from localhost ([::1]:42784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khfW5-00035t-MG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Nov 2020 16:06:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khfVj-00035K-CU for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 16:06:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khfVi-0002Jz-Ub for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 16:06:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1khfVi-0002y9-Q2 for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 16:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Nov 2020 21:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44854-submit@debbugs.gnu.org id=B44854.160625193911376 (code B ref 44854); Tue, 24 Nov 2020 21:06:02 +0000 Original-Received: (at 44854) by debbugs.gnu.org; 24 Nov 2020 21:05:39 +0000 Original-Received: from localhost ([127.0.0.1]:33220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khfVL-0002xQ-HK for submit@debbugs.gnu.org; Tue, 24 Nov 2020 16:05:39 -0500 Original-Received: from mail-ej1-f45.google.com ([209.85.218.45]:42029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khfVJ-0002xD-QA for 44854@debbugs.gnu.org; Tue, 24 Nov 2020 16:05:38 -0500 Original-Received: by mail-ej1-f45.google.com with SMTP id i19so30499397ejx.9 for <44854@debbugs.gnu.org>; Tue, 24 Nov 2020 13:05:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=XGu21aH6Dy2C30kIMmViLmthNYAYsoMFymZmN+2rrmg=; b=IWn22aUmf9fJbKxdsQhbKBNZgfR9cS4kGR2EDrjFvTQ1dkerAud1KYHG4etGgBALFu mgmiNwWubR8XqY/tHqZGmRcRrIM0ZQsQ7763p+Q2e8yz35A84ZcOke+1+3ZNv6kKepEn BEBPcKJ75LOzk/Fb0PRf4WtZp4Oz7yv7WtEGYKz4J3bpv2xxnElpexOEtWIKJ5Mn45Kq YsrbTuHow6qWFTYg6ADx+VV0fPlR+AAmJaiueJZ8b7cXzJnuVNiyGjwIrrMn+6QjbUsR g23x6n1Kh32mR9OVuBDwHiTYkPF/bXPrVGx5UafnzuhGyM361BX/+6ART5OPkB13NCwQ B4eg== X-Gm-Message-State: AOAM530mfS+B8grfqhS/0BSKSYTgtdMq7JH4sf/TVuPP8bRGYBkJHQB6 Ol2BB1Yt4jMOvoU7915WFtVfAwNYv87dqUBWtvM= X-Google-Smtp-Source: ABdhPJwAnhzClWjQmp5sNkzcNplU2riHknOKWyw3YbSFsM0AGF4YSTZLXjPH5ueD3ha05KNEdt08jso4MIlwjvGKdAQ= X-Received: by 2002:a17:906:1918:: with SMTP id a24mr290802eje.432.1606251932367; Tue, 24 Nov 2020 13:05:32 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 24 Nov 2020 13:05:31 -0800 In-Reply-To: <925908cd-bc9d-4c57-9cec-d961c9dbad95@default> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194125 Archived-At: Drew Adams writes: >> Does anyone have any objections to, or see any problems with adding the >> lexical-binding cookie to autoload files, as in the attached patch? >> >> I've tested it, and it works just fine here. > > Ouch! > > "It works just fine here." Please define "works", > and "here". Surely those words do not need defining. :-) Do you actually mean to ask how exactly I tested this? The answer to that is that I have used emacs with the change for a couple of hours in my normal usage and found no issues. > If I understand this right then yes, I object strongly. > (It's possible I don't understand it right, however.) [...] > Why on earth would we assume that a user who wants to > update her autoloads for a given user directory or > file would necessarily want to force the code to use > `lexical-binding'=t? This will not force any other files to use lexical-binding. I don't understand what makes you think it would? AFAIK, there is only one thing that enables `lexical-binding' and that is if that buffer local variable is set to t. (You can also provide the optional LEXICAL argument to `eval', but I don't think that applies here.)