tags 50752 + patch thanks Lars Ingebrigtsen writes: > Yes, the names have changed in Emacs 28, so external packages that alter > the menus like this have to be adjusted. But I wonder whether we could > make `lookup-key' be case-insensitive in this case... As Glenn points out, we discussed this here: https://lists.gnu.org/r/emacs-devel/2021-03/msg00031.html We also discussed it here: https://lists.gnu.org/r/emacs-devel/2021-03/msg00014.html I had an incomplete patch in the works, but I dropped the ball here. Please find attached an updated and complete patch that should fix the above issue. In addition to the new tests, I have tested it locally, and without the patch, I can reproduce the issue reported here by Shuguang, i.e. I get this error: popup-menu: Empty menu With the patch, the menu is correctly displayed, as is expected. This is tested with pdf-tools-20211004.514 installed from MELPA, which should be equivalent to the latest version in the git repository at: http://github.com/vedang/pdf-tools Review and additional testing is very welcome.