bug#21521: 24.5; pdb default suggested command

[Stefan Kangas <stefan@marxist.se>]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

Noam Postavsky <npostavs@gmail.com> writes:
>
> Stefan Kangas <stefan@marxist.se> writes:
>
> > +(defcustom gud-pdb-command-name
> > +  (if (executable-find "pdb") "pdb" "python -m pdb")
> >    "File name for executing the Python debugger.
> >  This should be an executable on your path, or an absolute file name."
> >    :type 'string
>
> "python -m pdb" doesn't seem to be "an executable on your path, or an
> absolute file name", so I think the docstring needs updating too
> (assuming this setting does actually work).

You are correct.  The attached patch fixes this and adds a version tag.

Thanks,
Stefan Kangas

[-- Attachment #2: 0001-Use-python-m-pdb-when-pdb-is-missing-in-M-x-pdb.patch --]
[-- Type: application/octet-stream, Size: 992 bytes --]

From 8aed28a72c08e6b6585792341bce159249426381 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Thu, 11 Jul 2019 05:51:18 +0200
Subject: [PATCH] Use "python -m pdb" when "pdb" is missing in M-x pdb

* lisp/progmodes/gud.el (gud-pdb-command-name): Use "python -m pdb"
when "pdb" is missing.  (Bug#21521)
---
 lisp/progmodes/gud.el | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
index b6a4ad3cd0..30d4b19911 100644
--- a/lisp/progmodes/gud.el
+++ b/lisp/progmodes/gud.el
@@ -1673,9 +1673,10 @@ gud-pdb-marker-filter
 
     output))
 
-(defcustom gud-pdb-command-name "pdb"
-  "File name for executing the Python debugger.
-This should be an executable on your path, or an absolute file name."
+(defcustom gud-pdb-command-name
+  (if (executable-find "pdb") "pdb" "python -m pdb")
+  "Command that executes the Python debugger."
+  :version "27.1"
   :type 'string
   :group 'gud)
 
-- 
2.22.0