From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65719: [PATCH] Pass restart argument to 'kill-emacs-query-functions' Date: Sun, 3 Sep 2023 18:01:28 -0700 Message-ID: References: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39558"; mail-complaints-to="usenet@ciao.gmane.io" To: me@elken.dev, 65719@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 04 03:02:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcxz3-000A5i-3B for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Sep 2023 03:02:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcxyk-0001G4-Jj; Sun, 03 Sep 2023 21:02:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcxyc-0001Aq-MZ for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 21:02:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcxyc-0005KM-DP for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 21:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcxyb-0000Gi-VI for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 21:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 01:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65719-submit@debbugs.gnu.org id=B65719.16937892981003 (code B ref 65719); Mon, 04 Sep 2023 01:02:01 +0000 Original-Received: (at 65719) by debbugs.gnu.org; 4 Sep 2023 01:01:38 +0000 Original-Received: from localhost ([127.0.0.1]:47855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcxyD-0000G6-PU for submit@debbugs.gnu.org; Sun, 03 Sep 2023 21:01:38 -0400 Original-Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:45131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcxyB-0000Fp-Cu for 65719@debbugs.gnu.org; Sun, 03 Sep 2023 21:01:36 -0400 Original-Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-500c37d479aso1400124e87.2 for <65719@debbugs.gnu.org>; Sun, 03 Sep 2023 18:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693789289; x=1694394089; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=tflNqeWQq9UJWYunW6pzd2F2Y9MSLaC2pm6kXUJOPEk=; b=TI5WVNy6t9C/wI7Yc8GeB5uzjuYOr5ggEK0iP8eqKht4NzN+CzArLf5/i2d+XNnnDs WDG7LzYdaqyRmcqnsRrRgUlaxqIe0eJxpQ0raj/Ro6lx8/KP8Nk+g4Mjm0SQRXumKI7/ 9ZtaUPFLZcs303Yr8zmnqX7PIgzy8Ht7I46VXpjtw5S8fxQoXhiH/iXLMljGMh3/8s1H Xf2sqltv0zWk3g9ZxdrEXGNFvsZp3cvgDdLEBm0StACAnTZY41bikhLBX/PL/daYqdlE X1NsOsBBtVFavQe4vfP5NuHPAEXq0+9YvEVm97yuspRnHUjj9kXZRwsq0t6uyYRj08TR yhew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693789289; x=1694394089; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tflNqeWQq9UJWYunW6pzd2F2Y9MSLaC2pm6kXUJOPEk=; b=AL22Wf3k2AOk8DtkzLFAsOHgVmF5G9sA8RL8H+meCzTZZVn1E3rPEeaij2CjmIQYlu KALqvnGfOyTJWztdHNybwkppcGvTllEbv/xPBOeO3jYU27qqquMKetFAx+5Jpx6R7wbm Jk4F4+XucnXvzBPTaLRH1ppkxx+GZvuUsKWU+kpklk9Vc6W5Tv2jkTYNexEt5lalBH53 TzjRyaXDf3wtK6DOVdeIRR6gGUuPZSDRKUidXKWVwWPjLYshjTO1H/ox5ojaRGShhieY vS9FkboppT7tKjopQXrQtPg630D08t7ByRVbJLenKViesd0TaA6nRW6+vGzg8UZxpgMB kJwQ== X-Gm-Message-State: AOJu0YzSJ0yYDXoj+VOpyQMEUb7Yli1z/Yd21i4s/bpsY0XMEvRZGSLq Uiay2gj/G4C9xzXVbCcTdZws6DKRXQGnKV0B0e3iS8/6YT0= X-Google-Smtp-Source: AGHT+IHMHdbDxYdf54Y4PXKsJwYfQhcpEoAghGvy7/vUaXXUOv8Cemohyr10/RrVZyL0NpQWK3x0YL8MbeuVeKsHqFI= X-Received: by 2002:a05:6512:398e:b0:500:be66:e014 with SMTP id j14-20020a056512398e00b00500be66e014mr5927928lfu.53.1693789289265; Sun, 03 Sep 2023 18:01:29 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 18:01:28 -0700 In-Reply-To: <329566cab29d3bdd4cd7f2257ec9f92a@elken.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269204 Archived-At: me--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Small change here to pass the restart status to > 'kill-emacs-query-functions' in 'save-buffers-kill-emacs' so any > functions there can react to being restarted, sample use-case this may > be useful is if one is using a package like perspective.el to handle > buffer/window management and when calling `M-x restart-emacs` you WANT > your last session to be persisted, but just starting Emacs normally you > don't. > > There are other potential use-cases for this too, so hopefully this > patch is well-received. Thanks. The feature sounds useful, and the use-case makes sense. But isn't the change backwards-incompatible? Can we find a way to do this without any breaking changes? One idea would be to simply introduce a new variable that takes the argument, while making the old one obsolete. That would allow people to slowly migrate over to the new one, without everything suddenly breaking under their feet.