From: Stefan Kangas <stefankangas@gmail.com>
To: Eduardo Ochs <eduardoochs@gmail.com>, 72240@debbugs.gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#72240: The commit 17e26cf57e1 broke font-locking in maxima-mode
Date: Mon, 22 Jul 2024 00:29:05 -0700 [thread overview]
Message-ID: <CADwFkmmBbNLC=GM6zwmVBLc3X-5f1CRqKZ-fk0DqcZOuib-JcQ@mail.gmail.com> (raw)
In-Reply-To: <CADs++6h-TU5WSM1hvYrdSDb+35LNLav47CmJfz-NDEmSCd1z1g@mail.gmail.com>
tags 72240 + notabug
thanks
Eduardo Ochs <eduardoochs@gmail.com> writes:
> there are two Maxima modes around - one in Melpa and one in Maxima
> itself. They have different bugs, and lots of people, including me,
> prefer the Maxima mode that comes with Maxima. This bug report is
> about a change in Emacs that broke the font-locking in the Maxima mode
> that comes with Maxima - I didn't test the other Maxima mode.
>
> Something happened between these two commits:
>
> 3f7e26e2bed 2024-04-13 10:10:19 (define-globalized-minor-mode): Fix bug#58888
> 17e26cf57e1 2024-04-13 10:31:28 (define-globalized-minor-mode):
> Require the use of `run-mode-hooks`
>
> Until 3f7e26e2bed font-locking in .mac files worked, but from
> 17e26cf57e1 onwards it doesn't work anymore. In the current Emacs from
> git - where "current" means 2024jul21 - it doesn't work.
This should be reported to the maxima.el developers, I think.
They should change `maxima-mode' to use `run-mode-hooks' instead of
`run-hooks'. This is documented in etc/NEWS:
> ** 'define-globalized-minor-mode' requires that modes use 'run-mode-hooks'.
> Minor modes defined with 'define-globalized-minor-mode', such as
> 'global-font-lock-mode', will not be enabled any more in those buffers
> whose major modes fail to use 'run-mode-hooks'. Major modes defined
> with 'define-derived-mode' are not affected. 'run-mode-hooks' has been the
> recommended way to run major mode hooks since Emacs 22.
next prev parent reply other threads:[~2024-07-22 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 3:05 bug#72240: The commit 17e26cf57e1 broke font-locking in maxima-mode Eduardo Ochs
2024-07-22 7:29 ` Stefan Kangas [this message]
2024-10-05 1:15 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmmBbNLC=GM6zwmVBLc3X-5f1CRqKZ-fk0DqcZOuib-JcQ@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=72240@debbugs.gnu.org \
--cc=eduardoochs@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).