unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Morgan.J.Smith@outlook.com
Cc: 52878@debbugs.gnu.org
Subject: bug#52878: [PATCH] Fix display-comint-buffer-action default behavior
Date: Wed, 29 Dec 2021 12:35:26 -0800	[thread overview]
Message-ID: <CADwFkmmA7Tp4uOjHsfinwwYNfJxMSwOqaHwM0+=_Bna-JChJUw@mail.gmail.com> (raw)
In-Reply-To: <BYAPR05MB4023DD0E4608C9A4D87C034AC5449@BYAPR05MB4023.namprd05.prod.outlook.com> (Morgan J. Smith's message of "Wed, 29 Dec 2021 13:38:06 -0500")

Morgan.J.Smith@outlook.com writes:

> This is my first real contribution to Emacs :)

Congratulations, and welcome here!

> The recent change that added display-comint-buffer-action does not do
> what it was supposed to.  Since it is not a list, when it gets passed
> to display-buffer, display-buffer ignores the value.

I think we will see what will happen to that recent change.  There is
even talk about reverting it on emacs-devel, but nothing conclusive as
of yet.  So be aware that your patch might have to wait until that
discussion is concluded.





  reply	other threads:[~2021-12-29 20:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 18:38 bug#52878: [PATCH] Fix display-comint-buffer-action default behavior Morgan.J.Smith
2021-12-29 20:35 ` Stefan Kangas [this message]
2022-01-06 17:16 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmA7Tp4uOjHsfinwwYNfJxMSwOqaHwM0+=_Bna-JChJUw@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=52878@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).